Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34240

galera.MDEV-27862 fails binlog assert in close_thread_tables()

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 11.5.1
    • 11.5.2
    • Galera
    • None

    Description

      sql/sql_base.cc:970: int close_thread_tables(THD*): Assertion `(thd->state_flags & Open_tables_state::BACKUPS_AVAIL) || !thd->has_pending_row_events()' failed.
      		 
      240526 17:39:03 [ERROR] mysqld got signal 6 ;

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34150 Assertion failure in Diagnostics_area::set_error_status upon binary logging hitting tmp space limit

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            monty Michael Widenius added a comment -

            This bug was caused by moving flushing of the in-memory-row-events from close_thread_tables() to binlog_commit(). This was needed to be able to handle the case where binlog writes could fail.
            Galera have two case where the change caused problems:

            • Row events in commit_one_phase_2() was not done in the case the standard binary log was not enabled but Galera was using it internally.
            • Galera disabled the call to binlog_commit_flush_stmt_cache() for not ending transactions.

            Fixed by adding code that flushes the in-memory-row-events to the binary log (write, but now sync) in the two above cases if galera is enabled.

            monty Michael Widenius added a comment - This bug was caused by moving flushing of the in-memory-row-events from close_thread_tables() to binlog_commit(). This was needed to be able to handle the case where binlog writes could fail. Galera have two case where the change caused problems: Row events in commit_one_phase_2() was not done in the case the standard binary log was not enabled but Galera was using it internally. Galera disabled the call to binlog_commit_flush_stmt_cache() for not ending transactions. Fixed by adding code that flushes the in-memory-row-events to the binary log (write, but now sync) in the two above cases if galera is enabled.
            monty Michael Widenius added a comment -

            Fixed pushed to 11.5 tree

            monty Michael Widenius added a comment - Fixed pushed to 11.5 tree

            People

              monty Michael Widenius
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.