Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-340

Save replication comments for DROP TABLE.

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5.27
    • None
    • None

    Description

      <montywi> the task is the following:
      <montywi> If one now do:
      <montywi> DROP TABLE /* comment-for-replication */ t1,t2;
      <montywi> When we write it to the binary log we remove the comment
      <montywi> the task is to preserve the comment between drop table and the first table and write it to the replication log
      <montywi> tungsten needs this to be able to know from which server the drop table originated.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          holyfoot Alexey Botchkov created issue -
          monty Michael Widenius made changes -
          Field Original Value New Value
          Key TODO-207 MDEV-340
          Project MP todo [ 10100 ] MariaDB Development [ 10000 ]
          Workflow jira [ 12212 ] defaullt [ 12213 ]
          monty Michael Widenius made changes -
          Fix Version/s 5.5.26 [ 11100 ]
          holyfoot Alexey Botchkov made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          holyfoot Alexey Botchkov added a comment -

          Patch proposal:
          http://lists.askmonty.org/pipermail/commits/2012-July/003542.html

          holyfoot Alexey Botchkov added a comment - Patch proposal: http://lists.askmonty.org/pipermail/commits/2012-July/003542.html
          serg Sergei Golubchik added a comment -

          why this is still in progress and assigned to holyfoot, if there's a patch proposal? Who is going to review it?

          serg Sergei Golubchik added a comment - why this is still in progress and assigned to holyfoot , if there's a patch proposal? Who is going to review it?
          monty Michael Widenius added a comment -

          Review done over IRC:

          • Suggested fixing comment_length() to use pointers instead of index
          • Check for '' after /
          • Add test case.
          monty Michael Widenius added a comment - Review done over IRC: Suggested fixing comment_length() to use pointers instead of index Check for ' ' after / Add test case.
          holyfoot Alexey Botchkov added a comment -

          Updated patch:
          http://lists.askmonty.org/pipermail/commits/2012-July/003555.html

          holyfoot Alexey Botchkov added a comment - Updated patch: http://lists.askmonty.org/pipermail/commits/2012-July/003555.html
          holyfoot Alexey Botchkov added a comment -

          Final patch:
          http://lists.askmonty.org/pipermail/commits/2012-July/003556.html

          holyfoot Alexey Botchkov added a comment - Final patch: http://lists.askmonty.org/pipermail/commits/2012-July/003556.html
          holyfoot Alexey Botchkov made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow defaullt [ 12213 ] MariaDB v2 [ 45673 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 45673 ] MariaDB v3 [ 66369 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 66369 ] MariaDB v4 [ 131943 ]

          People

            holyfoot Alexey Botchkov
            holyfoot Alexey Botchkov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.