[MDEV-340] Save replication comments for DROP TABLE. Created: 2012-06-14  Updated: 2012-08-14  Resolved: 2012-08-14

Status: Closed
Project: MariaDB Server
Component/s: None
Fix Version/s: 5.5.27

Type: Task Priority: Major
Reporter: Alexey Botchkov Assignee: Alexey Botchkov
Resolution: Fixed Votes: 0
Labels: None


 Description   

<montywi> the task is the following:
<montywi> If one now do:
<montywi> DROP TABLE /* comment-for-replication */ t1,t2;
<montywi> When we write it to the binary log we remove the comment
<montywi> the task is to preserve the comment between drop table and the first table and write it to the replication log
<montywi> tungsten needs this to be able to know from which server the drop table originated.



 Comments   
Comment by Alexey Botchkov [ 2012-07-26 ]

Patch proposal:
http://lists.askmonty.org/pipermail/commits/2012-July/003542.html

Comment by Sergei Golubchik [ 2012-07-28 ]

why this is still in progress and assigned to holyfoot, if there's a patch proposal? Who is going to review it?

Comment by Michael Widenius [ 2012-07-31 ]

Review done over IRC:

  • Suggested fixing comment_length() to use pointers instead of index
  • Check for '' after /
  • Add test case.
Comment by Alexey Botchkov [ 2012-07-31 ]

Updated patch:
http://lists.askmonty.org/pipermail/commits/2012-July/003555.html

Comment by Alexey Botchkov [ 2012-07-31 ]

Final patch:
http://lists.askmonty.org/pipermail/commits/2012-July/003556.html

Generated at Thu Feb 08 06:28:01 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.