Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
N/A
-
None
Description
1. query_response_time/session_toggle.test demands include/have_debug_sync.inc, thus limiting itself to only debug builders. However, it doesn't in fact use either debug synchronization or other debug functionality and can be run on non-debug builds as well (unlike some other tests which use a plugin debug variable).
2. I suggest enabling the query_response_time suite on Windows. It is a tiny suite which only takes a few seconds, and enabling it will increase coverage.
Here is a proposed commit which includes both changes:
https://github.com/MariaDB/server/commit/93fc7c6b7d5f56ba48ebd5f0b1e4458b1bd2568c
diff --git a/mysql-test/collections/buildbot_suites.bat b/mysql-test/collections/buildbot_suites.bat
|
index 0198b03614918..05b9533f2eef9 100644
|
--- a/mysql-test/collections/buildbot_suites.bat
|
+++ b/mysql-test/collections/buildbot_suites.bat
|
@@ -8,5 +8,6 @@ plugins,^
|
mariabackup,^
|
roles,^
|
auth_gssapi,^
|
+query_response_time,^
|
rocksdb,^
|
sysschema
|
diff --git a/plugin/query_response_time/mysql-test/query_response_time/session_toggle.test b/plugin/query_response_time/mysql-test/query_response_time/session_toggle.test
|
index 8bf7124fbcb74..6b0326fa9a484 100644
|
--- a/plugin/query_response_time/mysql-test/query_response_time/session_toggle.test
|
+++ b/plugin/query_response_time/mysql-test/query_response_time/session_toggle.test
|
@@ -1,4 +1,3 @@
|
---source include/have_debug_sync.inc
|
--disable_ps_protocol
|
|
--echo #
|
Attachments
Issue Links
- is caused by
-
MDEV-33501 Extend query_response_time plugin to be compatible with Percona server
-
- Closed
-