Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33943

Query_log_event thread_id only writes first 4 bytes

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Won't Do
    • 10.5, 10.6, 10.11, 11.0(EOL), 11.1(EOL), 11.2(EOL), 11.3(EOL), 11.4
    • N/A
    • Replication
    • None

    Description

      The thread_id type is 8 bytes long, but only the first 4 are stored when the event is written into the binlog. The event should be extended to write the remaining 4 bytes of the thread_id in a separate piece of the event, which can be combined together when parsed.

      Attachments

        Issue Links

          relates to

          New Feature - A new feature of the product, which has yet to be developed. MDEV-7850 Extend GTID Binlog Events with Thread Id

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33924 Gtid_log_event thread_id missing in binlog when pseudo_thread_id is set to 0 or negative

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          split to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35646 pseudo_thread_id Can Overflow on Binlog Write

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            knielsen Kristian Nielsen added a comment -

            Sorry to always have to be the spoil-sport, but event format changes are not appropriate for GA releases. This would need to go in a dev release.

            knielsen Kristian Nielsen added a comment - Sorry to always have to be the spoil-sport, but event format changes are not appropriate for GA releases. This would need to go in a dev release.
            wlad Vladislav Vaintroub added a comment - - edited

            Connection id can't exceed 4 bytes (MDEV-15089)

            wlad Vladislav Vaintroub added a comment - - edited Connection id can't exceed 4 bytes ( MDEV-15089 )
            bnestere Brandon Nesterenko added a comment -

            knielsen I had thought about that when filing, but wasn't entirely sure, so thanks for commenting to make it clear

            But anyway it seems that MDEV-7850's Gtid_log_event should be reverted back to 32-bit as wlad mentions. Though now it seems we have an overflow bug where pseudo_thread_id itself can be set to a 64-bit value (and shown as such with SELECT @@pseudo_thread_id); whereas when writing it, it overflows to 32-bit. Perhaps this bug report should cover that instead.

            bnestere Brandon Nesterenko added a comment - knielsen I had thought about that when filing, but wasn't entirely sure, so thanks for commenting to make it clear But anyway it seems that MDEV-7850 's Gtid_log_event should be reverted back to 32-bit as wlad mentions. Though now it seems we have an overflow bug where pseudo_thread_id itself can be set to a 64-bit value (and shown as such with SELECT @@pseudo_thread_id); whereas when writing it, it overflows to 32-bit. Perhaps this bug report should cover that instead.
            bnestere Brandon Nesterenko added a comment -

            As connection id can't exceed 4 bytes, closing this JIRA, to cover the fixing of pseudo_thread_id (MDEV-35646)

            bnestere Brandon Nesterenko added a comment - As connection id can't exceed 4 bytes, closing this JIRA, to cover the fixing of pseudo_thread_id ( MDEV-35646 )

            People

              bnestere Brandon Nesterenko
              bnestere Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.