Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.6, 10.11, 11.0(EOL), 11.1(EOL), 11.2(EOL), 11.3(EOL), 11.4
-
None
Description
The extra flags check and actions when constructing a GTID log event during replication, i.e. the constructor invoked in log_event.cc when constructed from binlog content, currently checks that the true length of the event is consistent with the expectation that is set by each flag using DBUG_ASSERT() invocations. Instead, this check should be coded into the conditionals themselves, to ensure that we don't accidentally read memory beyond the end of the event, if the flag and data aren't consistent.
Attachments
Activity
Pushed into 10.6 as 89c907bd4f7
Merge conflict observed in 10.11 with fix in branch bb-10.11-MDEV-33672-mergefix. Note too, the branch has an additional 10.11 specific commit that depends on the prior commit. Please commit that when doing the merge as well. So the branch is organized as follows:
1. Commit to fix merge conflict: a838818b8c0
2. Commit with 10.11 extensions: 9ff8d4f852b
Hi knielsen!
If you have a free moment, there is a part 1 to this ready for review PR 3128.
That is, part 1 is for 10.6 flags, and once reviewed/approved; I'll move onto 10.11 for the start alter flags.