Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33631

Ubuntu/Debian MYSQL_SERVER_SUFFIX is version+suffix on MariaDB packaged versions

    XMLWordPrintable

Details

    Description

      A buildbot build of a debian/ubuntu package gets the full version number and suffix like

      https://buildbot.mariadb.org/#/builders/44/builds/28086/steps/5/logs/stdio

      # dpkg-gensymbols will not fail the build.
      mkdir -p builddir && cd builddir && \
      sh -c  'PATH=${MYSQL_BUILD_PATH:-"/usr/lib/ccache:/usr/local/bin:/usr/bin:/bin"} \
          	CC=aarch64-linux-gnu-gcc \
          	CXX=aarch64-linux-gnu-g++ \
          cmake -DCMAKE_INSTALL_PREFIX=/usr \
          -DWITHOUT_TOKUDB=true \
          -DCOMPILATION_COMMENT="mariadb.org binary distribution" \
          -DMYSQL_SERVER_SUFFIX="-1:10.4.34+maria~deb10" \
      

      or

      https://buildbot.mariadb.org/#/builders/360/builds/10063/steps/5/logs/stdio

          dh_auto_configure --builddirectory=builddir -- \
          -DCMAKE_BUILD_TYPE=RelWithDebInfo \
           \
           \
          -DCOMPILATION_COMMENT="mariadb.org binary distribution" \
          -DMYSQL_SERVER_SUFFIX="-1:10.6.18+maria~ubu2204" \
      

      The downstream gets an actual suffix:

      https://tests.reproducible-builds.org/debian/rbuild/bookworm/amd64/mariadb_10.11.4-1~deb12u1.rbuild.log.gz

      PATH=${MYSQL_BUILD_PATH:-"/usr/lib/ccache:/usr/local/bin:/usr/bin:/bin"} \
          dh_auto_configure --builddirectory=builddir -- \
          -DCMAKE_BUILD_TYPE=RelWithDebInfo \
          -DWITH_PMEM=ON \
           \
          -DCOMPILATION_COMMENT="Debian 12 " \
          -DMYSQL_SERVER_SUFFIX="-1~deb12u1" \
      

      The end results is silly repetition in MariaDB VERSION function:

      $ podman exec -ti mlatest mariadb -proot  -e 'select length(version()),version()'
      +-------------------+-----------------------------------------+
      | length(version()) | version()                               |
      +-------------------+-----------------------------------------+
      |                39 | 10.11.6-MariaDB-1:10.11.6+maria~ubu2204 |
      +-------------------+-----------------------------------------+
       
      ~/repos/build-mariadb-server-10.4 
      $ podman exec -ti mlatest mariadb -proot  -e 'select length(version()),version()'
      +-------------------+-----------------------------------------+
      | length(version()) | version()                               |
      +-------------------+-----------------------------------------+
      |                39 | 10.6.16-MariaDB-1:10.6.16+maria~ubu2004 |
      +-------------------+-----------------------------------------+
       
      ~/repos/build-mariadb-server-10.4 
      $ podman exec -ti mlatest mariadb -proot  -e 'select length(version()),version()'
      +-------------------+-----------------------------------------+
      | length(version()) | version()                               |
      +-------------------+-----------------------------------------+
      |                39 | 10.5.23-MariaDB-1:10.5.23+maria~ubu2004 |
      +-------------------+-----------------------------------------+
       
      ~/repos/build-mariadb-server-10.4 
      $ podman exec -ti mlatest mariadb -proot  -e 'select length(version()),version()'
      +-------------------+-----------------------------------------+
      | length(version()) | version()                               |
      +-------------------+-----------------------------------------+
      |                39 | 10.4.32-MariaDB-1:10.4.32+maria~ubu2004 |
      +-------------------+-----------------------------------------+
      

      Which results in PHP self tests failing on mariadb

      https://github.com/grooverdan/php-src/actions/runs/8183927946/job/22377535403

       
        FAILED TEST SUMMARY
      ---------------------------------------------------------------------
      Bug GH-8267 (Invalid error message when connection via SSL fails) [ext/mysqli/tests/gh8978.phpt]
      openssl_error_string() tests (OpenSSL >= 3.0) [ext/openssl/tests/openssl_error_string_basic_openssl3.phpt]
      openssl_private_decrypt() tests [ext/openssl/tests/openssl_private_decrypt_basic.phpt]
      mysqli_stmt_execute() - Stored Procedures [ext/mysqli/tests/mysqli_stmt_execute_stored_proc.phpt]
      mysqli_store_result() [ext/mysqli/tests/mysqli_store_result_copy.phpt]
      

      The PHP tests cap the VERSION() output at 25 characters.

      https://github.com/php/php-src/blob/master/ext/mysqli/tests/mysqli_store_result_copy.phpt#L162

      Attachments

        Activity

          People

            danblack Daniel Black
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.