Type:
Bug
Priority:
Major
Resolution:
Fixed
Affects Version/s:
10.2(EOL) , (14) 10.3(EOL) , 10.4(EOL) , 10.5 , 10.6 , 10.7(EOL) , 10.8(EOL) , 10.9(EOL) , 10.10(EOL) , 10.11 , 11.0(EOL) , 11.1(EOL) , 11.2(EOL) , 11.3(EOL) , 11.4
The class buf::Block_hint that was added in order to fix MDEV-23693 is an unnecessary performance hog that causes unnecessary lookups on buf_pool.page_hash .
Originally, I was thinking that this function could be removed as part of rewriting the buffer pool resizing in MDEV-29445 , but it turns out that we can do it independently of that. We only need to add a field btr_pcur_t::old_page_id to remember the page identifier where the persistent cursor position was stored, and pass this identifier to buf_page_optimistic_get() , which will have to perform a buf_pool.page_hash lookup anyway.
Furthermore, in btr_pcur_optimistic_latch_leaves() we had better look up the current page normally, and perform some tricks to prevent a deadlock when acquiring a latch on the previous page, if needed. This will also allow us to simplify the function btr_pcur_move_backward_from_page() .
{"report":{"fcp":769.3999998569489,"ttfb":150.39999985694885,"pageVisibility":"visible","entityId":128195,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"ff032896-6020-4d24-834c-a658d2391662","navigationType":0,"readyForUser":839.5999999046326,"redirectCount":0,"resourceLoadedEnd":884.3999998569489,"resourceLoadedStart":155.79999995231628,"resourceTiming":[{"duration":142.89999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":155.79999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":155.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":298.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":142.70000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":156.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":156.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":298.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":151.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":156.09999990463257,"connectEnd":156.09999990463257,"connectStart":156.09999990463257,"domainLookupEnd":156.09999990463257,"domainLookupStart":156.09999990463257,"fetchStart":156.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":156.09999990463257,"responseEnd":307.89999985694885,"responseStart":307.89999985694885,"secureConnectionStart":156.09999990463257},{"duration":223.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":156.19999980926514,"connectEnd":156.19999980926514,"connectStart":156.19999980926514,"domainLookupEnd":156.19999980926514,"domainLookupStart":156.19999980926514,"fetchStart":156.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":156.19999980926514,"responseEnd":379.59999990463257,"responseStart":379.59999990463257,"secureConnectionStart":156.19999980926514},{"duration":226.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":156.39999985694885,"connectEnd":156.39999985694885,"connectStart":156.39999985694885,"domainLookupEnd":156.39999985694885,"domainLookupStart":156.39999985694885,"fetchStart":156.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":156.39999985694885,"responseEnd":383.19999980926514,"responseStart":383.19999980926514,"secureConnectionStart":156.39999985694885},{"duration":227.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":156.39999985694885,"connectEnd":156.39999985694885,"connectStart":156.39999985694885,"domainLookupEnd":156.39999985694885,"domainLookupStart":156.39999985694885,"fetchStart":156.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":156.39999985694885,"responseEnd":383.69999980926514,"responseStart":383.69999980926514,"secureConnectionStart":156.39999985694885},{"duration":227.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":156.59999990463257,"connectEnd":156.59999990463257,"connectStart":156.59999990463257,"domainLookupEnd":156.59999990463257,"domainLookupStart":156.59999990463257,"fetchStart":156.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":156.59999990463257,"responseEnd":384.19999980926514,"responseStart":384.19999980926514,"secureConnectionStart":156.59999990463257},{"duration":228,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":156.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":156.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":384.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":227.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":156.89999985694885,"connectEnd":156.89999985694885,"connectStart":156.89999985694885,"domainLookupEnd":156.89999985694885,"domainLookupStart":156.89999985694885,"fetchStart":156.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":156.89999985694885,"responseEnd":384.69999980926514,"responseStart":384.69999980926514,"secureConnectionStart":156.89999985694885},{"duration":228.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":157,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":157,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":385.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":228.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":157.09999990463257,"connectEnd":157.09999990463257,"connectStart":157.09999990463257,"domainLookupEnd":157.09999990463257,"domainLookupStart":157.09999990463257,"fetchStart":157.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":157.09999990463257,"responseEnd":385.19999980926514,"responseStart":385.19999980926514,"secureConnectionStart":157.09999990463257},{"duration":406,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":158.19999980926514,"connectEnd":158.19999980926514,"connectStart":158.19999980926514,"domainLookupEnd":158.19999980926514,"domainLookupStart":158.19999980926514,"fetchStart":158.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":158.19999980926514,"responseEnd":564.1999998092651,"responseStart":564.1999998092651,"secureConnectionStart":158.19999980926514},{"duration":726.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":158.19999980926514,"connectEnd":158.19999980926514,"connectStart":158.19999980926514,"domainLookupEnd":158.19999980926514,"domainLookupStart":158.19999980926514,"fetchStart":158.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":158.19999980926514,"responseEnd":884.3999998569489,"responseStart":884.3999998569489,"secureConnectionStart":158.19999980926514},{"duration":157.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":520.5999999046326,"connectEnd":520.5999999046326,"connectStart":520.5999999046326,"domainLookupEnd":520.5999999046326,"domainLookupStart":520.5999999046326,"fetchStart":520.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":520.5999999046326,"responseEnd":678.5,"responseStart":678.5,"secureConnectionStart":520.5999999046326}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":33,"responseStart":151,"responseEnd":154,"domLoading":154,"domInteractive":908,"domContentLoadedEventStart":908,"domContentLoadedEventEnd":947,"domComplete":1848,"loadEventStart":1848,"loadEventEnd":1849,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":886.5},{"name":"bigPipe.sidebar-id.end","time":887.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.start","time":887.3999998569489},{"name":"bigPipe.activity-panel-pipe-id.end","time":889.8999998569489},{"name":"activityTabFullyLoaded","time":953.8999998569489}],"measures":[],"correlationId":"e363336b43ecaa","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":69,"dbReadsTimeInMs":13,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}