[MDEV-33584] sql plugin init failure with traditional sql_mode - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.4(EOL), 10.5
Fix Version/s: 10.4.34, 10.5.25, 10.11.8, 10.6.18, 11.0.6, 11.1.5, 11.2.4
Component/s: Storage Engine - Spider
Labels:
None

Description

splitted from Roel's comments in ~~MDEV-33494~~:

https://jira.mariadb.org/browse/MDEV-33494?focusedCommentId=280959&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-280959
https://jira.mariadb.org/browse/MDEV-33494?focusedCommentId=280955&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-280955

I think we should just set the sql_mode to the default instead of trying to fixing it in the spider init queries to fix any other potential failures of the same cause.

Attachments

Issue Links

split from

MDEV-33494 spider plugin init failure with no_zero_date sql_mode

Closed

Activity

Ascending order - Click to sort in descending order

Yuchen Pei added a comment - 2024-03-04 01:33

Hi holyfoot, ptal thanks

upstream/bb-10.5-ycp 1d7bfeed64fead00ae1b73e8d53a7dc2cf78e549

MDEV-33584 Use the default SQL_MODE for spider init queries

This should fix all future problems caused by a non-default global

sql_mode from the server where spider is to be installed.

Yuchen Pei added a comment - 2024-03-04 01:33 Hi holyfoot , ptal thanks upstream/bb-10.5-ycp 1d7bfeed64fead00ae1b73e8d53a7dc2cf78e549 MDEV-33584 Use the default SQL_MODE for spider init queries This should fix all future problems caused by a non-default global sql_mode from the server where spider is to be installed.

Alexey Botchkov added a comment - 2024-03-26 13:24

ok to push.
I like the fixed SQL_MODE much better.

Alexey Botchkov added a comment - 2024-03-26 13:24 ok to push. I like the fixed SQL_MODE much better.

Yuchen Pei added a comment - 2024-03-27 00:46 - edited

Thanks for the review. Added a test and pushed db0b9ec37ba16bb17fc41a39522a7a1898df6902 to 10.4.

I also took the liberty to push a ~~MDEV-33494~~ fix to 10.4, see ~~MDEV-33706~~.

Yuchen Pei added a comment - 2024-03-27 00:46 - edited Thanks for the review. Added a test and pushed db0b9ec37ba16bb17fc41a39522a7a1898df6902 to 10.4. I also took the liberty to push a MDEV-33494 fix to 10.4, see MDEV-33706 .

People

Assignee:: Yuchen Pei

Reporter:: Yuchen Pei

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2024-03-04 00:10

Updated:: 2024-03-27 22:15

Resolved:: 2024-03-27 02:45

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server