[MDEV-33428] Error messages ER_PACKAGE_ROUTINE_* are not good enough - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 11.4, 11.5(EOL)
Fix Version/s: 11.4.2
Component/s: Stored routines
Labels:
None

Description

MariaDB has the following messages:

ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY

        eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body"

ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED

        eng "Subroutine '%-.192s' has a forward declaration but is not defined"

They resemble similar messages in the Oracle database:

PLS-00323: subprogram or cursor 'name' is declared in a

package specification and must be defined in the package body

PLS-00328: A subprogram body must be defined for the forward declaration of 'name'.

However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid the non-standard terminology.

Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem.

It'll be more clear if the object type is printed explicitly, e.g.:

PROCEDURE 'p1' is declared in the package specification but is not defined in the package body

FUNCTION 'f1' has a forward declaration but is not defined

These messages will need new formats in errmgs-utf8.txt.

Attachments

Issue Links

relates to

MDEV-10591 Oracle-style packages

Closed

MDEV-32101 CREATE PACKAGE [BODY] for sql_mode=DEFAULT

Closed

links to

Packages in MariaDB default mode - Peter Gulutzan's blog

Activity

Ascending order - Click to sort in descending order

Alexander Barkov created issue - 2024-02-08 08:29

Alexander Barkov made changes - 2024-02-08 08:30

Field	Original Value	New Value
Description	> "Subroutine '%-.192s' is declared in the package specification > but is not defined in the package body" > "Subroutine '%-.192s' has a forward declaration but is not defined" > … which is wrong, there is no such thing as a subroutine, the term is > “routine”. > (Oracle has a thing called “subprogram” but it too would be a wrong term.) PLS-00323: subprogram or cursor '<varname>string</varname>' is declared in a package specification and must be defined in the package body PLS-00328: A subprogram body must be defined for the forward declaration of <varname>string</varname>. MariaDB has the following messages: {noformat} ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body" ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED eng "Subroutine '%-.192s' has a forward declaration but is not defined" {noformat} They resemble similar messages in the Oracle database: {noformat} PLS-00323: subprogram or cursor 'name' is declared in a package specification and must be defined in the package body PLS-00328: A subprogram body must be defined for the forward declaration of 'name'. {noformat} However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid a non-standard terminology. Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem. It'll be more clear if the object type is printed explicitly, e.g.: {noformat} PROCEDURE 'p1' is declared in the package specification but is not defined in the package body FUNCTION 'f1' has a forward declaration but is not defined {noformat}	MariaDB has the following messages: {noformat} ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body" ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED eng "Subroutine '%-.192s' has a forward declaration but is not defined" {noformat} They resemble similar messages in the Oracle database: {noformat} PLS-00323: subprogram or cursor 'name' is declared in a package specification and must be defined in the package body PLS-00328: A subprogram body must be defined for the forward declaration of 'name'. {noformat} However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid a non-standard terminology. Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem. It'll be more clear if the object type is printed explicitly, e.g.: {noformat} PROCEDURE 'p1' is declared in the package specification but is not defined in the package body FUNCTION 'f1' has a forward declaration but is not defined {noformat}

Alexander Barkov made changes - 2024-02-08 08:30

Description

MariaDB has the following messages:

{noformat}
ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY
        eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body"
ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED
        eng "Subroutine '%-.192s' has a forward declaration but is not defined"
{noformat}

They resemble similar messages in the Oracle database:
{noformat}
PLS-00323: subprogram or cursor 'name' is declared in a
package specification and must be defined in the package body

PLS-00328: A subprogram body must be defined for the forward declaration of 'name'.
{noformat}

However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid a non-standard terminology.

Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem.

It'll be more clear if the object type is printed explicitly, e.g.:

{noformat}
PROCEDURE 'p1' is declared in the package specification but is not defined in the package body

FUNCTION 'f1' has a forward declaration but is not defined
{noformat}

MariaDB has the following messages:

{noformat}
ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY
        eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body"

ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED
        eng "Subroutine '%-.192s' has a forward declaration but is not defined"
{noformat}

They resemble similar messages in the Oracle database:
{noformat}
PLS-00323: subprogram or cursor 'name' is declared in a
package specification and must be defined in the package body

PLS-00328: A subprogram body must be defined for the forward declaration of 'name'.
{noformat}

However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid a non-standard terminology.

Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem.

It'll be more clear if the object type is printed explicitly, e.g.:

{noformat}
PROCEDURE 'p1' is declared in the package specification but is not defined in the package body

FUNCTION 'f1' has a forward declaration but is not defined
{noformat}

Alexander Barkov made changes - 2024-02-08 08:30

Description

MariaDB has the following messages:

{noformat}
ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY
        eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body"

ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED
        eng "Subroutine '%-.192s' has a forward declaration but is not defined"
{noformat}

They resemble similar messages in the Oracle database:
{noformat}
PLS-00323: subprogram or cursor 'name' is declared in a
package specification and must be defined in the package body

PLS-00328: A subprogram body must be defined for the forward declaration of 'name'.
{noformat}

However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid a non-standard terminology.

Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem.

It'll be more clear if the object type is printed explicitly, e.g.:

{noformat}
PROCEDURE 'p1' is declared in the package specification but is not defined in the package body

FUNCTION 'f1' has a forward declaration but is not defined
{noformat}

MariaDB has the following messages:

{noformat}
ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY
        eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body"

ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED
        eng "Subroutine '%-.192s' has a forward declaration but is not defined"
{noformat}

They resemble similar messages in the Oracle database:
{noformat}
PLS-00323: subprogram or cursor 'name' is declared in a
package specification and must be defined in the package body

PLS-00328: A subprogram body must be defined for the forward declaration of 'name'.
{noformat}

However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid the non-standard terminology.

Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem.

It'll be more clear if the object type is printed explicitly, e.g.:

{noformat}
PROCEDURE 'p1' is declared in the package specification but is not defined in the package body

FUNCTION 'f1' has a forward declaration but is not defined
{noformat}

Alexander Barkov made changes - 2024-02-08 08:32

Description

MariaDB has the following messages:

{noformat}
ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY
        eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body"

ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED
        eng "Subroutine '%-.192s' has a forward declaration but is not defined"
{noformat}

They resemble similar messages in the Oracle database:
{noformat}
PLS-00323: subprogram or cursor 'name' is declared in a
package specification and must be defined in the package body

PLS-00328: A subprogram body must be defined for the forward declaration of 'name'.
{noformat}

However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid the non-standard terminology.

Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem.

It'll be more clear if the object type is printed explicitly, e.g.:

{noformat}
PROCEDURE 'p1' is declared in the package specification but is not defined in the package body

FUNCTION 'f1' has a forward declaration but is not defined
{noformat}

MariaDB has the following messages:

{noformat}
ER_PACKAGE_ROUTINE_IN_SPEC_NOT_DEFINED_IN_BODY
        eng "Subroutine '%-.192s' is declared in the package specification but is not defined in the package body"

ER_PACKAGE_ROUTINE_FORWARD_DECLARATION_NOT_DEFINED
        eng "Subroutine '%-.192s' has a forward declaration but is not defined"
{noformat}

They resemble similar messages in the Oracle database:
{noformat}
PLS-00323: subprogram or cursor 'name' is declared in a
package specification and must be defined in the package body

PLS-00328: A subprogram body must be defined for the forward declaration of 'name'.
{noformat}

However, the words "subroutine" and "subprogram" are not in the SQL Standard (at least in stored routines context), it's better to avoid the non-standard terminology.

Also, it's not clear an object of which type (PROCEDURE or FUNCTION) has the problem.

It'll be more clear if the object type is printed explicitly, e.g.:

{noformat}
PROCEDURE 'p1' is declared in the package specification but is not defined in the package body

FUNCTION 'f1' has a forward declaration but is not defined
{noformat}

These messages will need new formats in errmgs-utf8.txt.

Alexander Barkov made changes - 2024-02-08 11:09

Link

This issue relates to ~~MDEV-32101~~ [ ~~MDEV-32101~~ ]

Alexander Barkov made changes - 2024-02-08 11:09

Link

This issue relates to ~~MDEV-10591~~ [ ~~MDEV-10591~~ ]

Alexander Barkov made changes - 2024-02-08 11:24

Remote Link

This issue links to "Packages in MariaDB default mode - Peter Gulutzan's blog (Web Link)" [ 36608 ]

Alexander Barkov made changes - 2024-02-08 11:56

Priority

Major [ 3 ]

Critical [ 2 ]

Alexander Barkov made changes - 2024-02-08 13:13

issue.field.resolutiondate

2024-02-08 13:13:07.0

2024-02-08 13:13:07.142

Alexander Barkov made changes - 2024-02-08 13:13

Fix Version/s		11.4.2 [ 29633 ]
Fix Version/s		11.5.1 [ 29634 ]
Fix Version/s	11.4 [ 29301 ]
Assignee		Alexander Barkov [ bar ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Julien Fritsch made changes - 2024-02-20 13:53

Fix Version/s

11.5.1 [ 29634 ]

People

Assignee:: Alexander Barkov

Reporter:: Alexander Barkov

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2024-02-08 08:29

Updated:: 2024-02-20 13:53

Resolved:: 2024-02-08 13:13

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration