[MDEV-33158] The macro MYSQL_THDVAR_ULONG leads to undefined behaviour, calling mysql_sys_var_long - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL), 10.11, 11.0(EOL), 11.1(EOL), 11.2(EOL), 11.3(EOL), 11.8
Fix Version/s: 10.5.28, 10.6.21, 10.11.11, 11.4.5, 11.7.2
Component/s: Embedded Server, Server
Labels:
- UBSAN
- affects-tests

Description

Now that ~~MDEV-26272~~ has been fixed and a cmake -DWITH_UBSAN=ON build with clang can pass the server bootstrap, we can find more undefined behaviour that is not flagged by GCC. Here is an example:

10.4 832e96deb6f368591dcb35a4fa33b2fd770aa17a
/mariadb/10.4/storage/innobase/handler/ha_innodb.cc:1821:9: runtime error: call to function mysql_sys_var_long(THD, int) through pointer to incorrect function type 'unsigned long ()(THD , int)'

This is flagged for the function thd_lock_wait_timeout(), which simply accesses a data member that has been defined as follows:

static MYSQL_THDVAR_ULONG(lock_wait_timeout, PLUGIN_VAR_RQCMDARG,

  "Timeout in seconds an InnoDB transaction may wait for a lock before being rolled back. Values above 100000000 disable the timeout.",

  NULL, NULL, 50, 0, 1024 * 1024 * 1024, 0);

// ...

static struct st_mysql_sys_var* innobase_system_variables[]= {

// ...

  MYSQL_SYSVAR(lock_wait_timeout),

// ...

  NULL

};

maria_declare_plugin(innobase)

// ...

innobase_system_variables

// ...

},

// ...

maria_declare_plugin_end;

Attachments

Issue Links

duplicates

MDEV-35623 UBSAN: function-type-mismatch in spider_param_conn_recycle[_mode/_strict], spider_param_internal_xa_snapshot, and spider_param_block_size

Closed

MDEV-35698 UBSAN: runtime error: call to function mysql_sys_var_int through pointer to incorrect function type in spider_param_force_commit

Closed

MDEV-35726 runtime error: call to function mysql_sys_var_int through pointer to incorrect function type in thd_lock_wait_timeout on ALTER

Closed

MDEV-35736 UBSAN: runtime error: call to function mysql_sys_var_long through pointer to incorrect function type in myrocks::get_or_create_tx and other myrocks::* functions

Closed

is blocked by

MDEV-26272 The macro MASTER_INFO_VAR invokes undefined behaviour

Closed

relates to

MDEV-25454 Make MariaDB server UBSAN safe

Confirmed

MDEV-34512 UBSAN system variable type mismatches for ha_myisam.cc and ha_maria.cc

Confirmed

(2 relates to)

Activity

Ascending order - Click to sort in descending order

Marko Mäkelä created issue - 2024-01-03 07:05

Marko Mäkelä made changes - 2024-01-03 07:05

Field	Original Value	New Value
Link		This issue is blocked by ~~MDEV-26272~~ [ ~~MDEV-26272~~ ]

Marko Mäkelä made changes - 2024-01-03 07:05

Status

Open [ 1 ]

Confirmed [ 10101 ]

Marko Mäkelä made changes - 2024-01-03 08:32

Link

This issue relates to MDEV-25454 [ MDEV-25454 ]

Julien Fritsch made changes - 2024-05-03 14:32

Fix Version/s	11.0 [ 28320 ]
Fix Version/s	11.3 [ 28565 ]

Brandon Nesterenko made changes - 2024-06-11 14:10

Assignee

Sergei Golubchik [ serg ]

Brandon Nesterenko [ JIRAUSER48702 ]

Daniel Black made changes - 2024-07-02 07:49

Link

This issue relates to MDEV-34512 [ MDEV-34512 ]

Julien Fritsch made changes - 2024-09-10 14:58

Fix Version/s

10.4 [ 22408 ]

Julien Fritsch made changes - 2024-09-10 15:29

Fix Version/s

11.1 [ 28549 ]

Julien Fritsch made changes - 2024-11-22 17:12

Fix Version/s

11.2(EOL) [ 28603 ]

Roel Van de Paar made changes - 2024-11-24 21:43

Labels

UBSAN

UBSAN affects-tests

Roel Van de Paar made changes - 2024-12-02 19:26

Affects Version/s

11.8 [ 29921 ]

Roel Van de Paar made changes - 2024-12-03 00:06

Fix Version/s		11.4 [ 29301 ]
Fix Version/s		11.7 [ 29815 ]
Fix Version/s		11.8 [ 29921 ]

Roel Van de Paar made changes - 2024-12-03 00:06

Fix Version/s

11.8 [ 29921 ]

Daniel Black made changes - 2025-01-09 07:12

Assignee

Brandon Nesterenko [ JIRAUSER48702 ]

Daniel Black [ danblack ]

Daniel Black made changes - 2025-01-09 07:20

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Daniel Black made changes - 2025-01-09 07:22

Assignee	Daniel Black [ danblack ]	Brandon Nesterenko [ JIRAUSER48702 ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Daniel Black made changes - 2025-01-09 21:03

Link

This issue duplicates ~~MDEV-35726~~ [ ~~MDEV-35726~~ ]

Daniel Black made changes - 2025-01-09 21:23

Link

This issue duplicates ~~MDEV-35736~~ [ ~~MDEV-35736~~ ]

Daniel Black made changes - 2025-01-09 21:31

Link

This issue duplicates ~~MDEV-35623~~ [ ~~MDEV-35623~~ ]

Daniel Black made changes - 2025-01-09 21:46

Link

This issue duplicates ~~MDEV-35735~~ [ ~~MDEV-35735~~ ]

Daniel Black made changes - 2025-01-09 21:52

Link

This issue duplicates ~~MDEV-35698~~ [ ~~MDEV-35698~~ ]

Daniel Black made changes - 2025-01-10 01:26

Link

This issue duplicates ~~MDEV-35735~~ [ ~~MDEV-35735~~ ]

Brandon Nesterenko made changes - 2025-01-11 15:22

Assignee	Brandon Nesterenko [ JIRAUSER48702 ]	Daniel Black [ danblack ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Daniel Black made changes - 2025-01-12 02:42

issue.field.resolutiondate

2025-01-12 02:42:17.0

2025-01-12 02:42:16.835

Daniel Black made changes - 2025-01-12 02:42

Fix Version/s		10.5.28 [ 29952 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Fix Version/s	10.11 [ 27614 ]
Fix Version/s	11.4 [ 29301 ]
Fix Version/s	11.7 [ 29815 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

JiraAutomate made changes - 2025-01-12 02:42

Fix Version/s		10.6.21 [ 29953 ]
Fix Version/s		10.11.11 [ 29954 ]
Fix Version/s		11.4.5 [ 29956 ]
Fix Version/s		11.7.2 [ 29914 ]

People

Assignee:: Daniel Black

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2024-01-03 07:05

Updated:: 2025-01-12 02:42

Resolved:: 2025-01-12 02:42

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration