Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33135

Refactor Field::reset()

Details

    • Task
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      Field architecture has accumulated a lot of maintainance debt.

      This task is dedicated to refactoring Field::reset:

      • Make it lighter, its purpose is very simple
      • Add sanitizer hints
      • It should be as simple as the return value should be void

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33049 Assertion `marked_for_write_or_computed()' failed in bool Field_new_decimal::store_value(const my_decimal*, int*)

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-33141 Straight out the write-marking requirement rules

          • Major - Major loss of function.
          • Open

          Activity

            libing Libing Song added a comment -

            MDEV-33049 added some debug code to suppress an assertion in unpack_field(). They should be removed with this issue together.
            https://github.com/MariaDB/server/pull/2953

            libing Libing Song added a comment - MDEV-33049 added some debug code to suppress an assertion in unpack_field(). They should be removed with this issue together. https://github.com/MariaDB/server/pull/2953

            People

              nikitamalyavin Nikita Malyavin
              nikitamalyavin Nikita Malyavin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.