Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33120

System log table names are case insensitive with lower-cast-table-names=0

Details

    Description

      I run this MTR test on Linux:

      --source include/have_lowercase0.inc
      		 
      --source include/have_case_sensitive_file_system.inc
      		 
       
      		 
      CREATE TABLE mysql.GENERAL_log (a INT);
      		 
      INSERT INTO mysql.GENERAL_log VALUES (1),(2);
      		 
      DROP TABLE mysql.GENERAL_log;

      It fails on the INSERT statement with the following error:

      mysqltest: At line 13: query 'INSERT INTO mysql.GENERAL_log VALUES (1),(2)' failed: ER_CANT_LOCK_LOG_TABLE (1556): You can't use locks with log tables

      This is wrong. GENERAL_log is not a log table.

      The problem resides in the function get_table_category(), in these line:

          if (lex_string_eq(&GENERAL_LOG_NAME, name))
      		 
            return TABLE_CATEGORY_LOG;

      This is wrong to compare table names case insensitively in Linux.
      Table names should be compared according to --lower-case-table-names.

      The same problem is repeatable for "slow_log" and "transaction_registry".

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-31340 Remove MY_COLLATION_HANDLER::strcasecmp()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Description I run this MTR test on Linux:

            {code:sql}
            --source include/have_lowercase0.inc
            --source include/have_case_sensitive_file_system.inc

            SET @save_general_log_state = @@global.general_log;
            SET @save_log_output= @@global.log_output;
            SET GLOBAL general_log = 'ON';
            SET GLOBAL log_output='TABLE';
            TRUNCATE TABLE mysql.general_log;

            CREATE TABLE mysql.GENERAL_log (a INT);
            INSERT INTO mysql.GENERAL_log VALUES (1),(2);
            SELECT command_type, argument FROM mysql.general_log;
            DROP TABLE mysql.GENERAL_log;

            SET GLOBAL general_log = @save_general_log_state;
            SET GLOBAL log_output = @save_log_output;
            {code}

            It fails on the INSERT statement with the following error:
            {noformat}
            mysqltest: At line 19: query 'INSERT INTO mysql.GENERAL_log VALUES (1),(2)' failed: ER_CANT_LOCK_LOG_TABLE (1556): You can't use locks with log tables
            {noformat}

            This is wrong. GENERAL_log is not a log table.

            The problem resides in the function get_table_category(), in these line:

            {code:cpp}
                if (lex_string_eq(&GENERAL_LOG_NAME, name))
                  return TABLE_CATEGORY_LOG;
            {code}

            This is wrong to compare table names case insensitively in Linux.
            Table names should be compared according to --lower-case-table-names.

            The same problem is repeatable for "slow_log" and "transaction_registry".
            		I run this MTR test on Linux:

            {code:sql}
            --source include/have_lowercase0.inc
            --source include/have_case_sensitive_file_system.inc

            CREATE TABLE mysql.GENERAL_log (a INT);
            INSERT INTO mysql.GENERAL_log VALUES (1),(2);
            DROP TABLE mysql.GENERAL_log;
            {code}

            It fails on the INSERT statement with the following error:
            {noformat}
            mysqltest: At line 19: query 'INSERT INTO mysql.GENERAL_log VALUES (1),(2)' failed: ER_CANT_LOCK_LOG_TABLE (1556): You can't use locks with log tables
            {noformat}

            This is wrong. GENERAL_log is not a log table.

            The problem resides in the function get_table_category(), in these line:

            {code:cpp}
                if (lex_string_eq(&GENERAL_LOG_NAME, name))
                  return TABLE_CATEGORY_LOG;
            {code}

            This is wrong to compare table names case insensitively in Linux.
            Table names should be compared according to --lower-case-table-names.

            The same problem is repeatable for "slow_log" and "transaction_registry".
            bar Alexander Barkov made changes -
            Description I run this MTR test on Linux:

            {code:sql}
            --source include/have_lowercase0.inc
            --source include/have_case_sensitive_file_system.inc

            CREATE TABLE mysql.GENERAL_log (a INT);
            INSERT INTO mysql.GENERAL_log VALUES (1),(2);
            DROP TABLE mysql.GENERAL_log;
            {code}

            It fails on the INSERT statement with the following error:
            {noformat}
            mysqltest: At line 19: query 'INSERT INTO mysql.GENERAL_log VALUES (1),(2)' failed: ER_CANT_LOCK_LOG_TABLE (1556): You can't use locks with log tables
            {noformat}

            This is wrong. GENERAL_log is not a log table.

            The problem resides in the function get_table_category(), in these line:

            {code:cpp}
                if (lex_string_eq(&GENERAL_LOG_NAME, name))
                  return TABLE_CATEGORY_LOG;
            {code}

            This is wrong to compare table names case insensitively in Linux.
            Table names should be compared according to --lower-case-table-names.

            The same problem is repeatable for "slow_log" and "transaction_registry".
            		I run this MTR test on Linux:

            {code:sql}
            --source include/have_lowercase0.inc
            --source include/have_case_sensitive_file_system.inc

            CREATE TABLE mysql.GENERAL_log (a INT);
            INSERT INTO mysql.GENERAL_log VALUES (1),(2);
            DROP TABLE mysql.GENERAL_log;
            {code}

            It fails on the INSERT statement with the following error:
            {noformat}
            mysqltest: At line 13: query 'INSERT INTO mysql.GENERAL_log VALUES (1),(2)' failed: ER_CANT_LOCK_LOG_TABLE (1556): You can't use locks with log tables
            {noformat}

            This is wrong. GENERAL_log is not a log table.

            The problem resides in the function get_table_category(), in these line:

            {code:cpp}
                if (lex_string_eq(&GENERAL_LOG_NAME, name))
                  return TABLE_CATEGORY_LOG;
            {code}

            This is wrong to compare table names case insensitively in Linux.
            Table names should be compared according to --lower-case-table-names.

            The same problem is repeatable for "slow_log" and "transaction_registry".
            serg Sergei Golubchik made changes -
            Assignee Alexander Barkov [ bar ]
            bar Alexander Barkov made changes -
            Fix Version/s 11.4.2 [ 29633 ]
            Fix Version/s 11.5.1 [ 29634 ]
            Fix Version/s 10.5.26 [ 29832 ]
            Fix Version/s 10.6.19 [ 29833 ]
            Fix Version/s 10.11.9 [ 29834 ]
            Fix Version/s 11.1.6 [ 29835 ]
            Fix Version/s 11.2.5 [ 29836 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 11.4 [ 29301 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            dbart Daniel Bartholomew made changes -
            Fix Version/s 11.4.3 [ 29837 ]
            Fix Version/s 11.5.2 [ 29838 ]
            Fix Version/s 11.4.2 [ 29633 ]
            Fix Version/s 11.5.1 [ 29634 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.