Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-33075

Sending TERM to mariadb no longer gracefully terminates the process

Details

    Description

      As of 11.4 git sha 70de4075a18c12ed7e55db9a49e66eb6cff308b2 (but not necessarily due to this commit), sending the TERM signal to mariadb on macOS no longer gracefully terminates mariadb. In fact, nothing appears to happen from the perspective of the console (running mariadb in the foreground rather than as a daemon).

      Attachments

        Issue Links

          Activity

            Gosselin, can you bisect to find out which change broke macOS? What are stacktraces of all threads, when server does not stop? There was no merging of 11.4 into 10.5, so this time it would be something different.

            wlad Vladislav Vaintroub added a comment - Gosselin , can you bisect to find out which change broke macOS? What are stacktraces of all threads, when server does not stop? There was no merging of 11.4 into 10.5, so this time it would be something different.
            Gosselin Dave Gosselin added a comment -

            Yes, I'll bisect to find where the problem came in. When I spoke about a merge, I didn't mean a merge from 11.4 to into 10.5. Instead, I meant a merge from an earlier version, into 10.5. I'm not certain about which earlier version, but a bisect will uncover it.

            Gosselin Dave Gosselin added a comment - Yes, I'll bisect to find where the problem came in. When I spoke about a merge, I didn't mean a merge from 11.4 to into 10.5. Instead, I meant a merge from an earlier version, into 10.5. I'm not certain about which earlier version, but a bisect will uncover it.
            Gosselin Dave Gosselin added a comment - - edited

            The commit where 10.5 breaks on macOS is git sha 952ab9a59659b28f10ce2770e17249e0ff5b0681
            The commit before it, 4980fcb9909449f4d65886ee2c1d1080bb3d55a5 works fine.

            I attached a sampling of the process as provided by Activity Monitor in macOS which shows all the threads.

            Gosselin Dave Gosselin added a comment - - edited The commit where 10.5 breaks on macOS is git sha 952ab9a59659b28f10ce2770e17249e0ff5b0681 The commit before it, 4980fcb9909449f4d65886ee2c1d1080bb3d55a5 works fine. I attached a sampling of the process as provided by Activity Monitor in macOS which shows all the threads.

            I see that this removed some but not all use of HAVE_POLL. Could the remaining use be removed, along with the compile-time checks for HAVE_POLL and HAVE_POLL_H? That would speed up the initial CMake invocation.

            marko Marko Mäkelä added a comment - I see that this removed some but not all use of HAVE_POLL . Could the remaining use be removed, along with the compile-time checks for HAVE_POLL and HAVE_POLL_H ? That would speed up the initial CMake invocation.

            This was recently backported to the 10.5 branch.

            marko Marko Mäkelä added a comment - This was recently backported to the 10.5 branch.

            People

              wlad Vladislav Vaintroub
              Gosselin Dave Gosselin
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.