Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32243

Make older compilers happy with log.h

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 11.2(EOL)
    • 11.2.2
    • Server
    • None
    • gcc version 4.9.0

    Description

      Compilation fails producing errors like 

      /home/hf/wgit/mdev-22168-1103/sql/log.h: In constructor ‘Cache_flip_event_log::Cache_flip_event_log()’:
      		 
      /home/hf/wgit/mdev-22168-1103/sql/log.h:453:74: error: missing initializer for member ‘st_io_cache::pos_in_file’ [-Werror=missing-field-initializers]
      		 
                                  current(&log_file), alt(&alt_buf), ref_count(1) {}

      It's a known and fixed compiler issue
      But i think it worth adapting for these compilers, also explicitly clear the buffer with the
      my_b_clear() is faster and readable.

      Attachments

        People

          holyfoot Alexey Botchkov
          holyfoot Alexey Botchkov
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Git Integration

              Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.