looks ok. although I recommend to rename online_alter_update_row_count → update_row_count, there's nothing in the logic of this method that's specific to the online alter
Sergei Golubchik
added a comment - looks ok. although I recommend to rename online_alter_update_row_count → update_row_count , there's nothing in the logic of this method that's specific to the online alter
I disagree, serg. Normally, for example, Delete_log_event, would increase the number of rows affected (in the statement). Here we actually want to know the number of resulting rows in the new table. So then delete decreases, and update doesn't change.
Nikita Malyavin
added a comment - I disagree, serg . Normally, for example, Delete_log_event, would increase the number of rows affected (in the statement). Here we actually want to know the number of resulting rows in the new table . So then delete decreases, and update doesn't change.
sure, that's what I meant too. your "update_row_count" method updates the number of rows in the table. Delete_row_event always decreases this number of rows, not only in online alter.
Sergei Golubchik
added a comment - sure, that's what I meant too. your "update_row_count" method updates the number of rows in the table. Delete_row_event always decreases this number of rows, not only in online alter.
People
Nikita Malyavin
Elena Stepanova
Votes:
0Vote for this issue
Watchers:
3Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":1676.9000000953674,"ttfb":648.3000001907349,"pageVisibility":"visible","entityId":123678,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"95938c30-28d4-4f53-9981-e92cbe34bc79","navigationType":0,"readyForUser":1789.4000000953674,"redirectCount":0,"resourceLoadedEnd":2246.9000000953674,"resourceLoadedStart":658.4000000953674,"resourceTiming":[{"duration":468.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":658.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":658.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1126.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":468.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":658.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":658.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1127,"responseStart":0,"secureConnectionStart":0},{"duration":523.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":659,"connectEnd":659,"connectStart":659,"domainLookupEnd":659,"domainLookupStart":659,"fetchStart":659,"redirectEnd":0,"redirectStart":0,"requestStart":659,"responseEnd":1182.5999999046326,"responseStart":1182.5999999046326,"secureConnectionStart":659},{"duration":610,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":659.0999999046326,"connectEnd":659.0999999046326,"connectStart":659.0999999046326,"domainLookupEnd":659.0999999046326,"domainLookupStart":659.0999999046326,"fetchStart":659.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":659.0999999046326,"responseEnd":1269.0999999046326,"responseStart":1269,"secureConnectionStart":659.0999999046326},{"duration":617.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":659.4000000953674,"connectEnd":659.4000000953674,"connectStart":659.4000000953674,"domainLookupEnd":659.4000000953674,"domainLookupStart":659.4000000953674,"fetchStart":659.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":659.4000000953674,"responseEnd":1276.5999999046326,"responseStart":1276.5999999046326,"secureConnectionStart":659.4000000953674},{"duration":615.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":662.0999999046326,"connectEnd":662.0999999046326,"connectStart":662.0999999046326,"domainLookupEnd":662.0999999046326,"domainLookupStart":662.0999999046326,"fetchStart":662.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":662.0999999046326,"responseEnd":1277.2000002861023,"responseStart":1277.2000002861023,"secureConnectionStart":662.0999999046326},{"duration":615.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":662.3000001907349,"connectEnd":662.3000001907349,"connectStart":662.3000001907349,"domainLookupEnd":662.3000001907349,"domainLookupStart":662.3000001907349,"fetchStart":662.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":662.3000001907349,"responseEnd":1277.7000002861023,"responseStart":1277.7000002861023,"secureConnectionStart":662.3000001907349},{"duration":669.9000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":662.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":662.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1332.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":615.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":662.5999999046326,"connectEnd":662.5999999046326,"connectStart":662.5999999046326,"domainLookupEnd":662.5999999046326,"domainLookupStart":662.5999999046326,"fetchStart":662.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":662.5999999046326,"responseEnd":1278.2000002861023,"responseStart":1278.2000002861023,"secureConnectionStart":662.5999999046326},{"duration":669.7999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":662.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":662.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1332.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":616,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":662.9000000953674,"connectEnd":662.9000000953674,"connectStart":662.9000000953674,"domainLookupEnd":662.9000000953674,"domainLookupStart":662.9000000953674,"fetchStart":662.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":662.9000000953674,"responseEnd":1278.9000000953674,"responseStart":1278.9000000953674,"secureConnectionStart":662.9000000953674},{"duration":1450.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":663.9000000953674,"connectEnd":663.9000000953674,"connectStart":663.9000000953674,"domainLookupEnd":663.9000000953674,"domainLookupStart":663.9000000953674,"fetchStart":663.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":663.9000000953674,"responseEnd":2114.4000000953674,"responseStart":2114.4000000953674,"secureConnectionStart":663.9000000953674},{"duration":1583,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":663.9000000953674,"connectEnd":663.9000000953674,"connectStart":663.9000000953674,"domainLookupEnd":663.9000000953674,"domainLookupStart":663.9000000953674,"fetchStart":663.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":663.9000000953674,"responseEnd":2246.9000000953674,"responseStart":2246.9000000953674,"secureConnectionStart":663.9000000953674},{"duration":752.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1367.4000000953674,"connectEnd":1367.4000000953674,"connectStart":1367.4000000953674,"domainLookupEnd":1367.4000000953674,"domainLookupStart":1367.4000000953674,"fetchStart":1367.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":1367.4000000953674,"responseEnd":2119.9000000953674,"responseStart":2119.9000000953674,"secureConnectionStart":1367.4000000953674},{"duration":611.9000000953674,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1669.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1669.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2281.800000190735,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":490,"responseStart":648,"responseEnd":653,"domLoading":656,"domInteractive":2302,"domContentLoadedEventStart":2302,"domContentLoadedEventEnd":2362,"domComplete":2819,"loadEventStart":2819,"loadEventEnd":2820,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2283.300000190735},{"name":"bigPipe.sidebar-id.end","time":2284.2000002861023},{"name":"bigPipe.activity-panel-pipe-id.start","time":2284.4000000953674},{"name":"bigPipe.activity-panel-pipe-id.end","time":2285.800000190735},{"name":"activityTabFullyLoaded","time":2380.5}],"measures":[],"correlationId":"4d00e481c88c14","effectiveType":"4g","downlink":9.1,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":10,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
looks ok. although I recommend to rename online_alter_update_row_count → update_row_count, there's nothing in the logic of this method that's specific to the online alter