Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31768

Alias MASTER_DEMOTE_TO_REPLICA for MASTER_DEMOTE_TO_SLAVE

Details

    Description

      Implement MASTER_DEMOTE_TO_REPLICA alias to the existing MASTER_DEMOTE_TO_SLAVE.

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-20122 Deprecate MASTER_USE_GTID=Current_Pos to favor new MASTER_DEMOTE_TO_SLAVE option

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-20122 Deprecate MASTER_USE_GTID=Current_Pos to favor new MASTER_DEMOTE_TO_SLAVE option

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            Elkin Andrei Elkin created issue -
            knielsen Kristian Nielsen added a comment -

            I hope you don't mean the part about deprecating the existing the use of "SLAVE", that's really not acceptable.

            It's one thing that some people dislike some word, and a lot of extra code is added to the server. But it's very disrespectful to try to force such dislike on other people and make them spend extra effort to change their setup or handle deprecation warnings.

            Does this idea of deprecating the use of "slave" in replication code come from somewhere?

            - Kristian.

            knielsen Kristian Nielsen added a comment - I hope you don't mean the part about deprecating the existing the use of "SLAVE", that's really not acceptable. It's one thing that some people dislike some word, and a lot of extra code is added to the server. But it's very disrespectful to try to force such dislike on other people and make them spend extra effort to change their setup or handle deprecation warnings. Does this idea of deprecating the use of "slave" in replication code come from somewhere? - Kristian.
            Elkin Andrei Elkin added a comment - - edited

            knielsen, the most of the abolishment 'slave' aliasing has been done in MDEV-20601. So this one has to follow suit already via a consistency argument.

            > Does this idea of deprecating the use of "slave" in replication code come from somewhere?
            Yes, from there. It's all rooted by MDEV-18777. I love some of the users' comments!
            But there's no actual plan to deprecate, thankfully! (Sorry for confusing you in the original version of this reply, I had not caught up on the development of 18777 discussion).

            I wish I could rewind to that discussion to suggest as an alternative e.g a enterprise connector feature to re-write queries for supposedly historical justice minded DBA:s.

            Elkin Andrei Elkin added a comment - - edited knielsen , the most of the abolishment 'slave' aliasing has been done in MDEV-20601 . So this one has to follow suit already via a consistency argument. > Does this idea of deprecating the use of "slave" in replication code come from somewhere? Yes, from there. It's all rooted by MDEV-18777 . I love some of the users' comments! But there's no actual plan to deprecate, thankfully! (Sorry for confusing you in the original version of this reply, I had not caught up on the development of 18777 discussion). I wish I could rewind to that discussion to suggest as an alternative e.g a enterprise connector feature to re-write queries for supposedly historical justice minded DBA:s.
            ralf.gebhardt Ralf Gebhardt made changes -
            Field Original Value New Value
            Description Implement MASTER_DEMOTE_TO_REPLICA alias to the existing MASTER_DEMOTE_TO_SLAVE and deprecate the latter. Implement MASTER_DEMOTE_TO_REPLICA alias to the existing MASTER_DEMOTE_TO_SLAVE.
            Elkin Andrei Elkin made changes -
            Summary Abolish MASTER_DEMOTE_TO_SLAVE of Change-Master Alias MASTER_DEMOTE_TO_SLAVE of Change-Master in 20601 style
            ralf.gebhardt Ralf Gebhardt made changes -
            Summary Alias MASTER_DEMOTE_TO_SLAVE of Change-Master in 20601 style Alias MASTER_DEMOTE_TO_REPLICA for MASTER_DEMOTE_TO_SLAVE
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Brandon Nesterenko [ JIRAUSER48702 ]
            bnestere Brandon Nesterenko made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bnestere Brandon Nesterenko added a comment -

            Hey Elkin!

            This is ready for review: PR 2760

            bnestere Brandon Nesterenko added a comment - Hey Elkin ! This is ready for review: PR 2760
            bnestere Brandon Nesterenko made changes -
            Assignee Brandon Nesterenko [ JIRAUSER48702 ] Andrei Elkin [ elkin ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.11 [ 27614 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.10 [ 27530 ]
            danblack Daniel Black added a comment -

            reminder ^

            danblack Daniel Black added a comment - reminder ^
            Elkin Andrei Elkin added a comment -

            Looks good. Sorry for delaying this very small one.

            Elkin Andrei Elkin added a comment - Looks good. Sorry for delaying this very small one.
            Elkin Andrei Elkin made changes -
            Assignee Andrei Elkin [ elkin ] Brandon Nesterenko [ JIRAUSER48702 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            Elkin Andrei Elkin added a comment -

            danblack: thanks for the heads up! Small ones like this should be automatically listed on the top of one's sprint list items. Oth, of course 'smallness' can't be always termed in the line number . This time it could.

            Elkin Andrei Elkin added a comment - danblack : thanks for the heads up! Small ones like this should be automatically listed on the top of one's sprint list items. Oth, of course 'smallness' can't be always termed in the line number . This time it could.
            danblack Daniel Black made changes -
            issue.field.resolutiondate 2024-02-13 03:01:28.0 2024-02-13 03:01:28.199
            danblack Daniel Black made changes -
            Fix Version/s 10.11.8 [ 29630 ]
            Fix Version/s 10.11 [ 27614 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            JIraAutomate JiraAutomate made changes -
            Fix Version/s 11.0.6 [ 29628 ]
            Fix Version/s 11.1.5 [ 29629 ]
            Fix Version/s 11.2.4 [ 29631 ]
            Fix Version/s 11.3.3 [ 29632 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 11.4.2 [ 29633 ]
            Fix Version/s 11.5.1 [ 29634 ]
            Fix Version/s 11.3.3 [ 29632 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 11.5.1 [ 29634 ]
            Roel Roel Van de Paar made changes -

            People

              bnestere Brandon Nesterenko
              Elkin Andrei Elkin
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.