Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31379

Undefined behavior in the reference Ed25519 implementation

Details

    Description

      This is from the MaxScale sources but the same undefined behavior that UBSAN reports should be in MariaDB as well:

      /home/timofey_turenko_mariadb_com/MaxScale/server/modules/authenticator/Ed25519/ref10/fe_sq.c:121:76: runtime error: left shift of negative value -46510040
      		 
          #0 0x7f0921c31b8b in mxs_ed25519_ref10_fe_sq /home/timofey_turenko_mariadb_com/MaxScale/server/modules/authenticator/Ed25519/ref10/fe_sq.c:121
      		 
          #1 0x7f0921c0dc63 in mxs_ed25519_ref10_ge_frombytes_negate_vartime /home/timofey_turenko_mariadb_com/MaxScale/server/modules/authenticator/Ed25519/ref10/ge_frombytes.c:21
      		 
          #2 0x7f0921c0addd in crypto_sign_open /home/timofey_turenko_mariadb_com/MaxScale/server/modules/authenticator/Ed25519/ref10/open.c:24

      It seems this problem has also been found by others:
      https://github.com/hyperledger/iroha-ed25519/commit/b61a1e77af5dc458ed6a5aee395d5b22775a4917
      https://github.com/randombit/botan/issues/1372

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31801 Undefined behavior in ed25519

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is part of

          Task - A task that needs to be done. MDEV-25454 Make MariaDB server UBSAN safe

          • Major - Major loss of function.
          • Confirmed

          Task - A task that needs to be done. MDEV-33073 always green buildbot

          • Major - Major loss of function.
          • Stalled
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MXS-4686 Undefined behavior in ed25519 plugin

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-730 Reference ed25519 implementation contained undefined behaviour

          • Major - Major loss of function.
          • Closed

          Activity

            Transition Time In Source Status Execution Times
            Daniel Black made transition -
            Open Confirmed
            		278d 20h 23m 1
            Daniel Black made transition -
            Confirmed In Review
            		1h 32m 1
            Sergei Golubchik made transition -
            In Review In Testing
            		20d 16h 12m 1
            Sergei Golubchik made transition -
            In Testing Closed
            		19h 58m 1

            People

              serg Sergei Golubchik
              markus makela markus makela
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.