Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30951

Make small facelift to Innotop perl script

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Won't Do
    • 10.6
    • N/A
    • Platform Debian
    • None

    Description

      Debian has extra tool named Innotop which is good and mature state but currently it does not pass perlcritic even in most permissive setup. Also it would be nice to turn on 'Modern Perl' that Innotop would be more future proof.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21452 Use condition variables and normal mutexes instead of InnoDB os_event and mutex

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            illuusio Tuukka Pasanen created issue -
            illuusio Tuukka Pasanen made changes -
            Field Original Value New Value
            Assignee Tuukka Pasanen [ JIRAUSER49166 ]
            illuusio Tuukka Pasanen made changes -
            Component/s Platform Debian [ 10136 ]
            Component/s debian [ 19005 ]
            Key MDBF-552 MDEV-30951
            Project MariaDB Foundation Development [ 11901 ] MariaDB Server [ 10000 ]
            marko Marko Mäkelä added a comment -

            While you are at it, should this script be packaged for all operating systems, instead of residing in debian/additions/innotop/innotop of the source tree?

            I remember looking at this script in the past, possibly related to MDEV-18582 when I was thinking of removing some parts of the SHOW ENGINE INNODB STATUS output, since the same information can be obtained via better structured interfaces. In the end, I decided to keep the output compatible with the script.

            It would also be a good idea to test that the script can actually produce nonzero counters for everything. At least starting with MDEV-29694, the section 'Insert Buffers' should be useless.

            marko Marko Mäkelä added a comment - While you are at it, should this script be packaged for all operating systems, instead of residing in debian/additions/innotop/innotop of the source tree? I remember looking at this script in the past, possibly related to MDEV-18582 when I was thinking of removing some parts of the SHOW ENGINE INNODB STATUS output, since the same information can be obtained via better structured interfaces. In the end, I decided to keep the output compatible with the script. It would also be a good idea to test that the script can actually produce nonzero counters for everything. At least starting with MDEV-29694 , the section 'Insert Buffers' should be useless.
            marko Marko Mäkelä added a comment -

            In MDEV-21452 the SEMAPHORES section of SHOW ENGINE INNODB STATUS was intentionally left blank because innotop wants to find that section.

            marko Marko Mäkelä added a comment - In MDEV-21452 the SEMAPHORES section of SHOW ENGINE INNODB STATUS was intentionally left blank because innotop wants to find that section.
            marko Marko Mäkelä made changes -
            illuusio Tuukka Pasanen added a comment - - edited

            One thing that I was thinking Innotop should have (very) small test set that can assure that things like you describe can be tested and make work. I'll make first very small facelift and try to make this tool slowly better. If there is known problem please open new Issue and you can assign to me as there is small interest (I use this tool on openSUSE also) for this tool.

            illuusio Tuukka Pasanen added a comment - - edited One thing that I was thinking Innotop should have (very) small test set that can assure that things like you describe can be tested and make work. I'll make first very small facelift and try to make this tool slowly better. If there is known problem please open new Issue and you can assign to me as there is small interest (I use this tool on openSUSE also) for this tool.
            elenst Elena Stepanova made changes -
            Fix Version/s 10.6 [ 24028 ]
            Affects Version/s 10.6 [ 24028 ]
            anel Anel Husakovic added a comment -

            What is the status of mytop illuusio ?

            anel Anel Husakovic added a comment - What is the status of mytop illuusio ?
            illuusio Tuukka Pasanen added a comment -

            Haven't check mytop lately and every repo I've encountered is like last commit from 6 years ago. Mytop and Innotop seems to be very different beasts.

            illuusio Tuukka Pasanen added a comment - Haven't check mytop lately and every repo I've encountered is like last commit from 6 years ago. Mytop and Innotop seems to be very different beasts.
            illuusio Tuukka Pasanen made changes -
            Fix Version/s N/A [ 14700 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Won't Do [ 10201 ]
            Status Open [ 1 ] Closed [ 6 ]

            People

              illuusio Tuukka Pasanen
              illuusio Tuukka Pasanen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.