[MDEV-30951] Make small facelift to Innotop perl script Created: 2023-03-29  Updated: 2023-05-23

Status: Open
Project: MariaDB Server
Component/s: Platform Debian
Affects Version/s: 10.6
Fix Version/s: 10.6

Type: Bug Priority: Major
Reporter: Tuukka Pasanen Assignee: Tuukka Pasanen
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-21452 Use condition variables and normal mu... Closed

 Description   

Debian has extra tool named Innotop which is good and mature state but currently it does not pass perlcritic even in most permissive setup. Also it would be nice to turn on 'Modern Perl' that Innotop would be more future proof.



 Comments   
Comment by Marko Mäkelä [ 2023-03-29 ]

While you are at it, should this script be packaged for all operating systems, instead of residing in debian/additions/innotop/innotop of the source tree?

I remember looking at this script in the past, possibly related to MDEV-18582 when I was thinking of removing some parts of the SHOW ENGINE INNODB STATUS output, since the same information can be obtained via better structured interfaces. In the end, I decided to keep the output compatible with the script.

It would also be a good idea to test that the script can actually produce nonzero counters for everything. At least starting with MDEV-29694, the section 'Insert Buffers' should be useless.

Comment by Marko Mäkelä [ 2023-03-30 ]

In MDEV-21452 the SEMAPHORES section of SHOW ENGINE INNODB STATUS was intentionally left blank because innotop wants to find that section.

Comment by Tuukka Pasanen [ 2023-03-30 ]

One thing that I was thinking Innotop should have (very) small test set that can assure that things like you describe can be tested and make work. I'll make first very small facelift and try to make this tool slowly better. If there is known problem please open new Issue and you can assign to me as there is small interest (I use this tool on openSUSE also) for this tool.

Comment by Anel Husakovic [ 2023-05-12 ]

What is the status of mytop illuusio ?

Comment by Tuukka Pasanen [ 2023-05-23 ]

Haven't check mytop lately and every repo I've encountered is like last commit from 6 years ago. Mytop and Innotop seems to be very different beasts.

Generated at Thu Feb 08 10:20:08 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.