Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30905

Remove old_alter_table variable

Details

    Description

      It has been deprecated since 10.3 and has no practical importance since it has been replaced by alter_algorithm, so it should be OK to remove it already.

      Attachments

        Issue Links

          relates to

          New Feature - A new feature of the product, which has yet to be developed. MDEV-33655 Remove alter_algorithm

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik added a comment -

            The general sysvar removal approach is — mark a variable deprecated. Remove when all releases where it was not deprecated have reached EOL.

            This is obviously the case here, old_alter_table can be removed.

            serg Sergei Golubchik added a comment - The general sysvar removal approach is — mark a variable deprecated. Remove when all releases where it was not deprecated have reached EOL. This is obviously the case here, old_alter_table can be removed.
            lstartseva Lena Startseva added a comment -

            serg, I guess that the information in the documentation for the variable (old_alter_table) should also be corrected in fill_help_tables.sql and on the site (here, maybe after merge), and in the description of "Use copy algorithm if" in sql_table.cc

            lstartseva Lena Startseva added a comment - serg , I guess that the information in the documentation for the variable ( old_alter_table ) should also be corrected in fill_help_tables.sql and on the site (here, maybe after merge), and in the description of "Use copy algorithm if" in sql_table.cc
            serg Sergei Golubchik added a comment -

            yes, documentation will be updated after this is pushed. fill_help_tables.sql is generated from the documentation.

            and I'll fix the comment before pushing, thanks!

            serg Sergei Golubchik added a comment - yes, documentation will be updated after this is pushed. fill_help_tables.sql is generated from the documentation. and I'll fix the comment before pushing, thanks!
            lstartseva Lena Startseva added a comment -

            Ok to push

            lstartseva Lena Startseva added a comment - Ok to push

            People

              serg Sergei Golubchik
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.