Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30853

Remove Percona's backup locks support from mariabackup

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11
    • None
    • Backup
    • None

    Description

      Percona has their own backup locks implementation. Percona's xtrabackup is supposed to be worked not only with Percona Server, but also with MySQL and MariaDB. So the code detects if server supports Percona's backup locks, then it uses them instead of FTWRL.

      There is no need in that code in mariabackup, as it does not support Percona's backup locks.

      There is also --no-backup-locks option. The option disables such detection, and it's supposed that FTWRL will be used instead.

      See lock_tables() function and the code around have_backup_locks global variable for details.

      This is dead code for mariabackup, so it can be deleted along with --no-backup-locks option.

      Attachments

        Activity

          People

            Unassigned Unassigned
            vlad.lesin Vladislav Lesin
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.