Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30822

Adjust wsrep_sst_mariabackup.sh to understand both pre-MDEV-18931 and post-MDEV-18931 file naming

Details

    Description

      The patch for MDEV-18931 introduced a new naming for MariaDB backup files.

      In this task we'll additionally fix wsrep_sst_mariabackup.sh to support SST for multi-version environment, when SST is done from an old (pre-MDEV-18931) node to a new (post-MDEV-18931) node.

      A possible solution (proposed by sysprg and serg) would be to check (before doing the actual job) the backup directory for old files and rename them (if exit) according to the new naming, e.g. like this:

      [ -f "$DATA/xtrabackup_galera_info" ] && mv "$DATA/xtrabackup_galera_info" "$DATA/mariadb_backup_galera_info"

      (and similar renames for other essential files).

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34856 Galera Cluster upgrade from 11.0 to 11.1 fails, eventually leads to crash

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-18931 Rename Mariabackup's xtrabackup_* files to mariadb_backup_*

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            naugrim Naugrim Naugrimsson added a comment -

            Do I assume correctly that there is currently no way to upgrade a Galera Cluser 11.0 to 11.1 by using mariadb-backup because the donor sends The file "xtrabackup_galera_info" while the joiner expects "mariadb_backup_galera_info"?

            naugrim Naugrim Naugrimsson added a comment - Do I assume correctly that there is currently no way to upgrade a Galera Cluser 11.0 to 11.1 by using mariadb-backup because the donor sends The file "xtrabackup_galera_info" while the joiner expects "mariadb_backup_galera_info"?
            monty Michael Widenius added a comment -

            We are working on a fix for this and hope to have it done soon.
            Sorry, for the delay but somehow the seriousness of this bug was not realised until very late.

            monty Michael Widenius added a comment - We are working on a fix for this and hope to have it done soon. Sorry, for the delay but somehow the seriousness of this bug was not realised until very late.
            sysprg Julius Goryavsky added a comment -

            Proposed fix: https://github.com/MariaDB/server/commit/9f1b30923a4ce9dab6b89c8e5eb16237ea7fa659

            sysprg Julius Goryavsky added a comment - Proposed fix: https://github.com/MariaDB/server/commit/9f1b30923a4ce9dab6b89c8e5eb16237ea7fa659
            sysprg Julius Goryavsky added a comment -

            Updated fix - taking into account second file transfer for xtrabackup_galera_info and non-galera-specific files: https://github.com/MariaDB/server/commit/485b0248fbb848de667fa4a15b6b480fde933796

            sysprg Julius Goryavsky added a comment - Updated fix - taking into account second file transfer for xtrabackup_galera_info and non-galera-specific files: https://github.com/MariaDB/server/commit/485b0248fbb848de667fa4a15b6b480fde933796
            ramesh Ramesh Sivaraman added a comment -

            sysprg File naming change looks good with updated fix

            ramesh Ramesh Sivaraman added a comment - sysprg File naming change looks good with updated fix
            sysprg Julius Goryavsky added a comment -

            Fixed, https://github.com/MariaDB/server/commit/68e968bc98074378bd5d14846f517954410dee19

            sysprg Julius Goryavsky added a comment - Fixed, https://github.com/MariaDB/server/commit/68e968bc98074378bd5d14846f517954410dee19

            People

              sysprg Julius Goryavsky
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.