Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30647

Remove Current_Pos from MASTER_USE_GTID options

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Won't Do
    • N/A
    • Replication
    • None

    Description

      Where MDEV-20122 deprecated the Current_Pos replication option of CHANGE MASTER MASTER_USE_GTID, this ticket tracks its removal.

      Additional behaviors to consider in this removal:

      • Depending on the gtid strict mode option, setting gtid_slave_pos before gtid_binlog_pos should either be disallowed when strict mode is on, or allowed, and the warning should be removed when strict mode is off.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-28839 Convert master_use_gtid = current_pos to slave_pos in mtr suites

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-20122 Deprecate MASTER_USE_GTID=Current_Pos to favor new MASTER_DEMOTE_TO_SLAVE option

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          split to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32976 Un-deprecate MASTER_USE_GTID=Current_Pos

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            knielsen Kristian Nielsen added a comment -

            We need to keep the syntax CHANGE MASTER TO MASTER_USE_GTID=current_pos for backwards compatibility. So it must not be removed.

            There's also no technical need to remove MASTER_USE_GTID=current_pos. It uses the @@gtid_current_pos which is also needed for the MASTER_DEMOTE_TO_SLAVE. And it works as intended and documented.

            So the MASTER_USE_GTID should stay, it's just good to have the MASTER_DEMOTE_TO_SLAVE as an alternative that works better for "sloppy" setups where manual updates are occasionally done on the slave.

            knielsen Kristian Nielsen added a comment - We need to keep the syntax CHANGE MASTER TO MASTER_USE_GTID=current_pos for backwards compatibility. So it must not be removed. There's also no technical need to remove MASTER_USE_GTID=current_pos. It uses the @@gtid_current_pos which is also needed for the MASTER_DEMOTE_TO_SLAVE. And it works as intended and documented. So the MASTER_USE_GTID should stay, it's just good to have the MASTER_DEMOTE_TO_SLAVE as an alternative that works better for "sloppy" setups where manual updates are occasionally done on the slave.
            Elkin Andrei Elkin added a comment -

            I don't have any strong opinion on this. When knielsen points to the "old" method as still useful, we should not rush to remove it.

            Elkin Andrei Elkin added a comment - I don't have any strong opinion on this. When knielsen points to the "old" method as still useful, we should not rush to remove it.
            bnestere Brandon Nesterenko added a comment -

            If we aren't going to remove the Current_Pos option, should its deprecation warning be removed? Or perhaps changed to a note that MASTER_DEMOTE_TO_SLAVE should be considered instead.

            bnestere Brandon Nesterenko added a comment - If we aren't going to remove the Current_Pos option, should its deprecation warning be removed? Or perhaps changed to a note that MASTER_DEMOTE_TO_SLAVE should be considered instead.
            knielsen Kristian Nielsen added a comment -

            bnestere That sounds good to me.

            knielsen Kristian Nielsen added a comment - bnestere That sounds good to me.
            bnestere Brandon Nesterenko added a comment -

            The option is being kept for backwards compatibility, as well as many users still use it.

            bnestere Brandon Nesterenko added a comment - The option is being kept for backwards compatibility, as well as many users still use it.

            People

              bnestere Brandon Nesterenko
              bnestere Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.