Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30180

Server hang with innodb_undo_log_truncate=ON

Details

    Description

      The fix of MDEV-27414 turns out to be incomplete. The server can still hang, with a deadlock between buf_pool_t::release_freed_page() and trx_purge_truncate_history(). In the latter, we'd better actively wait for the former to complete:

      diff --git a/storage/innobase/trx/trx0purge.cc b/storage/innobase/trx/trx0purge.cc
      		 
      index b834c5d070d..e162456e63f 100644
      		 
      --- a/storage/innobase/trx/trx0purge.cc
      		 
      +++ b/storage/innobase/trx/trx0purge.cc
      		 
      @@ -768,11 +768,12 @@ TRANSACTIONAL_TARGET static void trx_purge_truncate_history()
      		 
               auto block= reinterpret_cast<buf_block_t*>(bpage);
      		 
               if (!bpage->lock.x_lock_try())
      		 
               {
      		 
      +        rescan:
      		 
                 /* Let buf_pool_t::release_freed_page() proceed. */
      		 
                 mysql_mutex_unlock(&buf_pool.flush_list_mutex);
      		 
      -          std::this_thread::yield();
      		 
      +          mysql_mutex_lock(&buf_pool.mutex);
      		 
                 mysql_mutex_lock(&buf_pool.flush_list_mutex);
      		 
      -        rescan:
      		 
      +          mysql_mutex_unlock(&buf_pool.mutex);
      		 
                 bpage= UT_LIST_GET_LAST(buf_pool.flush_list);
      		 
                 continue;
      		 
               }

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-29986 Set innodb_undo_tablespaces=3 by default

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30863 Server freeze, all threads in trx_assign_rseg_low

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31343 Another server hang with innodb_undo_log_truncate=ON

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33009 Server hangs for a long time with innodb_undo_log_truncate=ON

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27414 Server may hang when innodb_undo_log_truncate=ON

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            axel Axel Schwenke added a comment -

            I can confirm that commit be6a3d9a01c exhibits the hang and that this hang is gone (fixed) in commit 64231528ed6.

            axel Axel Schwenke added a comment - I can confirm that commit be6a3d9a01c exhibits the hang and that this hang is gone (fixed) in commit 64231528ed6 .
            marko Marko Mäkelä added a comment -

            Unfortunately, MDEV-30863 is another hang in this area.

            marko Marko Mäkelä added a comment - Unfortunately, MDEV-30863 is another hang in this area.

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.