[MDEV-30171] When we upgrade the mariadb from 10.3.13 to 10.3.36, we found memory leak in mysql_upgrade. - Jira

Details

Type: Bug
Status: Open (View Workflow)
Priority: Minor
Resolution: Unresolved
Affects Version/s: 10.3.36
Fix Version/s: None
Component/s: Upgrades
Labels:
- beginner-friendly
- upgrade
Environment:
Linux

Description

When we upgrade the mariadb from 10.3.13 to 10.3.36, we found some memory leak in mysql_upgrade.
We can reproduce this bug in the following way:

1. download the code of mariadb-10.3.13, and create a file to compile this code. I put this compilation file in the attachment. Then we create a mysqld instance by this way:

//  Run the build.sh file and specify the basedir

$ sh build.sh  -d  /flash3/mariadb_data/mysql

// Install dependencies

$ make install

// initialization

$ /flash3/mariadb_10_3_13/scripts/mysql_install_db --basedir='/flash3/mariadb_data/mysql' --datadir='/flash3/mariadb_data/data'

// Create an instance using port 1235

$ /flash3/mariadb_10_3_13/sql/mysqld --basedir=/flash3/mariadb_data/mysql --datadir=/flash3/mariadb_data/data --port=1235 --socket=/flash3/mariadb_data/mysql/mysql.sock&

// Connect into a mysqld instance by root

$ mysql -h127.0.0.1 -P1234 -uroot

2. Create some tables on the Mariadb-10.3.13 instance

MariaDB> create database test_1;

MariaDB> use test_1;

MariaDB> create table t(a int);

MariaDB> insert into t values(1),(2);

MariaDB> shutdown;

3. Compile the code of mariadb-10.3.36 and create an instance in the same data directory with mariadb-10.3.13.

// Compile the code of mariadb-10.3.36 by using the build.sh file.

$ sh build.sh

// Create an instance in the same directory with mariadb-10.3.13. And use the port 1246.

$ flash3/mariadb_10_3_36/sql/mysqld --basedir=/flash3/mariadb_data/mysql --datadir=/flash3/mariadb_data/data --port=1246 --socket=/flash3/mariadb_data/mysql/mysql.sock&

4. Run the mysql_upgrade of mariadb-10.3.36

$ /flash3/mariadb_10_3_36/client/mysql_upgrade -uroot -p -S /flash3/mariadb_data/mysql/mysql.sock

Now the warning appears：

Phase 1/7: Checking and upgrading mysql database

Processing databases

mysql

mysql.column_stats                                 OK

mysql.columns_priv                                 OK

mysql.db                                           OK

mysql.event                                        OK

mysql.func                                         OK

mysql.gtid_slave_pos                               OK

mysql.help_category                                OK

mysql.help_keyword                                 OK

mysql.help_relation                                OK

mysql.help_topic                                   OK

mysql.host                                         OK

mysql.index_stats                                  OK

mysql.innodb_index_stats                           OK

mysql.innodb_table_stats                           OK

mysql.plugin                                       OK

mysql.proc                                         OK

mysql.procs_priv                                   OK

mysql.proxies_priv                                 OK

mysql.roles_mapping                                OK

mysql.servers                                      OK

mysql.table_stats                                  OK

mysql.tables_priv                                  OK

mysql.time_zone                                    OK

mysql.time_zone_leap_second                        OK

mysql.time_zone_name                               OK

mysql.time_zone_transition                         OK

mysql.time_zone_transition_type                    OK

mysql.transaction_registry                         OK

mysql.user                                         OK

Phase 2/7: Installing used storage engines... Skipped

Phase 3/7: Fixing views

Phase 4/7: Running 'mysql_fix_privilege_tables'

Phase 5/7: Fixing table and database names

Phase 6/7: Checking and upgrading tables

Processing databases

information_schema

performance_schema

test

test_1

test_1.t                                           OK

Phase 7/7: Running 'FLUSH PRIVILEGES'

OK

Warning:    8 bytes lost at 0x7fb713508af0, allocated by T@0 at 0x7fb712b05b14, mysys/my_malloc.c:246, mysys/get_password.c:204, 0x7fb7111c1555, 0x7fb712ae3889

Memory lost: 8 bytes in 1 chunks

This problem maybe caused by a bug in mysql_upgrade.c line 1348 where malloc memory
in get_tty_password() without free it.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

build.sh
4 kB
2022-12-07 05:09

Activity

Ascending order - Click to sort in descending order

Linkang, Zhang created issue - 2022-12-07 05:11

Linkang, Zhang made changes - 2022-12-07 06:01

Field	Original Value	New Value
Summary	When we upgrade the mariadb from 10.3.13 to 10.3.36, we found some memory leak in mysql_upgrade.	When we upgrade the mariadb from 10.3.13 to 10.3.36, we found memory leak in mysql_upgrade.

Linkang, Zhang made changes - 2022-12-07 06:02

Description

When we upgrade the mariadb from 10.3.13 to 10.3.36, we found some memory leak in mysql_upgrade.
We can reproduce this bug in the following way:

1. download the code of mariadb-10.3.13, and create a file to compile this code. I put this compilation file in the attachment. Then we create a mysqld instance by this way:

{code:java}
// Run the build.sh file and specify the basedir
$ sh build.sh -d /flash3/mariadb_data/mysql

// Install dependencies
$ make install

// initialization
$ /flash3/mariadb_10_3_13/scripts/mysql_install_db --basedir='/flash3/mariadb_data/mysql' --datadir='/flash3/mariadb_data/data'

// Create an instance using port 1235
$ /flash3/mariadb_10_3_13/sql/mysqld --basedir=/flash3/mariadb_data/mysql --datadir=/flash3/mariadb_data/data --port=1235 --socket=/flash3/mariadb_data/mysql/mysql.sock&

// Connect into a mysqld instance by root
$ mysql -h127.0.0.1 -P1234 -uroot
{code}

2. Create some tables on the Mariadb-10.3.13 instance

{code:java}
MariaDB> create database test_1;
MariaDB> use test_1;
MariaDB> create table t(a int);
MariaDB> insert into t values(1),(2);
MariaDB> shutdown;
{code}

3. Compile the code of mariadb-10.3.36 and create an instance in the same data directory with mariadb-10.3.13.

{code:java}
// Compile the code of mariadb-10.3.36 by using the build.sh file.
$ sh build.sh

//Create an instance in the same directory with mariadb-10.3.13. And use the port 1246.
$ flash3/mariadb_10_3_36/sql/mysqld --basedir=/flash3/mariadb_data/mysql --datadir=/flash3/mariadb_data/data --port=1246 --socket=/flash3/mariadb_data/mysql/mysql.sock&

{code}

4. Run the mysql_upgrade of mariadb-10.3.36
{code:java}
$ /flash3/mariadb_10_3_36/client/mysql_upgrade -uroot -p -S /flash3/mariadb_data/mysql/mysql.sock
{code}

Now the warning appears：

{code:java}
Phase 1/7: Checking and upgrading mysql database
Processing databases
mysql
mysql.column_stats OK
mysql.columns_priv OK
mysql.db OK
mysql.event OK
mysql.func OK
mysql.gtid_slave_pos OK
mysql.help_category OK
mysql.help_keyword OK
mysql.help_relation OK
mysql.help_topic OK
mysql.host OK
mysql.index_stats OK
mysql.innodb_index_stats OK
mysql.innodb_table_stats OK
mysql.plugin OK
mysql.proc OK
mysql.procs_priv OK
mysql.proxies_priv OK
mysql.roles_mapping OK
mysql.servers OK
mysql.table_stats OK
mysql.tables_priv OK
mysql.time_zone OK
mysql.time_zone_leap_second OK
mysql.time_zone_name OK
mysql.time_zone_transition OK
mysql.time_zone_transition_type OK
mysql.transaction_registry OK
mysql.user OK
Phase 2/7: Installing used storage engines... Skipped
Phase 3/7: Fixing views
Phase 4/7: Running 'mysql_fix_privilege_tables'
Phase 5/7: Fixing table and database names
Phase 6/7: Checking and upgrading tables
Processing databases
information_schema
performance_schema
test
test_1
test_1.t OK
Phase 7/7: Running 'FLUSH PRIVILEGES'
OK
Warning: 8 bytes lost at 0x7fb713508af0, allocated by T@0 at 0x7fb712b05b14, mysys/my_malloc.c:246, mysys/get_password.c:204, 0x7fb7111c1555, 0x7fb712ae3889
Memory lost: 8 bytes in 1 chunks
{code}

This problem maybe caused by a bug in mysql_upgrade.c line 1348 where malloc memory
in get_tty_password() without free it.

When we upgrade the mariadb from 10.3.13 to 10.3.36, we found some memory leak in mysql_upgrade.
We can reproduce this bug in the following way:

1. download the code of mariadb-10.3.13, and create a file to compile this code. I put this compilation file in the attachment. Then we create a mysqld instance by this way:

{code:java}
// Run the build.sh file and specify the basedir
$ sh build.sh -d /flash3/mariadb_data/mysql

// Install dependencies
$ make install

// initialization
$ /flash3/mariadb_10_3_13/scripts/mysql_install_db --basedir='/flash3/mariadb_data/mysql' --datadir='/flash3/mariadb_data/data'

// Create an instance using port 1235
$ /flash3/mariadb_10_3_13/sql/mysqld --basedir=/flash3/mariadb_data/mysql --datadir=/flash3/mariadb_data/data --port=1235 --socket=/flash3/mariadb_data/mysql/mysql.sock&

// Connect into a mysqld instance by root
$ mysql -h127.0.0.1 -P1234 -uroot
{code}

2. Create some tables on the Mariadb-10.3.13 instance

{code:java}
MariaDB> create database test_1;
MariaDB> use test_1;
MariaDB> create table t(a int);
MariaDB> insert into t values(1),(2);
MariaDB> shutdown;
{code}

3. Compile the code of mariadb-10.3.36 and create an instance in the same data directory with mariadb-10.3.13.

{code:java}
// Compile the code of mariadb-10.3.36 by using the build.sh file.
$ sh build.sh

// Create an instance in the same directory with mariadb-10.3.13. And use the port 1246.
$ flash3/mariadb_10_3_36/sql/mysqld --basedir=/flash3/mariadb_data/mysql --datadir=/flash3/mariadb_data/data --port=1246 --socket=/flash3/mariadb_data/mysql/mysql.sock&

{code}

4. Run the mysql_upgrade of mariadb-10.3.36
{code:java}
$ /flash3/mariadb_10_3_36/client/mysql_upgrade -uroot -p -S /flash3/mariadb_data/mysql/mysql.sock
{code}

Now the warning appears：

{code:java}
Phase 1/7: Checking and upgrading mysql database
Processing databases
mysql
mysql.column_stats OK
mysql.columns_priv OK
mysql.db OK
mysql.event OK
mysql.func OK
mysql.gtid_slave_pos OK
mysql.help_category OK
mysql.help_keyword OK
mysql.help_relation OK
mysql.help_topic OK
mysql.host OK
mysql.index_stats OK
mysql.innodb_index_stats OK
mysql.innodb_table_stats OK
mysql.plugin OK
mysql.proc OK
mysql.procs_priv OK
mysql.proxies_priv OK
mysql.roles_mapping OK
mysql.servers OK
mysql.table_stats OK
mysql.tables_priv OK
mysql.time_zone OK
mysql.time_zone_leap_second OK
mysql.time_zone_name OK
mysql.time_zone_transition OK
mysql.time_zone_transition_type OK
mysql.transaction_registry OK
mysql.user OK
Phase 2/7: Installing used storage engines... Skipped
Phase 3/7: Fixing views
Phase 4/7: Running 'mysql_fix_privilege_tables'
Phase 5/7: Fixing table and database names
Phase 6/7: Checking and upgrading tables
Processing databases
information_schema
performance_schema
test
test_1
test_1.t OK
Phase 7/7: Running 'FLUSH PRIVILEGES'
OK
Warning: 8 bytes lost at 0x7fb713508af0, allocated by T@0 at 0x7fb712b05b14, mysys/my_malloc.c:246, mysys/get_password.c:204, 0x7fb7111c1555, 0x7fb712ae3889
Memory lost: 8 bytes in 1 chunks
{code}

This problem maybe caused by a bug in mysql_upgrade.c line 1348 where malloc memory
in get_tty_password() without free it.

Sergei Golubchik made changes - 2022-12-26 14:20

Priority

Major [ 3 ]

Minor [ 4 ]

Sergei Golubchik made changes - 2022-12-26 14:20

Labels

10.3.36 mariadb upgrade

beginner-friendly

Sergei Golubchik made changes - 2022-12-26 14:20

Component/s		Scripts & Clients [ 11002 ]
Component/s	Upgrades [ 15807 ]

Yingquan He added a comment - 2023-04-09 14:14

I would like to work on this.

Yingquan He added a comment - 2023-04-09 14:14 I would like to work on this.

Linkang, Zhang made changes - 2023-04-10 01:26

Labels

beginner-friendly

beginner-friendly upgrade

Linkang, Zhang made changes - 2023-04-10 01:27

Component/s		Upgrades [ 15807 ]
Component/s	Scripts & Clients [ 11002 ]

Linkang, Zhang made changes - 2023-05-30 02:40

Priority

Minor [ 4 ]

Critical [ 2 ]

Linkang, Zhang added a comment - 2023-06-05 01:33

ARE YOU SURE ？
CAN YOU DO IT AGAIN ？

Linkang, Zhang added a comment - 2023-06-05 01:33 ARE YOU SURE ？ CAN YOU DO IT AGAIN ？

Linkang, Zhang made changes - 2023-06-05 01:34

Environment

Linux version 3.10.0-327.ali2017.alios7.x86_64 (admin@5d4c4cbc722c) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC) ) #1 SMP Fri May 11 23:17:54 CST 2018

Linux

Sergei Golubchik made changes - 2023-06-05 16:30

Priority

Critical [ 2 ]

Minor [ 4 ]

People

Assignee:: Unassigned

Reporter:: Linkang, Zhang

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2022-12-07 05:11

Updated:: 2023-06-05 16:30

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Attachments

Activity

People

Dates

Git Integration