[MDEV-30023] Revoking Privilege on the Column Yields the Error - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Blocker
Resolution: Fixed
Affects Version/s: 10.6.11, 10.3(EOL), 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL)
Fix Version/s: 10.11.2, 10.3.38, 10.4.28, 10.5.19, 10.6.12, 10.7.8, 10.8.7, 10.9.5, 10.10.3
Component/s: Authentication and Privilege System
Labels:
- regression

Description

It's a regression in latest version 10.6.11, I did not try with other branches. But it used to work before this release.

How to repeat:

MariaDB [INFORMATION_SCHEMA]> CREATE TABLE test.test_getcolpriv(col1 INT, col2 INT);

Query OK, 0 rows affected (0.041 sec)

MariaDB [INFORMATION_SCHEMA]> GRANT SELECT (col1,col2) ON test.test_getcolpriv TO 'root';

Query OK, 0 rows affected (0.025 sec)

MariaDB [INFORMATION_SCHEMA]> GRANT INSERT (col1) ON test.test_getcolpriv TO 'root';

Query OK, 0 rows affected (0.025 sec)

MariaDB [INFORMATION_SCHEMA]> REVOKE SELECT (col1,col2) ON test.test_getcolpriv FROM 'root';

Query OK, 0 rows affected (0.025 sec)

MariaDB [INFORMATION_SCHEMA]> REVOKE INSERT (col1) ON test.test_getcolpriv FROM 'root';

ERROR 1147 (42000): There is no such grant defined for user 'root' on host '%' on table 'test_getcolpriv'

FLUSH PRIVILEGES in between fixes the thing. Also, any one GRANT/REVOKE from these two do not result in the error

Attachments

Issue Links

is caused by

MDEV-29465 Inherited columns privs for roles wrongly set mysql.tables_priv column

Closed

Activity

Ascending order - Click to sort in descending order

Lawrin Novitsky created issue - 2022-11-16 21:35

Alice Sherepa made changes - 2022-11-18 15:03

Field	Original Value	New Value
Affects Version/s		10.3 [ 22126 ]
Affects Version/s		10.4 [ 22408 ]
Affects Version/s		10.5 [ 23123 ]
Affects Version/s		10.6 [ 24028 ]
Affects Version/s		10.7 [ 24805 ]
Affects Version/s		10.8 [ 26121 ]
Affects Version/s		10.9 [ 26905 ]
Affects Version/s		10.10 [ 27530 ]

Alice Sherepa made changes - 2022-11-18 15:03

Labels

regression

Alice Sherepa made changes - 2022-11-18 15:03

Fix Version/s		10.3 [ 22126 ]
Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]
Fix Version/s		10.6 [ 24028 ]
Fix Version/s		10.7 [ 24805 ]
Fix Version/s		10.8 [ 26121 ]
Fix Version/s		10.9 [ 26905 ]

Alice Sherepa made changes - 2022-11-18 15:04

Status

Open [ 1 ]

Confirmed [ 10101 ]

Alice Sherepa made changes - 2022-11-18 15:07

Link

This issue is caused by ~~MDEV-29465~~ [ ~~MDEV-29465~~ ]

Alice Sherepa made changes - 2022-11-18 15:07

Assignee

Vicențiu Ciorbaru [ cvicentiu ]

Alice Sherepa added a comment - 2022-11-18 15:08

caused by 145932a57b3ffba4ebab25aa5 (~~MDEV-29465~~: Inherited columns privs for roles wrongly set mysql.table…)

Alice Sherepa added a comment - 2022-11-18 15:08 caused by 145932a57b3ffba4ebab25aa5 ( MDEV-29465 : Inherited columns privs for roles wrongly set mysql.table…)

Sergei Golubchik made changes - 2022-11-23 15:06

Priority

Minor [ 4 ]

Blocker [ 1 ]

Sergei Golubchik made changes - 2022-11-23 15:07

Link

This issue relates to MENT-1670 [ MENT-1670 ]

Vicențiu Ciorbaru made changes - 2022-11-24 17:48

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Vicențiu Ciorbaru made changes - 2022-11-24 18:52

Description

It's a regression in latest version 5.6.11, I did not try with other branches. But it used to work before this release.

How to repeat:

{code:java}
MariaDB [INFORMATION_SCHEMA]> CREATE TABLE test.test_getcolpriv(col1 INT, col2 INT);
Query OK, 0 rows affected (0.041 sec)
MariaDB [INFORMATION_SCHEMA]> GRANT SELECT (col1,col2) ON test.test_getcolpriv TO 'root';
Query OK, 0 rows affected (0.025 sec)
MariaDB [INFORMATION_SCHEMA]> GRANT INSERT (col1) ON test.test_getcolpriv TO 'root';
Query OK, 0 rows affected (0.025 sec)

MariaDB [INFORMATION_SCHEMA]> REVOKE SELECT (col1,col2) ON test.test_getcolpriv FROM 'root';
Query OK, 0 rows affected (0.025 sec)
MariaDB [INFORMATION_SCHEMA]> REVOKE INSERT (col1) ON test.test_getcolpriv FROM 'root';
ERROR 1147 (42000): There is no such grant defined for user 'root' on host '%' on table 'test_getcolpriv'
{code}

FLUSH PRIVILEGES in between fixes the thing. Also, any one GRANT/REVOKE from these two do not result in the error

It's a regression in latest version 10.6.11, I did not try with other branches. But it used to work before this release.

How to repeat:

{code:java}
MariaDB [INFORMATION_SCHEMA]> CREATE TABLE test.test_getcolpriv(col1 INT, col2 INT);
Query OK, 0 rows affected (0.041 sec)
MariaDB [INFORMATION_SCHEMA]> GRANT SELECT (col1,col2) ON test.test_getcolpriv TO 'root';
Query OK, 0 rows affected (0.025 sec)
MariaDB [INFORMATION_SCHEMA]> GRANT INSERT (col1) ON test.test_getcolpriv TO 'root';
Query OK, 0 rows affected (0.025 sec)

MariaDB [INFORMATION_SCHEMA]> REVOKE SELECT (col1,col2) ON test.test_getcolpriv FROM 'root';
Query OK, 0 rows affected (0.025 sec)
MariaDB [INFORMATION_SCHEMA]> REVOKE INSERT (col1) ON test.test_getcolpriv FROM 'root';
ERROR 1147 (42000): There is no such grant defined for user 'root' on host '%' on table 'test_getcolpriv'
{code}

FLUSH PRIVILEGES in between fixes the thing. Also, any one GRANT/REVOKE from these two do not result in the error

Vicențiu Ciorbaru added a comment - 2022-11-25 09:21 - edited

Hi serg

Can you please review the patch at https://github.com/MariaDB/server/commit/6ed475f25cc20e88c66f52e13e691a2d8b0615e4

All tests pass. The issue was caused by an incomplete update of GRANT_COLUMNS::rights vs GRANT_COLUMN::init_rights in replace_column_table.

Vicențiu Ciorbaru added a comment - 2022-11-25 09:21 - edited Hi serg Can you please review the patch at https://github.com/MariaDB/server/commit/6ed475f25cc20e88c66f52e13e691a2d8b0615e4 All tests pass. The issue was caused by an incomplete update of GRANT_COLUMNS::rights vs GRANT_COLUMN::init_rights in replace_column_table.

Vicențiu Ciorbaru made changes - 2022-11-25 09:21

Assignee	Vicențiu Ciorbaru [ cvicentiu ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Sergei Golubchik added a comment - 2022-11-29 21:41

6ed475f25cc2 is ok to push

Sergei Golubchik added a comment - 2022-11-29 21:41 6ed475f25cc2 is ok to push

Sergei Golubchik made changes - 2022-11-29 21:41

Assignee	Sergei Golubchik [ serg ]	Vicențiu Ciorbaru [ cvicentiu ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Vicențiu Ciorbaru made changes - 2022-11-30 20:55

Fix Version/s		10.3.38 [ 28507 ]
Fix Version/s		10.4.28 [ 28509 ]
Fix Version/s		10.5.19 [ 28511 ]
Fix Version/s		10.6.12 [ 28513 ]
Fix Version/s		10.7.8 [ 28515 ]
Fix Version/s		10.8.7 [ 28517 ]
Fix Version/s		10.9.5 [ 28519 ]
Fix Version/s		10.10.3 [ 28521 ]
Fix Version/s		10.11.2 [ 28523 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Fix Version/s	10.7 [ 24805 ]
Fix Version/s	10.8 [ 26121 ]
Fix Version/s	10.9 [ 26905 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

People

Assignee:: Vicențiu Ciorbaru

Reporter:: Lawrin Novitsky

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2022-11-16 21:35

Updated:: 2022-11-30 20:54

Resolved:: 2022-11-30 20:54

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration