Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29987

Bogus errors about file size in the test mariabackup.defer_space

Details

    Description

      Some warnings were reported in a Microsoft Windows environment (also on retry):

      10.8 fe9412dbc9ce4cb1764a3669ee89dcf687d68fb5

      		 
      mariabackup.defer_space 'innodb'         w21 [ fail ]  Found warnings/errors in server log file!
      		 
              Test ended at 2022-11-09 12:12:56
      		 
      line
      		 
      2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
      		 
      2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
      		 
      ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/21/log/mysqld.1.err
      		 
       
      		 
      innodb.corrupted_during_recovery 'innodb' w27 [ fail ]  Found warnings/errors in server log file!
      		 
              Test ended at 2022-11-09 12:25:07
      		 
      line
      		 
      2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
      		 
      2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
      		 
      ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/27/log/mysqld.1.err

      Note: The file size is 1 smaller than the expected minimum file size.

      On the third attempt, both these tests passed.

      To me, it looks like the error messages are superfluous and should be removed. The recovery of a newly created file is supposed to work (and it apparently did work also in this case) no matter what the contents of the file is.

      The message could be duplicated due to redundant calls (MDEV-25909).

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24626 Remove synchronous write of page0 and flushing file during file creation

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25909 Unnecessary calls to fil_ibd_load() slow down recovery

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Description Some warnings were reported in [a Microsoft Windows environment|https://buildbot.mariadb.org/#/builders/234/builds/13312]:
            {noformat:10.8 fe9412dbc9ce4cb1764a3669ee89dcf687d68fb5}
            mariabackup.defer_space 'innodb' w21 [ fail ] Found warnings/errors in server log file!
                    Test ended at 2022-11-09 12:12:56
            line
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/21/log/mysqld.1.err
            {noformat}
            Note: The file size was 1 smaller than the expected minimum file size.

            To me, it looks like the error messages are superfluous and should be removed. The recovery of a newly created file is supposed to work (and it apparently did work also in this case) no matter what the contents of the file is.

            The message could be duplicated due to redundant calls (MDEV-25909).             		Some warnings were reported in [a Microsoft Windows environment|https://buildbot.mariadb.org/#/builders/234/builds/13312] (also [on retry|https://buildbot.mariadb.org/#/builders/234/builds/13314]:
            {noformat:title=10.8 fe9412dbc9ce4cb1764a3669ee89dcf687d68fb5}
            mariabackup.defer_space 'innodb' w21 [ fail ] Found warnings/errors in server log file!
                    Test ended at 2022-11-09 12:12:56
            line
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/21/log/mysqld.1.err

            innodb.corrupted_during_recovery 'innodb' w27 [ fail ] Found warnings/errors in server log file!
                    Test ended at 2022-11-09 12:25:07
            line
            2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/27/log/mysqld.1.err
            {noformat}
            Note: The file size is 1 smaller than the expected minimum file size.

            On the third attempt, both these tests passed.

            To me, it looks like the error messages are superfluous and should be removed. The recovery of a newly created file is supposed to work (and it apparently did work also in this case) no matter what the contents of the file is.

            The message could be duplicated due to redundant calls (MDEV-25909).
            marko Marko Mäkelä made changes -
            Description Some warnings were reported in [a Microsoft Windows environment|https://buildbot.mariadb.org/#/builders/234/builds/13312] (also [on retry|https://buildbot.mariadb.org/#/builders/234/builds/13314]:
            {noformat:title=10.8 fe9412dbc9ce4cb1764a3669ee89dcf687d68fb5}
            mariabackup.defer_space 'innodb' w21 [ fail ] Found warnings/errors in server log file!
                    Test ended at 2022-11-09 12:12:56
            line
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/21/log/mysqld.1.err

            innodb.corrupted_during_recovery 'innodb' w27 [ fail ] Found warnings/errors in server log file!
                    Test ended at 2022-11-09 12:25:07
            line
            2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/27/log/mysqld.1.err
            {noformat}
            Note: The file size is 1 smaller than the expected minimum file size.

            On the third attempt, both these tests passed.

            To me, it looks like the error messages are superfluous and should be removed. The recovery of a newly created file is supposed to work (and it apparently did work also in this case) no matter what the contents of the file is.

            The message could be duplicated due to redundant calls (MDEV-25909).             		Some warnings were reported in [a Microsoft Windows environment|https://buildbot.mariadb.org/#/builders/234/builds/13312] (also [on retry|https://buildbot.mariadb.org/#/builders/234/builds/13314]):
            {noformat:title=10.8 fe9412dbc9ce4cb1764a3669ee89dcf687d68fb5}
            mariabackup.defer_space 'innodb' w21 [ fail ] Found warnings/errors in server log file!
                    Test ended at 2022-11-09 12:12:56
            line
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            2022-11-09 12:12:54 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/21/log/mysqld.1.err

            innodb.corrupted_during_recovery 'innodb' w27 [ fail ] Found warnings/errors in server log file!
                    Test ended at 2022-11-09 12:25:07
            line
            2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            2022-11-09 12:24:55 0 [ERROR] InnoDB: The size of the file ./test/t1.ibd is only 65535 bytes, should be at least 65536
            ^ Found warnings in D:/Buildbot/amd64-windows/build/mysql-test/var/27/log/mysqld.1.err
            {noformat}
            Note: The file size is 1 smaller than the expected minimum file size.

            On the [third attempt|https://buildbot.mariadb.org/#/builders/234/builds/13315], both these tests passed.

            To me, it looks like the error messages are superfluous and should be removed. The recovery of a newly created file is supposed to work (and it apparently did work also in this case) no matter what the contents of the file is.

            The message could be duplicated due to redundant calls (MDEV-25909).
            marko Marko Mäkelä added a comment -

            The problem was that for some reason, some Perl code in the test that was supposed to overwrite the first page of t1.ibd with NUL bytes was also truncating the last page by 1 byte on Microsoft Windows. Fixed by using slightly different Perl code to corrupt only the desired part of the file.

            marko Marko Mäkelä added a comment - The problem was that for some reason, some Perl code in the test that was supposed to overwrite the first page of t1.ibd with NUL bytes was also truncating the last page by 1 byte on Microsoft Windows. Fixed by using slightly different Perl code to corrupt only the desired part of the file.
            marko Marko Mäkelä made changes -
            Component/s Tests [ 10800 ]
            Component/s Backup [ 13902 ]
            Component/s Storage Engine - InnoDB [ 10129 ]
            Fix Version/s 10.6.12 [ 28513 ]
            Fix Version/s 10.7.8 [ 28515 ]
            Fix Version/s 10.8.7 [ 28517 ]
            Fix Version/s 10.9.5 [ 28519 ]
            Fix Version/s 10.10.4 [ 28522 ]
            Fix Version/s 10.11.2 [ 28523 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]
            Fix Version/s 10.11 [ 27614 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            Fix Version/s 10.10.3 [ 28521 ]
            Fix Version/s 10.10.4 [ 28522 ]

            People

              thiru Thirunarayanan Balathandayuthapani
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.