Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29839

Galera build.sh returns 0 even if packages building failed

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 10.4(EOL)
    • 10.4(EOL)
    • Galera
    • None

    Description

      Initially it was mentioned at the commit 6116fa77e5943428284e5eb3d4f4911bd905638c - this version had a broken Debian packaging, but it can be reproduced by breaking e.g. debian/changelog file:

      --- a/debian/changelog
      +++ b/debian/changelog
      @@ -1,4 +1,4 @@
      -galera-4 (26.4.13) UNRELEASED; urgency=medium
      +galera-eneterprise-4 (26.4.13) UNRELEASED; urgency=medium
      
      

      Try to build broken version:

      timofey_turenko_mariadb_com@mdbci-z16k1jmq-1666288834-build:~/galera$ ./scripts/build.sh -p 
      ~/galera ~/galera
      ~/galera
      Reset env for Debian package build
      dch warning: Previous package version was Debian native whilst new version is not
      dpkg-buildpackage: info: source package galera-eneterprise-4
      dpkg-buildpackage: info: source version 26.4.13-bullseye
      dpkg-buildpackage: info: source distribution bullseye
      dpkg-buildpackage: info: source changed by Codership Oy <info@codership.com>
      dpkg-buildpackage: info: host architecture amd64
       dpkg-source --before-build .
      dpkg-source: error: source package has two conflicting values - galera-4 and galera-eneterprise-4
      dpkg-buildpackage: error: dpkg-source --before-build . subprocess returned exit status 255
      timofey_turenko_mariadb_com@mdbci-z16k1jmq-1666288834-build:~/galera$ echo $?
      0
      
      

      Probably the reason is here https://github.com/MariaDB/galera/blob/mariadb-4.x/scripts/build.sh#L343 - does $? return result of the line https://github.com/MariaDB/galera/blob/mariadb-4.x/scripts/build.sh#L331, not https://github.com/MariaDB/galera/blob/mariadb-4.x/scripts/build.sh#L330 ?

      Attachments

        Activity

          People

            sysprg Julius Goryavsky
            tturenko Timofey Turenko
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.