[MDEV-29744] safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables', or of mutex 'LOCK_global_system_variables' and 'LOCK_log', on setting max_binlog_size or binlog_checksum and START TRANSACTION - Jira

Roel Van de Paar created issue - 2022-10-08 06:06

Roel Van de Paar made changes - 2022-10-08 06:06

Field	Original Value	New Value
Labels		mutex

Roel Van de Paar made changes - 2022-10-08 06:07

Description

{code:sql}
# mysqld options required for replay: --log-bin
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
START TRANSACTION WITH CONSISTENT SNAPSHOT;
{code}

Leads to:

{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables'
{noformat}

Bug confirmed present in:

Bug (or feature/syntax) confirmed not present in:
MariaDB: 10.3.37 (dbg), 10.3.37 (opt), 10.4.27 (dbg), 10.4.27 (opt), 10.5.18 (dbg), 10.5.18 (opt), 10.6.10 (dbg), 10.6.10 (opt), 10.7.6 (dbg), 10.7.6 (opt), 10.8.5 (dbg), 10.8.5 (opt), 10.9.3 (dbg), 10.9.3 (opt), 10.10.2 (dbg), 10.10.2 (opt), 10.11.0 (dbg), 10.11.0 (opt)
MySQL: 5.5.62 (dbg), 5.5.62 (opt), 5.6.51 (dbg), 5.6.51 (opt), 5.7.38 (dbg), 5.7.38 (opt), 8.0.29 (dbg), 8.0.29 (opt)

{code:sql}
# mysqld options required for replay: --log-bin
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
START TRANSACTION WITH CONSISTENT SNAPSHOT;
{code}

Leads to:

{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables'
{noformat}

Bug confirmed present in:
MariaDB: 10.3.37 (dbg), 10.4.27 (dbg), 10.5.18 (dbg), 10.6.10 (dbg), 10.7.6 (dbg), 10.8.5 (dbg), 10.9.3 (dbg), 10.10.2 (dbg), 10.11.0 (dbg)

Bug (or feature/syntax) confirmed not present in:
MariaDB: 10.3.37 (opt), 10.4.27 (opt), 10.5.18 (opt), 10.6.10 (opt), 10.7.6 (opt), 10.8.5 (opt), 10.9.3 (opt), 10.10.2 (opt), 10.11.0 (opt)

Roel Van de Paar made changes - 2022-10-08 06:09

Summary

safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables' on START TRANSACTION

safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables', or of mutex 'LOCK_global_system_variables' and 'LOCK_log', on setting max_binlog_size and START TRANSACTION

Roel Van de Paar made changes - 2022-10-08 06:10

Description

{code:sql}
# mysqld options required for replay: --log-bin
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
START TRANSACTION WITH CONSISTENT SNAPSHOT;
{code}

Leads to:

{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables'
{noformat}

Bug confirmed present in:
MariaDB: 10.3.37 (dbg), 10.4.27 (dbg), 10.5.18 (dbg), 10.6.10 (dbg), 10.7.6 (dbg), 10.8.5 (dbg), 10.9.3 (dbg), 10.10.2 (dbg), 10.11.0 (dbg)

Bug (or feature/syntax) confirmed not present in:
MariaDB: 10.3.37 (opt), 10.4.27 (opt), 10.5.18 (opt), 10.6.10 (opt), 10.7.6 (opt), 10.8.5 (opt), 10.9.3 (opt), 10.10.2 (opt), 10.11.0 (opt)

{code:sql}
# mysqld options required for replay: --log-bin
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
START TRANSACTION WITH CONSISTENT SNAPSHOT;
{code}

Leads to:

{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables'
{noformat}

And

{code:sql}
# mysqld options required for replay: --log-bin
START TRANSACTION WITH CONSISTENT SNAPSHOT;
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
{code}

Leads to:
{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_global_system_variables' and 'LOCK_log'
{noformat}

Bug confirmed present in:
MariaDB: 10.3.37 (dbg), 10.4.27 (dbg), 10.5.18 (dbg), 10.6.10 (dbg), 10.7.6 (dbg), 10.8.5 (dbg), 10.9.3 (dbg), 10.10.2 (dbg), 10.11.0 (dbg)

Bug (or feature/syntax) confirmed not present in:
MariaDB: 10.3.37 (opt), 10.4.27 (opt), 10.5.18 (opt), 10.6.10 (opt), 10.7.6 (opt), 10.8.5 (opt), 10.9.3 (opt), 10.10.2 (opt), 10.11.0 (opt)

Roel Van de Paar made changes - 2022-10-08 06:10

Description

{code:sql}
# mysqld options required for replay: --log-bin
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
START TRANSACTION WITH CONSISTENT SNAPSHOT;
{code}

Leads to:

{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables'
{noformat}

And

{code:sql}
# mysqld options required for replay: --log-bin
START TRANSACTION WITH CONSISTENT SNAPSHOT;
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
{code}

Leads to:
{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_global_system_variables' and 'LOCK_log'
{noformat}

Bug confirmed present in:
MariaDB: 10.3.37 (dbg), 10.4.27 (dbg), 10.5.18 (dbg), 10.6.10 (dbg), 10.7.6 (dbg), 10.8.5 (dbg), 10.9.3 (dbg), 10.10.2 (dbg), 10.11.0 (dbg)

Bug (or feature/syntax) confirmed not present in:
MariaDB: 10.3.37 (opt), 10.4.27 (opt), 10.5.18 (opt), 10.6.10 (opt), 10.7.6 (opt), 10.8.5 (opt), 10.9.3 (opt), 10.10.2 (opt), 10.11.0 (opt)

{code:sql}
# mysqld options required for replay: --log-bin
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
START TRANSACTION WITH CONSISTENT SNAPSHOT;
{code}

Leads to:

{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables'
{noformat}

And

{code:sql}
# mysqld options required for replay: --log-bin
START TRANSACTION WITH CONSISTENT SNAPSHOT;
SET GLOBAL max_binlog_size=98304; # A valid and arbritary setting
{code}

Leads to:
{noformat:title=10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)}
safe_mutex: Found wrong usage of mutex 'LOCK_global_system_variables' and 'LOCK_log'
{noformat}

Bug confirmed present in:
MariaDB: 10.3.37 (dbg), 10.4.27 (dbg), 10.5.18 (dbg), 10.6.10 (dbg), 10.7.6 (dbg), 10.8.5 (dbg), 10.9.3 (dbg), 10.10.2 (dbg), 10.11.0 (dbg)

Elena Stepanova added a comment - 2022-10-14 16:52

Also with binlog_checksum, as in

--source include/have_innodb.inc

--source include/have_log_bin.inc

SET GLOBAL binlog_checksum= CRC32;

START TRANSACTION WITH CONSISTENT SNAPSHOT;

The problem is old though.

Elena Stepanova added a comment - 2022-10-14 16:52 Also with binlog_checksum , as in --source include/have_innodb.inc --source include/have_log_bin.inc SET GLOBAL binlog_checksum= CRC32; START TRANSACTION WITH CONSISTENT SNAPSHOT; The problem is old though.

Roel Van de Paar added a comment - 2022-10-14 23:05 - edited

Was able to catch a bit more info with this testcase

# mysqld options required for replay: --log-bin

SET GLOBAL max_binlog_size=0;

START TRANSACTION WITH CONSISTENT SNAPSHOT;

10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug)
safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables'
Mutex currently locked (in reverse order):
LOCK_global_system_variables /test/10.11_dbg/sql/sql_plugin.cc line 3096
LOCK_commit_ordered /test/10.11_dbg/sql/handler.cc line 3007

Same source code line numbers for the testcase by elenst (with thanks!)

Roel Van de Paar added a comment - 2022-10-14 23:05 - edited Was able to catch a bit more info with this testcase # mysqld options required for replay: --log-bin SET GLOBAL max_binlog_size=0; START TRANSACTION WITH CONSISTENT SNAPSHOT; 10.11.0 6ebdd3013a18b01dbecec76b870810329eb76586 (Debug) safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables' Mutex currently locked (in reverse order): LOCK_global_system_variables /test/10.11_dbg/sql/sql_plugin.cc line 3096 LOCK_commit_ordered /test/10.11_dbg/sql/handler.cc line 3007 Same source code line numbers for the testcase by elenst (with thanks!)

Roel Van de Paar made changes - 2022-10-14 23:06

Status

Open [ 1 ]

Confirmed [ 10101 ]

Julien Fritsch made changes - 2023-03-03 17:30

Fix Version/s

10.7 [ 24805 ]

Julien Fritsch made changes - 2023-04-27 13:54

Fix Version/s

10.3 [ 22126 ]

Julien Fritsch made changes - 2023-04-27 14:47

Fix Version/s

10.8 [ 26121 ]

Julien Fritsch made changes - 2023-11-28 10:34

Fix Version/s	10.9 [ 26905 ]
Fix Version/s	10.10 [ 27530 ]

Roel Van de Paar added a comment - 2023-12-07 04:10 - edited

Also please try:

# mysqld options required for replay: --log-bin

START TRANSACTION WITH CONSISTENT SNAPSHOT;

FLUSH LOGS;

SET GLOBAL binlog_checksum=NONE;

11.3.0 126157061b4376496c034a809ea4943e863d1465 (Debug)
2023-12-07 15:08:21 0 [Note] /test/MD311023-mariadb-11.3.0-linux-x86_64-dbg/bin/mariadbd: ready for connections.
Version: '11.3.0-MariaDB-debug-log' socket: '/test/MD311023-mariadb-11.3.0-linux-x86_64-dbg/socket.sock' port: 10415 MariaDB Server
2023-12-07 15:08:21 6 [Note] Start binlog_dump to slave_server(2), pos(, 4), using_gtid(1), gtid('')
safe_mutex: Found wrong usage of mutex 'LOCK_global_system_variables' and 'LOCK_log'
Mutex currently locked (in reverse order):
LOCK_log /test/11.3_dbg/sql/log.cc line 12235
LOCK_global_system_variables /test/11.3_dbg/sql/sys_vars_shared.h line 56

Roel Van de Paar added a comment - 2023-12-07 04:10 - edited Also please try: # mysqld options required for replay: --log-bin START TRANSACTION WITH CONSISTENT SNAPSHOT; FLUSH LOGS; SET GLOBAL binlog_checksum=NONE; 11.3.0 126157061b4376496c034a809ea4943e863d1465 (Debug) 2023-12-07 15:08:21 0 [Note] /test/MD311023-mariadb-11.3.0-linux-x86_64-dbg/bin/mariadbd: ready for connections. Version: '11.3.0-MariaDB-debug-log' socket: '/test/MD311023-mariadb-11.3.0-linux-x86_64-dbg/socket.sock' port: 10415 MariaDB Server 2023-12-07 15:08:21 6 [Note] Start binlog_dump to slave_server(2), pos(, 4), using_gtid(1), gtid('') safe_mutex: Found wrong usage of mutex 'LOCK_global_system_variables' and 'LOCK_log' Mutex currently locked (in reverse order): LOCK_log /test/11.3_dbg/sql/log.cc line 12235 LOCK_global_system_variables /test/11.3_dbg/sql/sys_vars_shared.h line 56

Roel Van de Paar made changes - 2023-12-07 04:11

Labels

mutex

affects-tests mutex

Roel Van de Paar made changes - 2023-12-07 04:12

Fix Version/s		10.11 [ 27614 ]
Fix Version/s		11.0 [ 28320 ]
Fix Version/s		11.1 [ 28549 ]
Affects Version/s		11.0 [ 28320 ]
Affects Version/s		11.1 [ 28549 ]
Affects Version/s		11.2 [ 28603 ]
Affects Version/s		11.3 [ 28565 ]
Affects Version/s		11.4 [ 29301 ]

Roel Van de Paar made changes - 2023-12-07 04:12

Fix Version/s		11.2 [ 28603 ]
Fix Version/s		11.3 [ 28565 ]

Roel Van de Paar added a comment - 2023-12-18 03:57 - edited

# mysqld options required for replay: --log-bin

SET GLOBAL binlog_checksum=DEFAULT;

START TRANSACTION WITH CONSISTENT SNAPSHOT,READ WRITE;

safe_mutex: Found wrong usage of mutex LOCK_commit_ordered and LOCK_global_system_variables

Roel Van de Paar added a comment - 2023-12-18 03:57 - edited # mysqld options required for replay: --log-bin SET GLOBAL binlog_checksum= DEFAULT ; START TRANSACTION WITH CONSISTENT SNAPSHOT, READ WRITE; safe_mutex: Found wrong usage of mutex LOCK_commit_ordered and LOCK_global_system_variables

Roel Van de Paar added a comment - 2023-12-18 04:00

Elkin Hi! Would you have a moment to check how serious this issue is under the hood? Thank you

Roel Van de Paar added a comment - 2023-12-18 04:00 Elkin Hi! Would you have a moment to check how serious this issue is under the hood? Thank you

Julien Fritsch made changes - 2024-05-03 14:31

Fix Version/s	11.0 [ 28320 ]
Fix Version/s	11.3 [ 28565 ]

Julien Fritsch made changes - 2024-09-10 15:08

Fix Version/s

10.4 [ 22408 ]

Julien Fritsch made changes - 2024-09-10 15:27

Fix Version/s

11.1 [ 28549 ]

Roel Van de Paar made changes - 2024-10-17 21:52

Affects Version/s

11.7 [ 29815 ]

Roel Van de Paar made changes - 2024-10-17 22:01

Comment

[ {code:sql}
# mysqld options required for replay: --log_bin
SET GLOBAL binlog_checksum=0;
INSTALL SONAME 'ha_spider';
RESET MASTER;
{code}
Leads to:
{noformat:title=CS 11.7.0 4016c905cbabea7f29ed282dc2125254c7c0d419 (Debug)}
Version: '11.7.0-MariaDB-debug-log' socket: '/test/MD141024-mariadb-11.7.0-linux-x86_64-dbg/socket.sock' port: 12847 MariaDB Server
safe_mutex: Found wrong usage of mutex 'LOCK_log' and 'LOCK_global_system_variables'
Mutex currently locked (in reverse order):
LOCK_global_system_variables /test/11.7_dbg/sql/sql_plugin.cc line 3132
LOCK_log /test/11.7_dbg/sql/log.cc line 4449
{noformat}
MTR Testcase:
{code:sql}
--source include/have_log_bin.inc
SET GLOBAL binlog_checksum=0;
INSTALL SONAME 'ha_spider';
RESET MASTER;
{code}
Note the different testcase and reversed wrong mutex usage detection order. ]

Roel Van de Paar made changes - 2024-10-17 22:02

Link

This issue relates to ~~MDEV-35197~~ [ ~~MDEV-35197~~ ]

Roel Van de Paar made changes - 2024-10-17 22:11

Affects Version/s

11.6 [ 29515 ]

Roel Van de Paar made changes - 2024-10-17 22:11

Fix Version/s		11.4 [ 29301 ]
Fix Version/s		11.6 [ 29515 ]

Roel Van de Paar made changes - 2024-10-17 23:24

Summary

safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables', or of mutex 'LOCK_global_system_variables' and 'LOCK_log', on setting max_binlog_size and START TRANSACTION

safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables', or of mutex 'LOCK_global_system_variables' and 'LOCK_log', on setting max_binlog_size or binlog_checksum and START TRANSACTION

Kristian Nielsen made changes - 2024-10-22 08:40

Assignee

Andrei Elkin [ elkin ]

Kristian Nielsen [ knielsen ]

Kristian Nielsen made changes - 2024-10-22 08:40

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Kristian Nielsen made changes - 2024-10-22 08:40

Link

This issue is duplicated by ~~MDEV-35197~~ [ ~~MDEV-35197~~ ]

Kristian Nielsen added a comment - 2024-10-22 09:41

The same problem will probably also occur for max_binlog_total_size, which is available since 11.4.

Kristian Nielsen added a comment - 2024-10-22 09:41 The same problem will probably also occur for max_binlog_total_size, which is available since 11.4.

Elena Stepanova added a comment - 2024-10-22 09:53 - edited

Sure. It would be recognized as a known bug (this one) and ignored in tests.

Elena Stepanova added a comment - 2024-10-22 09:53 - edited Sure. It would be recognized as a known bug (this one) and ignored in tests.

Kristian Nielsen made changes - 2024-10-22 12:52

Assignee	Kristian Nielsen [ knielsen ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Roel Van de Paar added a comment - 2024-10-24 00:50

knielsen Hi! Thank you for working on this. I see you put this in review but I cannot see an attached patch?

Roel Van de Paar added a comment - 2024-10-24 00:50 knielsen Hi! Thank you for working on this. I see you put this in review but I cannot see an attached patch?

Kristian Nielsen added a comment - 2024-10-24 07:36

The patch is in branch bb-10.6-knielsen

Kristian Nielsen added a comment - 2024-10-24 07:36 The patch is in branch bb-10.6-knielsen

Julien Fritsch made changes - 2024-11-22 14:56

Fix Version/s

11.6(EOL) [ 29515 ]

Julien Fritsch made changes - 2024-11-22 17:06

Fix Version/s

11.2(EOL) [ 28603 ]

Kristian Nielsen added a comment - 2024-11-25 16:47

sergLet me know if you're going to review this week, otherwise I'll just take it back and push it with your suggestion to use mysql_mutex_record_order()

Kristian Nielsen added a comment - 2024-11-25 16:47 serg Let me know if you're going to review this week, otherwise I'll just take it back and push it with your suggestion to use mysql_mutex_record_order()

Sergei Golubchik added a comment - 2024-11-26 10:09

I was going to review it in about 2-3 weeks (note that the release is planned for the end of Jan)

Sergei Golubchik added a comment - 2024-11-26 10:09 I was going to review it in about 2-3 weeks (note that the release is planned for the end of Jan)

Sergei Golubchik made changes - 2025-01-08 15:45

Assignee	Sergei Golubchik [ serg ]	Kristian Nielsen [ knielsen ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Kristian Nielsen made changes - 2025-01-08 16:29

Fix Version/s

10.5 [ 23123 ]

Kristian Nielsen added a comment - 2025-01-09 09:50

Pushed to 10.6.
Requires another patch when merged to 11.4, see here: https://lists.mariadb.org/hyperkitty/list/developers@lists.mariadb.org/thread/LN35WETUEUHYUQNZXAKXLVU5EGSCQSVX/

Kristian Nielsen added a comment - 2025-01-09 09:50 Pushed to 10.6. Requires another patch when merged to 11.4, see here: https://lists.mariadb.org/hyperkitty/list/developers@lists.mariadb.org/thread/LN35WETUEUHYUQNZXAKXLVU5EGSCQSVX/

Kristian Nielsen made changes - 2025-01-09 09:50

Fix Version/s		10.6.21 [ 29953 ]
Fix Version/s	10.6 [ 24028 ]
Fix Version/s	10.11 [ 27614 ]
Fix Version/s	11.4 [ 29301 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

JiraAutomate made changes - 2025-01-09 09:50

Fix Version/s		10.11.11 [ 29954 ]
Fix Version/s		11.4.5 [ 29956 ]
Fix Version/s		11.7.2 [ 29914 ]

MariaDB Server

safe_mutex: Found wrong usage of mutex 'LOCK_commit_ordered' and 'LOCK_global_system_variables', or of mutex 'LOCK_global_system_variables' and 'LOCK_log', on setting max_binlog_size or binlog_checksum and START TRANSACTION

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration