Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28568 Spider: Push down more functions to improve performance
  3. MDEV-28993

Spider: Push down CASE statement

Details

    Description

      To push down the CASE statement, enable Spider code disabled by #ifdef ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC. Some modifications to Spider and the server may be needed.

      Attachments

        Issue Links

          blocks

          Technical task - A technical task. MDEV-28873 Spider: remove #ifdef ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          includes

          Technical task - A technical task. MDEV-28873 Spider: remove #ifdef ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            ycp Yuchen Pei added a comment -

            Hi holyfoot, ptal thanks

            34c67945c7d upstream/bb-10.4-mdev-28993 upstream/bb-10.4-ycp MDEV-28993 Spider: Push down CASE statement
            		 
            179941fbae0 MDEV-28993 spider: revert removal of ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC

            Like MDEV-28992, this change merely enables some code with minor corrections, so I propose to apply it to 10.4.

            Did not touch spd_db_oracle or spd_db_handlersocket because both are deprecated and removed in newer versions.

            ycp Yuchen Pei added a comment - Hi holyfoot , ptal thanks 34c67945c7d upstream/bb-10.4-mdev-28993 upstream/bb-10.4-ycp MDEV-28993 Spider: Push down CASE statement 179941fbae0 MDEV-28993 spider: revert removal of ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC Like MDEV-28992 , this change merely enables some code with minor corrections, so I propose to apply it to 10.4. Did not touch spd_db_oracle or spd_db_handlersocket because both are deprecated and removed in newer versions.
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            thanks for the review - pushed the following to 10.4

            18b93d6eb07 upstream/bb-10.4-mdev-28993 MDEV-28993 Spider: Push down CASE statement
            		 
            99dc0f030f0 MDEV-28993 spider: revert removal of ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC

            ycp Yuchen Pei added a comment - thanks for the review - pushed the following to 10.4 18b93d6eb07 upstream/bb-10.4-mdev-28993 MDEV-28993 Spider: Push down CASE statement 99dc0f030f0 MDEV-28993 spider: revert removal of ITEM_FUNC_CASE_PARAMS_ARE_PUBLIC

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.