Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28568 Spider: Push down more functions to improve performance
  3. MDEV-28992

Spider: Push down TIMESTAMPDIFF function

Details

    Description

      To push down TIMESTAMPDIFF, enable Spider code disabled by #ifdef ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC. Some modifications to Spider and the server may be needed.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) created issue -
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
          Field Original Value New Value
          Description Enable Spider code disabled by {{#ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC}}. Some modification to Spider and the server may be needed. Enable Spider code disabled by {{#ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC}}. Some modifications to Spider and the server may be needed.
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
          Description Enable Spider code disabled by {{#ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC}}. Some modifications to Spider and the server may be needed. To push down TIMESTAMPDIFF, enable Spider code disabled by {{#ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC}}. Some modifications to Spider and the server may be needed.
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
          Description To push down TIMESTAMPDIFF, enable Spider code disabled by {{#ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC}}. Some modifications to Spider and the server may be needed. To push down TIMESTAMPDIFF, enable Spider code disabled by {{#ifdef ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC}}. Some modifications to Spider and the server may be needed.
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment -

          https://github.com/MariaDB/server/pull/2225

          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - https://github.com/MariaDB/server/pull/2225
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          nayuta-yanagisawa Nayuta Yanagisawa (Inactive) made changes -
          Status In Progress [ 3 ] In Review [ 10002 ]
          ralf.gebhardt Ralf Gebhardt made changes -
          Fix Version/s 10.12 [ 28320 ]
          Fix Version/s 10.11 [ 27614 ]
          ralf.gebhardt Ralf Gebhardt made changes -
          Assignee Nayuta Yanagisawa [ JIRAUSER47117 ]
          julien.fritsch Julien Fritsch made changes -
          Assignee Yuchen Pei [ JIRAUSER52627 ]
          julien.fritsch Julien Fritsch made changes -
          Assignee Yuchen Pei [ JIRAUSER52627 ] Julien Fritsch [ julien.fritsch ]
          julien.fritsch Julien Fritsch made changes -
          Status In Review [ 10002 ] Stalled [ 10000 ]
          julien.fritsch Julien Fritsch made changes -
          Status Stalled [ 10000 ] In Progress [ 3 ]
          julien.fritsch Julien Fritsch made changes -
          Status In Progress [ 3 ] Needs Feedback [ 10501 ]
          julien.fritsch Julien Fritsch made changes -
          Assignee Julien Fritsch [ julien.fritsch ] Yuchen Pei [ JIRAUSER52627 ]
          ycp Yuchen Pei added a comment -

          To clarify, its current status is "needs feedback" because we are still waiting for the requester to follow up on their PR

          ycp Yuchen Pei added a comment - To clarify, its current status is "needs feedback" because we are still waiting for the requester to follow up on their PR
          ycp Yuchen Pei made changes -
          Fix Version/s N/A [ 14700 ]
          Fix Version/s 11.0 [ 28320 ]
          Resolution Incomplete [ 4 ]
          Status Needs Feedback [ 10501 ] Closed [ 6 ]
          ycp Yuchen Pei made changes -
          Resolution Incomplete [ 4 ]
          Status Closed [ 6 ] Stalled [ 10000 ]
          ycp Yuchen Pei made changes -
          Fix Version/s 11.5 [ 29506 ]
          Fix Version/s N/A [ 14700 ]
          ycp Yuchen Pei added a comment -

          julien.fritsch I've changed the status back to stalled so that it rejoins the queue. When the time comes to fix it and if there's still no update from the requester I'll take over their patch if it is on the right track.

          ycp Yuchen Pei added a comment - julien.fritsch I've changed the status back to stalled so that it rejoins the queue. When the time comes to fix it and if there's still no update from the requester I'll take over their patch if it is on the right track.
          serg Sergei Golubchik made changes -
          Fix Version/s 11.6 [ 29515 ]
          Fix Version/s 11.5 [ 29506 ]
          ycp Yuchen Pei added a comment - - edited

          Hi holyfoot, ptal thanks (in branch bb-10.4-mdev-28992)

          8900bfee662f401152037263700128d8461b98ec
          		 
          MDEV-28992 Spider group by handler: Push down TIMESTAMPDIFF function
          		 
           
          		 
          Also removed ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC.
          		 
           
          		 
          Similar to pr#2225, with the testcase adapted from that patch:
          		 
           
          		 
          --8<---------------cut here---------------start------------->8---
          		 
          From 884f7c6df16236748ca975339e0b1c267e195309 Mon Sep 17 00:00:00 2001
          		 
          From: "Norio Akagi (norakagi)" <norakagi@amazon.com>
          		 
          Date: Wed, 3 Aug 2022 23:30:34 -0700
          		 
          Subject: [PATCH] [MDEV-28992] Push down TIMESTAMP_DIFF in spider
          		 
           
          		 
          This changes so that TIMESTAMP_DIFF function in a query is pushed down and works natively in Spider.
          		 
          Instead of directly accessing item's member, now we can rely on a public accessor method to make it work.
          		 
          Unit tests are added under spider.pushdown_timestamp_diff.
          		 
           
          		 
          All new code of the whole pull request, including one or several files
          		 
          that are either new files or modified ones, are contributed under the
          		 
          BSD-new license. I am contributing on behalf of my employer
          		 
          Amazon Web Services, Inc.
          		 
          --8<---------------cut here---------------end--------------->8---

          I think this change should apply to 10.4, because it basically enables some existing code from there. Let me know if you disagree.

          ycp Yuchen Pei added a comment - - edited Hi holyfoot , ptal thanks (in branch bb-10.4-mdev-28992) 8900bfee662f401152037263700128d8461b98ec MDEV-28992 Spider group by handler: Push down TIMESTAMPDIFF function   Also removed ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC.   Similar to pr#2225, with the testcase adapted from that patch:   --8<---------------cut here---------------start------------->8--- From 884f7c6df16236748ca975339e0b1c267e195309 Mon Sep 17 00:00:00 2001 From: "Norio Akagi (norakagi)" <norakagi@amazon.com> Date: Wed, 3 Aug 2022 23:30:34 -0700 Subject: [PATCH] [MDEV-28992] Push down TIMESTAMP_DIFF in spider   This changes so that TIMESTAMP_DIFF function in a query is pushed down and works natively in Spider. Instead of directly accessing item's member, now we can rely on a public accessor method to make it work. Unit tests are added under spider.pushdown_timestamp_diff.   All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc. --8<---------------cut here---------------end--------------->8--- I think this change should apply to 10.4, because it basically enables some existing code from there. Let me know if you disagree.
          ycp Yuchen Pei made changes -
          Assignee Yuchen Pei [ JIRAUSER52627 ] Alexey Botchkov [ holyfoot ]
          Status Stalled [ 10000 ] In Review [ 10002 ]
          ycp Yuchen Pei made changes -
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 11.6 [ 29515 ]
          ycp Yuchen Pei made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          holyfoot Alexey Botchkov added a comment -

          ok to push.

          holyfoot Alexey Botchkov added a comment - ok to push.
          holyfoot Alexey Botchkov made changes -
          Assignee Alexey Botchkov [ holyfoot ] Yuchen Pei [ JIRAUSER52627 ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          ycp Yuchen Pei added a comment -

          thanks for the review, pushed 44c88faecaa76ad2368101001f30bcb504ff2c7e to 10.4

          ycp Yuchen Pei added a comment - thanks for the review, pushed 44c88faecaa76ad2368101001f30bcb504ff2c7e to 10.4
          ycp Yuchen Pei made changes -
          Fix Version/s 10.4.34 [ 29625 ]
          Fix Version/s 10.4 [ 22408 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          julien.fritsch Julien Fritsch made changes -
          Fix Version/s 10.5.25 [ 29626 ]
          Fix Version/s 10.6.18 [ 29627 ]
          Fix Version/s 10.11.8 [ 29630 ]
          Fix Version/s 11.0.6 [ 29628 ]
          Fix Version/s 11.1.5 [ 29629 ]
          Fix Version/s 11.2.4 [ 29631 ]
          Fix Version/s 11.4.2 [ 29633 ]
          svoj Sergey Vojtovich made changes -
          Labels contribution

          People

            ycp Yuchen Pei
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.