Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28832

infinite loop in mariabackup if log LOG_HEADER_FORMAT field is 0

Details

    Description

      After MDEV-28473 fix, there is infinite loop in mariabackup:

              if (err != DB_SUCCESS) {
                      msg("Error: cannot read redo log header");
      unlock_and_fail:
                      mysql_mutex_unlock(&log_sys.mutex);
              }
       
              if (log_sys.log.format == 0) {
                      msg("Error: cannot process redo log before MariaDB 10.2.2");
                      goto unlock_and_fail;
              }
      

      Attachments

        Issue Links

          Activity

            vlad.lesin Vladislav Lesin created issue -
            vlad.lesin Vladislav Lesin made changes -
            Field Original Value New Value
            vlad.lesin Vladislav Lesin made changes -
            Fix Version/s 10.6 [ 24028 ]
            vlad.lesin Vladislav Lesin made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            serg Sergei Golubchik made changes -
            Issue Type Task [ 3 ] Bug [ 1 ]
            vlad.lesin Vladislav Lesin made changes -
            Affects Version/s 10.5 [ 23123 ]
            Affects Version/s 10.6 [ 24028 ]
            Affects Version/s 10.7 [ 24805 ]
            Affects Version/s 10.8 [ 26121 ]
            Affects Version/s 10.9 [ 26905 ]
            Affects Version/s 10.10 [ 27530 ]

            I was unable to reproduce any infinite loop even with a hand-crafted log file. It could require running a newer major version mariadb-backup against an older server.

            vlad.lesin Vladislav Lesin added a comment - I was unable to reproduce any infinite loop even with a hand-crafted log file. It could require running a newer major version mariadb-backup against an older server.
            vlad.lesin Vladislav Lesin made changes -
            Fix Version/s 10.5.17 [ 27509 ]
            Fix Version/s 10.6.9 [ 27507 ]
            Fix Version/s 10.7.5 [ 27505 ]
            Fix Version/s 10.8.4 [ 27503 ]
            Fix Version/s 10.9.2 [ 27115 ]
            Fix Version/s 10.10.0 [ 27912 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            julien.fritsch Julien Fritsch made changes -
            Affects Version/s 10.4 [ 22408 ]
            julien.fritsch Julien Fritsch made changes -
            Affects Version/s 10.4 [ 22408 ]
            julien.fritsch Julien Fritsch made changes -
            Affects Version/s 10.4 [ 22408 ]
            julien.fritsch Julien Fritsch made changes -
            Affects Version/s 10.4 [ 22408 ]

            People

              vlad.lesin Vladislav Lesin
              vlad.lesin Vladislav Lesin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.