Hi, @marko, it seems that the fixing for MDEV-28689 is buggy. The lock thd->data_mutex is still not released during erroneously writing to the destination stream and writing to the destination stream (Line 246 and 256).
Due to the original issue is closed, thus I just open a new issue.
Thank you Ryan, indeed in MDEV-28689 I only fixed problems related to the ctrl_mutex by removing that mutex. The function compress_write() fails to release the data_mutex in case it fails to write to the stream.
Marko Mäkelä
added a comment - Thank you Ryan , indeed in MDEV-28689 I only fixed problems related to the ctrl_mutex by removing that mutex. The function compress_write() fails to release the data_mutex in case it fails to write to the stream.
People
Marko Mäkelä
Ryan
Votes:
0Vote for this issue
Watchers:
2Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":1594.3000001907349,"ttfb":935.4000000953674,"pageVisibility":"visible","entityId":111482,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"80c4659b-c512-454e-ae68-570e1d64e3d5","navigationType":0,"readyForUser":1663,"redirectCount":0,"resourceLoadedEnd":1832.1000003814697,"resourceLoadedStart":941.5,"resourceTiming":[{"duration":127.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":941.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":941.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1069.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":128.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":941.7000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":941.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1069.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":187.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":942,"connectEnd":942,"connectStart":942,"domainLookupEnd":942,"domainLookupStart":942,"fetchStart":942,"redirectEnd":0,"redirectStart":0,"requestStart":942,"responseEnd":1129.5,"responseStart":1129.5,"secureConnectionStart":942},{"duration":244,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":942.2000002861023,"connectEnd":942.2000002861023,"connectStart":942.2000002861023,"domainLookupEnd":942.2000002861023,"domainLookupStart":942.2000002861023,"fetchStart":942.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":942.2000002861023,"responseEnd":1186.2000002861023,"responseStart":1186.2000002861023,"secureConnectionStart":942.2000002861023},{"duration":247.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":942.4000000953674,"connectEnd":942.4000000953674,"connectStart":942.4000000953674,"domainLookupEnd":942.4000000953674,"domainLookupStart":942.4000000953674,"fetchStart":942.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":942.4000000953674,"responseEnd":1190.2000002861023,"responseStart":1190.2000002861023,"secureConnectionStart":942.4000000953674},{"duration":248.89999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":942.6000003814697,"connectEnd":942.6000003814697,"connectStart":942.6000003814697,"domainLookupEnd":942.6000003814697,"domainLookupStart":942.6000003814697,"fetchStart":942.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":942.6000003814697,"responseEnd":1191.5,"responseStart":1191.5,"secureConnectionStart":942.6000003814697},{"duration":249.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":942.8000001907349,"connectEnd":942.8000001907349,"connectStart":942.8000001907349,"domainLookupEnd":942.8000001907349,"domainLookupStart":942.8000001907349,"fetchStart":942.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":942.8000001907349,"responseEnd":1192.2000002861023,"responseStart":1192.1000003814697,"secureConnectionStart":942.8000001907349},{"duration":329.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":942.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":942.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1272.5,"responseStart":0,"secureConnectionStart":0},{"duration":250.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":943.1000003814697,"connectEnd":943.1000003814697,"connectStart":943.1000003814697,"domainLookupEnd":943.1000003814697,"domainLookupStart":943.1000003814697,"fetchStart":943.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":943.1000003814697,"responseEnd":1193.3000001907349,"responseStart":1193.3000001907349,"secureConnectionStart":943.1000003814697},{"duration":329.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":943.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":943.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1272.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":251.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":943.4000000953674,"connectEnd":943.4000000953674,"connectStart":943.4000000953674,"domainLookupEnd":943.4000000953674,"domainLookupStart":943.4000000953674,"fetchStart":943.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":943.4000000953674,"responseEnd":1194.5,"responseStart":1194.5,"secureConnectionStart":943.4000000953674},{"duration":860.3000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":944.3000001907349,"connectEnd":944.3000001907349,"connectStart":944.3000001907349,"domainLookupEnd":944.3000001907349,"domainLookupStart":944.3000001907349,"fetchStart":944.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":944.3000001907349,"responseEnd":1804.6000003814697,"responseStart":1804.6000003814697,"secureConnectionStart":944.3000001907349},{"duration":861.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":944.4000000953674,"connectEnd":944.4000000953674,"connectStart":944.4000000953674,"domainLookupEnd":944.4000000953674,"domainLookupStart":944.4000000953674,"fetchStart":944.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":944.4000000953674,"responseEnd":1806.1000003814697,"responseStart":1806.1000003814697,"secureConnectionStart":944.4000000953674},{"duration":195,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1283.2000002861023,"connectEnd":1283.2000002861023,"connectStart":1283.2000002861023,"domainLookupEnd":1283.2000002861023,"domainLookupStart":1283.2000002861023,"fetchStart":1283.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":1283.2000002861023,"responseEnd":1478.2000002861023,"responseStart":1478.2000002861023,"secureConnectionStart":1283.2000002861023},{"duration":285.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1545.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1545.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1831.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":277.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1546.4000000953674,"connectEnd":1546.4000000953674,"connectStart":1546.4000000953674,"domainLookupEnd":1546.4000000953674,"domainLookupStart":1546.4000000953674,"fetchStart":1546.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":1546.4000000953674,"responseEnd":1823.5,"responseStart":1823.5,"secureConnectionStart":1546.4000000953674},{"duration":285.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1546.8000001907349,"connectEnd":1546.8000001907349,"connectStart":1546.8000001907349,"domainLookupEnd":1546.8000001907349,"domainLookupStart":1546.8000001907349,"fetchStart":1546.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":1546.8000001907349,"responseEnd":1832.1000003814697,"responseStart":1832,"secureConnectionStart":1546.8000001907349},{"duration":333.8999996185303,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1585.6000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1585.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1919.5,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":276,"responseStart":936,"responseEnd":939,"domLoading":939,"domInteractive":1867,"domContentLoadedEventStart":1867,"domContentLoadedEventEnd":1917,"domComplete":2288,"loadEventStart":2288,"loadEventEnd":2289,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1840.5},{"name":"bigPipe.sidebar-id.end","time":1841.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1841.6000003814697},{"name":"bigPipe.activity-panel-pipe-id.end","time":1842.4000000953674},{"name":"activityTabFullyLoaded","time":1931.1000003814697}],"measures":[],"correlationId":"125b73b42cb5e0","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":606,"dbReadsTimeInMs":12,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Thank you Ryan, indeed in
MDEV-28689I only fixed problems related to the ctrl_mutex by removing that mutex. The function compress_write() fails to release the data_mutex in case it fails to write to the stream.