[MDEV-28719] compress_write() fails to release mutex on failure - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.9.1, 10.3(EOL), 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL)
Fix Version/s: 10.3.36, 10.4.26, 10.5.17, 10.6.9, 10.7.5, 10.8.4, 10.9.2
Component/s: Backup
Labels:
None
Environment:
All

Description

Hi, @marko, it seems that the fixing for ~~MDEV-28689~~ is buggy. The lock thd->data_mutex is still not released during erroneously writing to the destination stream and writing to the destination stream (Line 246 and 256).

Due to the original issue is closed, thus I just open a new issue.

https://github.com/MariaDB/server/blob/863c3eda872b19f70ce6045119bf621584e1312d/extra/mariabackup/ds_compress.cc#L233-L259

Attachments

Issue Links

links to

CVE-2022-38791

Activity

Marko Mäkelä added a comment - 2022-06-01 08:23

Thank you Ryan, indeed in ~~MDEV-28689~~ I only fixed problems related to the ctrl_mutex by removing that mutex. The function compress_write() fails to release the data_mutex in case it fails to write to the stream.

Marko Mäkelä added a comment - 2022-06-01 08:23 Thank you Ryan , indeed in MDEV-28689 I only fixed problems related to the ctrl_mutex by removing that mutex. The function compress_write() fails to release the data_mutex in case it fails to write to the stream.

People

Assignee:: Marko Mäkelä

Reporter:: Ryan

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2022-06-01 07:23

Updated:: 2023-01-18 14:32

Resolved:: 2022-06-01 09:23

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server