[MDEV-28719] compress_write() fails to release mutex on failure - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.9.1, 10.3(EOL), 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL)
Fix Version/s: 10.3.36, 10.4.26, 10.5.17, 10.6.9, 10.7.5, 10.8.4, 10.9.2
Component/s: Backup
Labels:
None
Environment:
All

Description

Hi, @marko, it seems that the fixing for ~~MDEV-28689~~ is buggy. The lock thd->data_mutex is still not released during erroneously writing to the destination stream and writing to the destination stream (Line 246 and 256).

Due to the original issue is closed, thus I just open a new issue.

https://github.com/MariaDB/server/blob/863c3eda872b19f70ce6045119bf621584e1312d/extra/mariabackup/ds_compress.cc#L233-L259

Attachments

Issue Links

links to

CVE-2022-38791

Activity

Ascending order - Click to sort in descending order

Ryan created issue - 2022-06-01 07:23

Marko Mäkelä made changes - 2022-06-01 08:23

Field	Original Value	New Value
Fix Version/s		10.3 [ 22126 ]
Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]
Fix Version/s		10.6 [ 24028 ]
Fix Version/s		10.7 [ 24805 ]
Fix Version/s		10.8 [ 26121 ]
Fix Version/s		10.9 [ 26905 ]
Affects Version/s		10.3 [ 22126 ]
Affects Version/s		10.4 [ 22408 ]
Affects Version/s		10.5 [ 23123 ]
Affects Version/s		10.6 [ 24028 ]
Affects Version/s		10.7 [ 24805 ]
Affects Version/s		10.8 [ 26121 ]
Assignee		Marko Mäkelä [ marko ]

Marko Mäkelä made changes - 2022-06-01 08:23

Summary

An improper locking bug (insufficient fixing of prior issues)

compress_write() fails to release mutex on failure

Marko Mäkelä made changes - 2022-06-01 08:24

Status

Open [ 1 ]

In Progress [ 3 ]

Marko Mäkelä made changes - 2022-06-01 09:23

issue.field.resolutiondate

2022-06-01 09:23:58.0

2022-06-01 09:23:58.962

Marko Mäkelä made changes - 2022-06-01 09:23

Fix Version/s		10.3.36 [ 27513 ]
Fix Version/s		10.4.26 [ 27511 ]
Fix Version/s		10.5.17 [ 27509 ]
Fix Version/s		10.6.9 [ 27507 ]
Fix Version/s		10.7.5 [ 27505 ]
Fix Version/s		10.8.4 [ 27503 ]
Fix Version/s		10.9.2 [ 27115 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Fix Version/s	10.7 [ 24805 ]
Fix Version/s	10.8 [ 26121 ]
Fix Version/s	10.9 [ 26905 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2023-01-18 14:32

Remote Link

This issue links to "CVE-2022-38791 (Web Link)" [ 34709 ]

People

Assignee:: Marko Mäkelä

Reporter:: Ryan

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2022-06-01 07:23

Updated:: 2023-01-18 14:32

Resolved:: 2022-06-01 09:23

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server