Type:
Task
Priority:
Major
Resolution:
Unresolved
MDEV-19556 adds engine-native record sampling. It also adds code that uses sampling for its primary purpose, that is, to collect histograms.
However, it is fairly difficult to do testing. Looking at the collected histogram, it is hard to tell whether the sampling code has provided each record the same chance of being in the output, etc.
This MDEV is about adding the basic TABLESAMPLE syntax support which allows one to examine the sampled rows directly.
The SQL syntax for TABLESAMPLE feature:
<table factor> ::=
<table primary> [ <sample clause> ]
<sample clause> ::=
TABLESAMPLE <sample method> <left paren> <sample percentage> <right paren>
[ <repeatable clause> ]
<sample method> ::=
BERNOULLI
| SYSTEM
<repeatable clause> ::=
REPEATABLE <left paren> <repeat argument> <right paren>
<sample percentage> ::=
<numeric value expression>
<repeat argument> ::=
<numeric value expression>
TABLESAMPLE is a reserved word.
We allow only this syntax:
TABLESAMPLE SYSTEM ( number )
We allow it only for SELECTs (not for DML).
The optimizer will not use any indexes for the table that uses TABLESAMPLE syntax.
It will also ignore the fact that sampling the table produces fewer rows.
relates to
MDEV-19556
Support native storage engine sampling of rows
Open
{"report":{"fcp":994.6999999880791,"ttfb":319.89999997615814,"pageVisibility":"visible","entityId":111189,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"3bc5d948-0a2c-4c96-8e70-d57c4939757e","navigationType":0,"readyForUser":1075.5999999940395,"redirectCount":0,"resourceLoadedEnd":914.3999999761581,"resourceLoadedStart":325.69999998807907,"resourceTiming":[{"duration":174.19999998807907,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":325.69999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":325.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":499.89999997615814,"responseStart":0,"secureConnectionStart":0},{"duration":174.30000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":325.89999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":325.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":500.19999998807907,"responseStart":0,"secureConnectionStart":0},{"duration":182.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":326.09999999403954,"connectEnd":326.09999999403954,"connectStart":326.09999999403954,"domainLookupEnd":326.09999999403954,"domainLookupStart":326.09999999403954,"fetchStart":326.09999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":326.09999999403954,"responseEnd":508.89999997615814,"responseStart":508.89999997615814,"secureConnectionStart":326.09999999403954},{"duration":236.2000000178814,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":326.39999997615814,"connectEnd":326.39999997615814,"connectStart":326.39999997615814,"domainLookupEnd":326.39999997615814,"domainLookupStart":326.39999997615814,"fetchStart":326.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":326.39999997615814,"responseEnd":562.5999999940395,"responseStart":562.5,"secureConnectionStart":326.39999997615814},{"duration":239.19999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":326.59999999403954,"connectEnd":326.59999999403954,"connectStart":326.59999999403954,"domainLookupEnd":326.59999999403954,"domainLookupStart":326.59999999403954,"fetchStart":326.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":326.59999999403954,"responseEnd":565.7999999821186,"responseStart":565.7999999821186,"secureConnectionStart":326.59999999403954},{"duration":239.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":326.7999999821186,"connectEnd":326.7999999821186,"connectStart":326.7999999821186,"domainLookupEnd":326.7999999821186,"domainLookupStart":326.7999999821186,"fetchStart":326.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":326.7999999821186,"responseEnd":566.2999999821186,"responseStart":566.2999999821186,"secureConnectionStart":326.7999999821186},{"duration":239.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":327,"connectEnd":327,"connectStart":327,"domainLookupEnd":327,"domainLookupStart":327,"fetchStart":327,"redirectEnd":0,"redirectStart":0,"requestStart":327,"responseEnd":566.7999999821186,"responseStart":566.7999999821186,"secureConnectionStart":327},{"duration":322.7999999821186,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":327.09999999403954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":327.09999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":649.8999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":239.90000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":327.2999999821186,"connectEnd":327.2999999821186,"connectStart":327.2999999821186,"domainLookupEnd":327.2999999821186,"domainLookupStart":327.2999999821186,"fetchStart":327.2999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":327.2999999821186,"responseEnd":567.1999999880791,"responseStart":567.1999999880791,"secureConnectionStart":327.2999999821186},{"duration":322.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":327.39999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":327.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":650,"responseStart":0,"secureConnectionStart":0},{"duration":240.09999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":327.69999998807907,"connectEnd":327.69999998807907,"connectStart":327.69999998807907,"domainLookupEnd":327.69999998807907,"domainLookupStart":327.69999998807907,"fetchStart":327.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":327.69999998807907,"responseEnd":567.7999999821186,"responseStart":567.7999999821186,"secureConnectionStart":327.69999998807907},{"duration":357.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":328.5,"connectEnd":328.5,"connectStart":328.5,"domainLookupEnd":328.5,"domainLookupStart":328.5,"fetchStart":328.5,"redirectEnd":0,"redirectStart":0,"requestStart":328.5,"responseEnd":686.2999999821186,"responseStart":686.2999999821186,"secureConnectionStart":328.5},{"duration":402.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":328.59999999403954,"connectEnd":328.59999999403954,"connectStart":328.59999999403954,"domainLookupEnd":328.59999999403954,"domainLookupStart":328.59999999403954,"fetchStart":328.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":328.59999999403954,"responseEnd":731.0999999940395,"responseStart":731.0999999940395,"secureConnectionStart":328.59999999403954},{"duration":38.30000001192093,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":660.8999999761581,"connectEnd":660.8999999761581,"connectStart":660.8999999761581,"domainLookupEnd":660.8999999761581,"domainLookupStart":660.8999999761581,"fetchStart":660.8999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":660.8999999761581,"responseEnd":699.1999999880791,"responseStart":699.1999999880791,"secureConnectionStart":660.8999999761581},{"duration":210.39999997615814,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":704,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":704,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":914.3999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":440.19999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":705,"connectEnd":705,"connectStart":705,"domainLookupEnd":705,"domainLookupStart":705,"fetchStart":705,"redirectEnd":0,"redirectStart":0,"requestStart":705,"responseEnd":1145.199999988079,"responseStart":1145.199999988079,"secureConnectionStart":705},{"duration":445.90000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/53a43b6764f587426c7bb9a150184c00-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":705.2999999821186,"connectEnd":705.2999999821186,"connectStart":705.2999999821186,"domainLookupEnd":705.2999999821186,"domainLookupStart":705.2999999821186,"fetchStart":705.2999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":705.2999999821186,"responseEnd":1151.199999988079,"responseStart":1151.199999988079,"secureConnectionStart":705.2999999821186}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":139,"responseStart":320,"responseEnd":321,"domLoading":323,"domInteractive":1131,"domContentLoadedEventStart":1131,"domContentLoadedEventEnd":1176,"domComplete":1769,"loadEventStart":1769,"loadEventEnd":1771,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1111.7999999821186},{"name":"bigPipe.sidebar-id.end","time":1112.7999999821186},{"name":"bigPipe.activity-panel-pipe-id.start","time":1112.8999999761581},{"name":"bigPipe.activity-panel-pipe-id.end","time":1115.5999999940395},{"name":"activityTabFullyLoaded","time":1189.5999999940395}],"measures":[],"correlationId":"913383019be4a5","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":114,"dbReadsTimeInMs":11,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}