The conn_kind, which stands for "connection kind", is no longer useful because the HandlerSocket support is deleted and Spider now has only one connection kind, SPIDER_CONN_KIND_MYSQL. Remove conn_kind and related code.
Attachments
Issue Links
relates to
MDEV-26858Spider: Remove dead code related to HandlerSocket
The conn_kind, which stands for "connection kind", seems to be doing nothing. Verify the statement and, if true, remove conn_kind and related code.
The {{conn_kind}}, which stands for "connection kind", is no longer useful because the HandlerSocket support is deleted and Spider now has only one connection kind, {{SPIDER_CONN_KIND_MYSQL}}. Remove conn_kind and related code.
ycp There are still some occurrences of SPIDER_CONN_KIND_MYSQL in the code. Could you also remove the constant SPIDER_CONN_KIND_MYSQL itself and related code fragments? Also, please enrich the commit message, which could be a verbatim copy of the issue description.
By the way, this is my bad, but the fix version should be 10.12, which is the latest development branch.
Nayuta Yanagisawa (Inactive)
added a comment - ycp There are still some occurrences of SPIDER_CONN_KIND_MYSQL in the code. Could you also remove the constant SPIDER_CONN_KIND_MYSQL itself and related code fragments? Also, please enrich the commit message, which could be a verbatim copy of the issue description.
By the way, this is my bad, but the fix version should be 10.12, which is the latest development branch.
nayuta-yanagisawa
> There are still some occurrences of SPIDER_CONN_KIND_MYSQL in the code. Could you also remove the constant SPIDER_CONN_KIND_MYSQL itself and related code fragments? Also, please enrich the commit message, which could be a verbatim copy of the issue description.
Yuchen Pei
added a comment - - edited nayuta-yanagisawa
> There are still some occurrences of SPIDER_CONN_KIND_MYSQL in the code. Could you also remove the constant SPIDER_CONN_KIND_MYSQL itself and related code fragments? Also, please enrich the commit message, which could be a verbatim copy of the issue description.
Done: https://github.com/MariaDB/server/commit/b7b4375fe73840c5f7e0fc02ee00e51f6e2ae550
PTAL thanks.
ycp Mostly looks OK to me except diff on storage/spider/spd_table.cc. Have you applied clang-format or something on the file? Please do not modify parts of the code that are not related to the present task. If you like to format your patch, maybe clang-format-diff works.
Nayuta Yanagisawa (Inactive)
added a comment - - edited ycp Mostly looks OK to me except diff on storage/spider/spd_table.cc . Have you applied clang-format or something on the file? Please do not modify parts of the code that are not related to the present task. If you like to format your patch, maybe clang-format-diff works.
nayuta-yanagisawa
> Mostly looks OK to me except diff on storage/spider/spd_table.cc. Have you applied clang-format or something on the file? Please do not modify parts of the code that are not related to the present task. If you like to format your patch, maybe clang-format-diff works.
Sorry about the problem - I'm still trying to tame the IDE. Here's the updated commit - PTAL:
Yuchen Pei
added a comment - - edited nayuta-yanagisawa
> Mostly looks OK to me except diff on storage/spider/spd_table.cc. Have you applied clang-format or something on the file? Please do not modify parts of the code that are not related to the present task. If you like to format your patch, maybe clang-format-diff works.
Sorry about the problem - I'm still trying to tame the IDE. Here's the updated commit - PTAL:
https://github.com/MariaDB/server/commit/ed3488e3ed040cf27ac3017090dce9bedcc43c8c
nayuta-yanagisawa
Just applied formatting with `git diff -U0 --no-color --relative HEAD^ | clang-format-diff -p1 -i`, and did a sanity check on the result which looked alright to me. PTAL thanks:
Sorry, just noticed there's another comment to address. Working on it.
Yuchen Pei
added a comment - - edited nayuta-yanagisawa
Just applied formatting with `git diff -U0 --no-color --relative HEAD^ | clang-format-diff -p1 -i`, and did a sanity check on the result which looked alright to me. PTAL thanks:
htt ps://github.com/MariaDB/server/commit/b7b4375fe73840c5f7e0fc02ee00e51f6e2ae550-
Sorry, should be this one:
-htt ps://github.com/MariaDB/server/commit/b1ee3d2d08fa5a39dd4fdddfa907bb92b1362356
Sorry, just noticed there's another comment to address. Working on it.
Task
Major
https://github.com/MariaDB/server/commit/aea4f44cfe2c1b8a2318a27f28512769cda69b50