Type:
Bug
Priority:
Critical
Resolution:
Fixed
Affects Version/s:
N/A
After recent rebases, two problems have appeared with hashicorp debian packaging.
First, it makes the whole debian build fail, see for example
http://buildbot.askmonty.org/buildbot/builders/kvm-deb-stretch-amd64/builds/27911/steps/compile/logs/stdio
bb-10.9-MDEV-19281-v5 a47e08aa2
dh_install: usr/share/doc/mariadb-hashicorp-key-management-10.9/hashicorp_key_management.txt exists in debian/tmp but is not installed to anywhere
dh_install: missing files, aborting
debian/rules:213: recipe for target 'binary' failed
make: *** [binary] Error 2
It started failing because the packages are now built with --fail-missing .
To fix, hashicorp_key_management.txt should be installed in a proper place or marked as not installed.
Second, if the problem above is solved and the packages get built, the hashicorp plugin package cannot be installed, see e.g.
http://buildbot.askmonty.org/buildbot/builders/kvm-deb-stretch-amd64/builds/27838/steps/install/logs/stdio
bb-10.9-MDEV-19281-v5 ccbc0df247b
The following packages have unmet dependencies:
mariadb-plugin-hashicorp-key-management : Depends: mariadb-server-10.9 (= 1:10.9.0+maria~stretch)
E: Unable to correct problems, you have held broken packages.
It happens because mariadb-plugin-hashicorp-key-management depends on mariadb-server-10.9, while in the new Debian packaging it should be mariadb-server. Something like this should do the trick, I suppose (subject to checking by someone who knows something about Debian packaging):
diff --git a/debian/control b/debian/control
index 0fd1df3ac58e..f9401b9ff886 100644
--- a/debian/control
+++ b/debian/control
@@ -985,7 +985,7 @@ Description: CrackLib Password Validation Plugin for MariaDB
Package: mariadb-plugin-hashicorp-key-management
Architecture: any
-Depends: mariadb-server-10.9 (= ${binary:Version}),
+Depends: mariadb-server (= ${server:Version}),
${misc:Depends},
${shlibs:Depends}
Description: Hashicorp Key Management plugin for MariaDB
relates to
MDEV-19281
Vault Key Management Plugin
Closed
{"report":{"fcp":762.9000005722046,"ttfb":167.5,"pageVisibility":"visible","entityId":110729,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"ae015957-cc12-47a9-9c9c-1e0f7f4da66a","navigationType":0,"readyForUser":840.6999998092651,"redirectCount":0,"resourceLoadedEnd":580.1999998092651,"resourceLoadedStart":181,"resourceTiming":[{"duration":44.40000057220459,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":181,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":181,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":225.4000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":44.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":181.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":181.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":226,"responseStart":0,"secureConnectionStart":0},{"duration":212.89999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":181.4000005722046,"connectEnd":181.4000005722046,"connectStart":181.4000005722046,"domainLookupEnd":181.4000005722046,"domainLookupStart":181.4000005722046,"fetchStart":181.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":228.5,"responseEnd":394.30000019073486,"responseStart":251.69999980926514,"secureConnectionStart":181.4000005722046},{"duration":323,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":182.19999980926514,"connectEnd":182.19999980926514,"connectStart":182.19999980926514,"domainLookupEnd":182.19999980926514,"domainLookupStart":182.19999980926514,"fetchStart":182.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":230,"responseEnd":505.19999980926514,"responseStart":268,"secureConnectionStart":182.19999980926514},{"duration":73.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":182.30000019073486,"connectEnd":182.30000019073486,"connectStart":182.30000019073486,"domainLookupEnd":182.30000019073486,"domainLookupStart":182.30000019073486,"fetchStart":182.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":232.4000005722046,"responseEnd":255.9000005722046,"responseStart":254.69999980926514,"secureConnectionStart":182.30000019073486},{"duration":75.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":182.30000019073486,"connectEnd":182.30000019073486,"connectStart":182.30000019073486,"domainLookupEnd":182.30000019073486,"domainLookupStart":182.30000019073486,"fetchStart":182.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":232.80000019073486,"responseEnd":258,"responseStart":256,"secureConnectionStart":182.30000019073486},{"duration":75.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":182.5,"connectEnd":182.5,"connectStart":182.5,"domainLookupEnd":182.5,"domainLookupStart":182.5,"fetchStart":182.5,"redirectEnd":0,"redirectStart":0,"requestStart":233.69999980926514,"responseEnd":258.30000019073486,"responseStart":256.80000019073486,"secureConnectionStart":182.5},{"duration":49.59999942779541,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":182.60000038146973,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182.60000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":232.19999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":76.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":182.69999980926514,"connectEnd":182.69999980926514,"connectStart":182.69999980926514,"domainLookupEnd":182.69999980926514,"domainLookupStart":182.69999980926514,"fetchStart":182.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":235.80000019073486,"responseEnd":259.30000019073486,"responseStart":258.30000019073486,"secureConnectionStart":182.69999980926514},{"duration":49.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":182.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":232.60000038146973,"responseStart":0,"secureConnectionStart":0},{"duration":84.79999923706055,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":182.9000005722046,"connectEnd":182.9000005722046,"connectStart":182.9000005722046,"domainLookupEnd":182.9000005722046,"domainLookupStart":182.9000005722046,"fetchStart":182.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":236.9000005722046,"responseEnd":267.69999980926514,"responseStart":265.69999980926514,"secureConnectionStart":182.9000005722046},{"duration":276.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":186.10000038146973,"connectEnd":186.10000038146973,"connectStart":186.10000038146973,"domainLookupEnd":186.10000038146973,"domainLookupStart":186.10000038146973,"fetchStart":186.10000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":305.19999980926514,"responseEnd":462.69999980926514,"responseStart":457.69999980926514,"secureConnectionStart":186.10000038146973},{"duration":394,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":186.19999980926514,"connectEnd":186.19999980926514,"connectStart":186.19999980926514,"domainLookupEnd":186.19999980926514,"domainLookupStart":186.19999980926514,"fetchStart":186.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":568,"responseEnd":580.1999998092651,"responseStart":579.3000001907349,"secureConnectionStart":186.19999980926514},{"duration":222.79999923706055,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":522.9000005722046,"connectEnd":522.9000005722046,"connectStart":522.9000005722046,"domainLookupEnd":522.9000005722046,"domainLookupStart":522.9000005722046,"fetchStart":522.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":717,"responseEnd":745.6999998092651,"responseStart":744.9000005722046,"secureConnectionStart":522.9000005722046},{"duration":160.4000005722046,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":755.6999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":755.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":916.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":202.39999961853027,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":778.6000003814697,"connectEnd":778.6000003814697,"connectStart":778.6000003814697,"domainLookupEnd":778.6000003814697,"domainLookupStart":778.6000003814697,"fetchStart":778.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":950.5,"responseEnd":981,"responseStart":980.1999998092651,"secureConnectionStart":778.6000003814697}],"fetchStart":0,"domainLookupStart":15,"domainLookupEnd":17,"connectStart":17,"connectEnd":36,"secureConnectionStart":25,"requestStart":37,"responseStart":167,"responseEnd":185,"domLoading":171,"domInteractive":943,"domContentLoadedEventStart":943,"domContentLoadedEventEnd":989,"domComplete":1490,"loadEventStart":1491,"loadEventEnd":1491,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":921.3000001907349},{"name":"bigPipe.sidebar-id.end","time":922},{"name":"bigPipe.activity-panel-pipe-id.start","time":922.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":923.6999998092651},{"name":"activityTabFullyLoaded","time":1007}],"measures":[],"correlationId":"1b0881de174e24","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":74,"dbReadsTimeInMs":13,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Good. Did one last amendment pushed to bb-10.9-
MDEV-19281-v5 to keep the documentation directory consistent with the package name which seems to be the debian convention.diff --git a/debian/mariadb-plugin-hashicorp-key-management.install b/debian/mariadb-plugin-hashicorp-key-management.install
index 55f7909d2bf..ca63f3df403 100644
--- a/debian/mariadb-plugin-hashicorp-key-management.install
+++ b/debian/mariadb-plugin-hashicorp-key-management.install
@@ -1,3 +1,3 @@
etc/mysql/mariadb.conf.d/hashicorp_key_management.cnf
usr/lib/mysql/plugin/hashicorp_key_management.so
-usr/share/doc/mariadb-hashicorp-key-management/hashicorp_key_management.txt
+usr/share/doc/mariadb-plugin-hashicorp-key-management/hashicorp_key_management.txt
diff --git a/plugin/hashicorp_key_management/CMakeLists.txt b/plugin/hashicorp_key_management/CMakeLists.txt
index af854dec0ac..c68b6ccb719 100644
--- a/plugin/hashicorp_key_management/CMakeLists.txt
+++ b/plugin/hashicorp_key_management/CMakeLists.txt
@@ -19,4 +19,4 @@ MYSQL_ADD_PLUGIN(HASHICORP_KEY_MANAGEMENT
ADD_FEATURE_INFO(HASHICORP_KEY_MANAGEMENT "ON" "Hashicorp Key Management Plugin")
INSTALL_DOCUMENTATION(hashicorp_key_management.txt
- COMPONENT hashicorp-key-management)
+ COMPONENT plugin-hashicorp-key-management)