Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28243

AIX missing my_gethwaddr implementation (and failing spider tests)

Details

    Attachments

      Issue Links

        Activity

          danblack Daniel Black created issue -
          danblack Daniel Black added a comment -

          After porting https://github.com/tridge/junkcode/blob/c271acabd1b1ae24cff1624d5d7bb9bbb9d5c1b9/aix_getmac.c#L10 it failed with a errno 22.

          So reverted to using the ioctl SIOCGIFHWADDR.

          danblack Daniel Black added a comment - After porting https://github.com/tridge/junkcode/blob/c271acabd1b1ae24cff1624d5d7bb9bbb9d5c1b9/aix_getmac.c#L10 it failed with a errno 22. So reverted to using the ioctl SIOCGIFHWADDR.
          danblack Daniel Black made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          danblack Daniel Black added a comment -

          Thanks nayuta-yanagisawa for reviewing the spider test change.

          monty, happy with the rest of https://github.com/MariaDB/server/pull/2081?

          danblack Daniel Black added a comment - Thanks nayuta-yanagisawa for reviewing the spider test change. monty , happy with the rest of https://github.com/MariaDB/server/pull/2081?
          danblack Daniel Black made changes -
          Assignee Daniel Black [ danblack ] Michael Widenius [ monty ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          danblack Daniel Black made changes -
          Assignee Michael Widenius [ monty ] Daniel Black [ danblack ]
          danblack Daniel Black made changes -
          issue.field.resolutiondate 2022-06-08 07:14:45.0 2022-06-08 07:14:45.26
          danblack Daniel Black made changes -
          Fix Version/s 10.5.17 [ 27509 ]
          Fix Version/s 10.6.9 [ 27507 ]
          Fix Version/s 10.7.5 [ 27505 ]
          Fix Version/s 10.8.4 [ 27503 ]
          Fix Version/s 10.9.2 [ 27115 ]
          Fix Version/s 10.5 [ 23123 ]
          Resolution Fixed [ 1 ]
          Status In Review [ 10002 ] Closed [ 6 ]

          If I install MariaDB on Debian11 from https://dlm.mariadb.com/repo/mariadb-server/... and do a 'SELECT UUID();' then I always get '-040300000000' as the fifth number and not the mac address of the machine. Example with command line 'mysql':

          Welcome to the MariaDB monitor.  Commands end with ; or \g.
          Your MariaDB connection id is 30
          Server version: 10.5.17-MariaDB-1:10.5.17+maria~deb11 mariadb.org binary distribution
          ......
          MariaDB [(none)]> select UUID();
          +--------------------------------------+
          | UUID()                               |
          +--------------------------------------+
          | 3a688c85-239a-11ed-9a5d-040300000000 |
          +--------------------------------------+
          1 row in set (0,000 sec)
          

          The same happens with MariaDB 10.6 and also on a different machine.

          Kernel is: 5.10.0-17-amd64 #1 SMP Debian 5.10.136-1 (2022-08-13) x86_64 GNU/Linux

          If I install the package that comes with Debian11 on the same machine everything is fine:

          Welcome to the MariaDB monitor.  Commands end with ; or \g.
          Your MariaDB connection id is 30
          Server version: 10.5.15-MariaDB-0+deb11u1 Debian 11
          .....
          MariaDB [(none)]> select UUID();
          +--------------------------------------+
          | UUID()                               |
          +--------------------------------------+
          | e58b1ad1-239a-11ed-b1cd-a249edae51a0 |
          +--------------------------------------+
          1 row in set (0.000 sec)
          

          If I use

          ./mariadb_repo_setup --mariadb-server-version="mariadb-10.6.8"
          

          to set up the mariadb repository, the version before this commit get's installed and it works also:

          Your MariaDB connection id is 31
          Server version: 10.6.8-MariaDB-1:10.6.8+maria~bullseye mariadb.org binary distribution
          .......
          MariaDB [(none)]> select UUID();
          +--------------------------------------+
          | UUID()                               |
          +--------------------------------------+
          | cc7e9d64-2873-11ed-8542-a249edae51a0 |
          +--------------------------------------+
          1 row in set (0.000 sec)
          

          Can this be related to this change?

          illetschko Peter ILLETSCHKO added a comment - If I install MariaDB on Debian11 from https://dlm.mariadb.com/repo/mariadb-server/ ... and do a 'SELECT UUID();' then I always get '-040300000000' as the fifth number and not the mac address of the machine. Example with command line 'mysql': Welcome to the MariaDB monitor. Commands end with ; or \g. Your MariaDB connection id is 30 Server version: 10.5.17-MariaDB-1:10.5.17+maria~deb11 mariadb.org binary distribution ...... MariaDB [(none)]> select UUID(); +--------------------------------------+ | UUID() | +--------------------------------------+ | 3a688c85-239a-11ed-9a5d-040300000000 | +--------------------------------------+ 1 row in set (0,000 sec) The same happens with MariaDB 10.6 and also on a different machine. Kernel is: 5.10.0-17-amd64 #1 SMP Debian 5.10.136-1 (2022-08-13) x86_64 GNU/Linux If I install the package that comes with Debian11 on the same machine everything is fine: Welcome to the MariaDB monitor. Commands end with ; or \g. Your MariaDB connection id is 30 Server version: 10.5.15-MariaDB-0+deb11u1 Debian 11 ..... MariaDB [(none)]> select UUID(); +--------------------------------------+ | UUID() | +--------------------------------------+ | e58b1ad1-239a-11ed-b1cd-a249edae51a0 | +--------------------------------------+ 1 row in set (0.000 sec) If I use ./mariadb_repo_setup --mariadb-server-version="mariadb-10.6.8" to set up the mariadb repository, the version before this commit get's installed and it works also: Your MariaDB connection id is 31 Server version: 10.6.8-MariaDB-1:10.6.8+maria~bullseye mariadb.org binary distribution ....... MariaDB [(none)]> select UUID(); +--------------------------------------+ | UUID() | +--------------------------------------+ | cc7e9d64-2873-11ed-8542-a249edae51a0 | +--------------------------------------+ 1 row in set (0.000 sec) Can this be related to this change?
          danblack Daniel Black made changes -
          danblack Daniel Black added a comment - - edited

          illetschko you're right.

          My embarrassing error. Sorry for the inconvenience. I should read reviewer suggested code more carefully.

          For next bug report, can you please create a new bug report like MDEV-29418 that I did for this. A comment on a closed bug can sometime be forgotten.

          Thanks for reporting the error and my embarrassing apology for making the bug.

          danblack Daniel Black added a comment - - edited illetschko you're right. My embarrassing error . Sorry for the inconvenience. I should read reviewer suggested code more carefully. For next bug report, can you please create a new bug report like MDEV-29418 that I did for this. A comment on a closed bug can sometime be forgotten. Thanks for reporting the error and my embarrassing apology for making the bug.

          People

            danblack Daniel Black
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.