Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28170

missing '$' in variable check in wsrep_sst_common script

Details

    Description

      MDEV-27181 introduced a problem in the wsrep_sst_common script which is only hit when using encrypted SST:

      /usr//bin/wsrep_sst_common: line 1127: [: readable: integer expression expected
      

      Problem is the readable variable in the if condition, it should be $readable like it is earlier on line 1109 in the same script:

      1123     local readable=1; [ ! -r "$cert" ] && readable=0
      1124     [ -n "$ca"  ] &&  [ ! -r "$ca"   ] && readable=0
      1125     [ -n "$cap" ] &&  [ ! -r "$cap"  ] && readable=0
      1126 
      1127     if [ readable -eq 0 ]; then
      1128         wsrep_log_error \
      1129             "Both PEM file and CA file (or path) must be readable"
      1130         exit 22
      1131     fi
      

      Attachments

        Issue Links

          Activity

            Set to "minor" as encrypted SST still works when configured properly, it would only fail if without a proper error message in case some key or certificate file were not readable

            hholzgra Hartmut Holzgraefe added a comment - Set to "minor" as encrypted SST still works when configured properly, it would only fail if without a proper error message in case some key or certificate file were not readable

            I think sysprg was fixing it recently somewhere, maybe it's not in the release yet.

            elenst Elena Stepanova added a comment - I think sysprg was fixing it recently somewhere, maybe it's not in the release yet.

            I thought I had still seen it on github head (that's how i found out about related MDEV-27181 in the first place), but now looking again it indeed seems to have been fixed already .... weird ...

            hholzgra Hartmut Holzgraefe added a comment - I thought I had still seen it on github head (that's how i found out about related MDEV-27181 in the first place), but now looking again it indeed seems to have been fixed already .... weird ...
            sysprg Julius Goryavsky added a comment - hholzgra It already fixed & merged with main branch, https://github.com/MariaDB/server/commit/35725df6e2791d19bebf0301bb9fcb6200f5b00d
            sysprg Julius Goryavsky added a comment - Fixed, https://github.com/MariaDB/server/commit/35725df6e2791d19bebf0301bb9fcb6200f5b00d

            People

              sysprg Julius Goryavsky
              hholzgra Hartmut Holzgraefe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.