- buf_page_cleaner is signaled when the pages are added to the flush list.
- As part of the
MDEV-27774 changes the logic to signal buf_page_cleaner
accidentally got missed due to pass-by-value issue (expected pass-by-reference).
[mtr_t::commit flow would signal page cleaner if there are modified
blocks. The object that captured modified blocks was expected to get
passed by reference but accidentally got passed by value and so
page-cleaner thread was never signaled].
[Non-availability of the flushing of-course has effect on performance as could be observed from the attached graph].
- is caused by
-
MDEV-27774
Reduce scalability bottlenecks in mtr_t::commit()
-
-
Closed
{"report":{"fcp":840.9000000953674,"ttfb":248,"pageVisibility":"visible","entityId":108447,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"0a584ac3-1b45-4839-b90c-203815f6a69a","navigationType":0,"readyForUser":924.3000001907349,"redirectCount":0,"resourceLoadedEnd":1085.7000000476837,"resourceLoadedStart":253.60000014305115,"resourceTiming":[{"duration":7.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":253.60000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":253.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":261.10000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":7.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":253.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":253.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":261.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":68.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":254.10000014305115,"connectEnd":254.10000014305115,"connectStart":254.10000014305115,"domainLookupEnd":254.10000014305115,"domainLookupStart":254.10000014305115,"fetchStart":254.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":254.10000014305115,"responseEnd":322.80000019073486,"responseStart":322.80000019073486,"secureConnectionStart":254.10000014305115},{"duration":159.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":254.30000019073486,"connectEnd":254.30000019073486,"connectStart":254.30000019073486,"domainLookupEnd":254.30000019073486,"domainLookupStart":254.30000019073486,"fetchStart":254.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":254.30000019073486,"responseEnd":414.10000014305115,"responseStart":414.10000014305115,"secureConnectionStart":254.30000019073486},{"duration":163.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":254.5,"connectEnd":254.5,"connectStart":254.5,"domainLookupEnd":254.5,"domainLookupStart":254.5,"fetchStart":254.5,"redirectEnd":0,"redirectStart":0,"requestStart":254.5,"responseEnd":418.30000019073486,"responseStart":418.30000019073486,"secureConnectionStart":254.5},{"duration":166.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":254.80000019073486,"connectEnd":254.80000019073486,"connectStart":254.80000019073486,"domainLookupEnd":254.80000019073486,"domainLookupStart":254.80000019073486,"fetchStart":254.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":254.80000019073486,"responseEnd":421.10000014305115,"responseStart":421.10000014305115,"secureConnectionStart":254.80000019073486},{"duration":166.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":254.90000009536743,"connectEnd":254.90000009536743,"connectStart":254.90000009536743,"domainLookupEnd":254.90000009536743,"domainLookupStart":254.90000009536743,"fetchStart":254.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":254.90000009536743,"responseEnd":421.60000014305115,"responseStart":421.60000014305115,"secureConnectionStart":254.90000009536743},{"duration":215.89999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":255.10000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":255.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":471,"responseStart":0,"secureConnectionStart":0},{"duration":166.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":255.30000019073486,"connectEnd":255.30000019073486,"connectStart":255.30000019073486,"domainLookupEnd":255.30000019073486,"domainLookupStart":255.30000019073486,"fetchStart":255.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":255.30000019073486,"responseEnd":422.10000014305115,"responseStart":422.10000014305115,"secureConnectionStart":255.30000019073486},{"duration":215.60000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":255.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":255.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":471.10000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":167.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":255.70000004768372,"connectEnd":255.70000004768372,"connectStart":255.70000004768372,"domainLookupEnd":255.70000004768372,"domainLookupStart":255.70000004768372,"fetchStart":255.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":255.70000004768372,"responseEnd":422.80000019073486,"responseStart":422.80000019073486,"secureConnectionStart":255.70000004768372},{"duration":483.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":256.5,"connectEnd":256.5,"connectStart":256.5,"domainLookupEnd":256.5,"domainLookupStart":256.5,"fetchStart":256.5,"redirectEnd":0,"redirectStart":0,"requestStart":256.5,"responseEnd":740,"responseStart":740,"secureConnectionStart":256.5},{"duration":798.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":260.90000009536743,"connectEnd":260.90000009536743,"connectStart":260.90000009536743,"domainLookupEnd":260.90000009536743,"domainLookupStart":260.90000009536743,"fetchStart":260.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":260.90000009536743,"responseEnd":1059.8000001907349,"responseStart":1059.8000001907349,"secureConnectionStart":260.90000009536743},{"duration":257.60000014305115,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":482.7000000476837,"connectEnd":482.7000000476837,"connectStart":482.7000000476837,"domainLookupEnd":482.7000000476837,"domainLookupStart":482.7000000476837,"fetchStart":482.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":482.7000000476837,"responseEnd":740.3000001907349,"responseStart":740.3000001907349,"secureConnectionStart":482.7000000476837},{"duration":299.60000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":765.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":765.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1064.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":313.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":766.2000000476837,"connectEnd":766.2000000476837,"connectStart":766.2000000476837,"domainLookupEnd":766.2000000476837,"domainLookupStart":766.2000000476837,"fetchStart":766.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":766.2000000476837,"responseEnd":1079.9000000953674,"responseStart":1079.9000000953674,"secureConnectionStart":766.2000000476837},{"duration":319.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":766.6000001430511,"connectEnd":766.6000001430511,"connectStart":766.6000001430511,"domainLookupEnd":766.6000001430511,"domainLookupStart":766.6000001430511,"fetchStart":766.6000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":766.6000001430511,"responseEnd":1085.7000000476837,"responseStart":1085.7000000476837,"secureConnectionStart":766.6000001430511},{"duration":266,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":828.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":828.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1094.2000000476837,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":99,"responseStart":248,"responseEnd":252,"domLoading":251,"domInteractive":1096,"domContentLoadedEventStart":1096,"domContentLoadedEventEnd":1139,"domComplete":1564,"loadEventStart":1564,"loadEventEnd":1564,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1068.8000001907349},{"name":"bigPipe.sidebar-id.end","time":1069.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":1069.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.end","time":1071.3000001907349},{"name":"activityTabFullyLoaded","time":1153.8000001907349}],"measures":[],"correlationId":"95364814094e1b","effectiveType":"4g","downlink":9,"rtt":0,"serverDuration":94,"dbReadsTimeInMs":13,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Thank you! The following code indeed is unreachable because the object rb was being passed by value and not by reference, and only a copy of the mutable data member rb.modified was ever changed:
diff --git a/storage/innobase/mtr/mtr0mtr.cc b/storage/innobase/mtr/mtr0mtr.ccindex f486c2fe0e7..10f1d6f2d19 100644--- a/storage/innobase/mtr/mtr0mtr.cc+++ b/storage/innobase/mtr/mtr0mtr.cc@@ -462,6 +462,7 @@ void mtr_t::commit()if (rb.modified){+ ut_error;mysql_mutex_lock(&buf_pool.flush_list_mutex);buf_pool.flush_list_requests+= rb.modified;