Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27743

Remove Lex::charset

Details

    Description

      We want to pass more structures through the Bison stack instead of using Lex members.

      In particular, we want to get rid of Lex->charset.

      Reasons:

      • The current implementation is hard to follow and change. It has caused a few bugs already. Passing data through the bison stack is much easier to follow!
      • We'll have contextually typed collations soon: 

        -- Use the xxx_uca1400_as_ci collation of the column implicit character set:
        		 
        CREATE TABLE t1 (a CHAR(10) COLLATE uca1400_as_ci);

        The above will resolve to:

      • COLLATE utf8mb4_uca1400_as_ci (in case if the column character set is later resolved to utf8mb4)
      • COLLATE utf16_uca1400_as_ci (in case if the column character set is later resolved to utf16
      • and so on

      So the code logic must be simlified before this change.

      This change will also fix a few problems:

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-27009 Add UCA-14.0.0 collations

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30681 SIGFPE / UBSAN runtime error: division by zero in String::needs_conversion on ALTER

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30805 SIGSEGV in my_convert and UBSAN: member access within null pointer of type 'const struct MY_CHARSET_HANDLER' in my_convert

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34288 SET NAMES DEFAULT crashes `mariadbd --collation-server=utf8mb4_unicode_ci`

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27690 Crash on `CHARACTER SET csname COLLATE DEFAULT` in column definition

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27782 Wrong columns when using table level `CHARACTER SET utf8mb4 COLLATE DEFAULT`

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27853 Wrong data type on column `COLLATE DEFAULT` and table `COLLATE some_non_default_collation`

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28067 Multiple conflicting column COLLATE clauses are not rejected

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28118 Wrong collation of `CAST(.. AS CHAR COLLATE DEFAULT)`

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28119 Wrong column collation on MODIFY + CONVERT

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28117 Multiple conflicting table COLLATE clauses are not rejected

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            People

              serg Sergei Golubchik
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.