Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27686

Moving libexecinfo out of FreeBSD / OpenBSD specific CMake code

Details

    Description

      Currently the CMake code has checks for the libexecinfo library but it is in the FreeBSD / OpenBSD specific code in cmake/os/. This check should be moved to the main CMake file so it is not OS specific. NetBSD / DragonFlyBSD and musl-based Linux OS's (.e.g. Alpine Linux) also use libexecinfo from NetBSD in addition to FreeBSD and OpenBSD.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          brad0 Brad Smith created issue -
          danblack Daniel Black made changes -
          Field Original Value New Value
          Fix Version/s 10.2 [ 14601 ]
          danblack Daniel Black made changes -
          Assignee Daniel Black [ danblack ]
          danblack Daniel Black added a comment -

          Good idea. Are you doing a patch?

          danblack Daniel Black added a comment - Good idea. Are you doing a patch?
          brad0 Brad Smith made changes -
          Description Currently the CMake code has checks for the libexecinfo library but it is in the FreeBSD / OpenBSD specific code in cmake/os/. This check should be moved to the main CMake file so it is not OS specific. NetBSD / DragonFlyBSD and musl-based Linux OS's also use libexecinfo from NetBSD in addition to FreeBSD and OpenBSD. Currently the CMake code has checks for the libexecinfo library but it is in the FreeBSD / OpenBSD specific code in cmake/os/. This check should be moved to the main CMake file so it is not OS specific. NetBSD / DragonFlyBSD and musl-based Linux OS's (.e.g. Alpine Linux) also use libexecinfo from NetBSD in addition to FreeBSD and OpenBSD.
          brad0 Brad Smith added a comment -

          I am honestly not very good with CMake so I don't have anything at the moment.

          brad0 Brad Smith added a comment - I am honestly not very good with CMake so I don't have anything at the moment.
          serg Sergei Golubchik made changes -
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.7 [ 24805 ]
          serg Sergei Golubchik made changes -
          Assignee Daniel Black [ danblack ] Vladislav Vaintroub [ wlad ]
          wlad Vladislav Vaintroub made changes -
          issue.field.resolutiondate 2022-07-17 13:42:38.0 2022-07-17 13:42:38.502
          wlad Vladislav Vaintroub made changes -
          Component/s Platform FreeBSD [ 10139 ]
          Component/s Platform OpenBSD [ 10202 ]
          Fix Version/s 10.3.36 [ 27513 ]
          Fix Version/s 10.4.26 [ 27511 ]
          Fix Version/s 10.5.17 [ 27509 ]
          Fix Version/s 10.6.9 [ 27507 ]
          Fix Version/s 10.7.5 [ 27505 ]
          Fix Version/s 10.8.4 [ 27503 ]
          Fix Version/s 10.9.2 [ 27115 ]
          Fix Version/s 10.10.1 [ 27913 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.7 [ 24805 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          brad0 Brad Smith added a comment -

          Thanks. Tried the diff and it works fine. Looking at MY_SEARCH_LIBS() it would appear to do what I would expect.

          brad0 Brad Smith added a comment - Thanks. Tried the diff and it works fine. Looking at MY_SEARCH_LIBS() it would appear to do what I would expect.

          People

            wlad Vladislav Vaintroub
            brad0 Brad Smith
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.