Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26966

The parameter innodb_force_load_corrupted makes no sense

Details

    Description

      MySQL 5.5 introduced a configuration parameter innodb_force_load_corrupted whose purpose was to allow a corrupted table to be dropped.

      Given that MDEV-11412 in MariaDB 10.5.4 aims to allow any metadata for a missing or corrupted table to be dropped, and given that MDEV-17567 and MDEV-25506 and related tasks made DDL operations crash-safe, the parameter does not make any sense.

      A change that would deprecate and ignore this read-only parameter has been tested by mleich, and no problems related to that were found.

      Because this obscure parameter was read-only (not settable by a client), it seems that we could simply declare it with MARIADB_REMOVED_OPTION without breaking anything.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-11412 Ensure that table is truly dropped when using DROP TABLE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-17567 Atomic DDL

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25506 Atomic DDL: .frm file is removed and orphan InnoDB tablespace is left behind upon crash recovery

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25683 Atomic DDL: With innodb_force_recovery=3 InnoDB: Trying to load index but the index tree has been freed

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26933 InnoDB fails to detect page number mismatch

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä added a comment -

            The read-only parameter innodb_force_load_corrupted will be marked as removed starting with the 10.6.6 release.

            This will also remove some redundant messages that caught my eye in MDEV-25683.

            marko Marko Mäkelä added a comment - The read-only parameter innodb_force_load_corrupted will be marked as removed starting with the 10.6.6 release. This will also remove some redundant messages that caught my eye in MDEV-25683 .
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2021-11-04 08:28:01.0 2021-11-04 08:28:01.833
            marko Marko Mäkelä made changes -
            Fix Version/s 10.6.6 [ 26811 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 126961 ] MariaDB v4 [ 159824 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.