Details
-
Task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
Description
see MDEV-13756
Descending attribute will only for for BTREE indexes, for everything else (fulltext, spacial, hash) it'll be ignored as before
Attachments
Issue Links
- causes
-
MDEV-29992 Index corruption with multi-part key and nopad collation
-
- Open
-
-
-
- Closed
-
- is part of
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue is part of |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Marko Mäkelä [ marko ] | Sergei Golubchik [ serg ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
The interface between TABLE_SHARE and InnoDB is highlighted in this patch, which might be useful for debugging. I corrected the implementation of dtuple_coll_eq(), so that there no longer is any EXPLAIN result difference in the test main.update_use_source.
| Assignee | Sergei Golubchik [ serg ] | Alexander Barkov [ bar ] |
| Assignee | Alexander Barkov [ bar ] | Sergei Golubchik [ serg ] |
| Assignee | Sergei Golubchik [ serg ] | Alexander Barkov [ bar ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Assignee | Alexander Barkov [ bar ] | Sergei Golubchik [ serg ] |
| Status | Stalled [ 10000 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Stalled [ 10000 ] |
parser and frm support is pushed into bb-10.8-MDEV-26938
main.order_by and main.order_by_innodb show that ORDER BY works.
innodb_fts.create fails — CREATE TABLE is correctly rejected, but ALTER isn't. Likely something inside InnoDB doesn't check for HA_REVERSE_SORT on ALTER.
| Assignee | Sergei Golubchik [ serg ] | Marko Mäkelä [ marko ] |
| Status | Stalled [ 10000 ] | In Progress [ 3 ] |
I suggest that we only set the HA_REVERSE_SORT flag for B-tree indexes and never for FULLTEXT, SPATIAL, or HASH indexes that are not ordered.
All issues that I was able to identify were in the SQL layer. I pushed some suggested fixes, and disabled failing test with FIXME comments that identify the root cause. One of them is that in ALTER TABLE, the Key_part_spec::asc is not being set consistently or correctly.
| Assignee | Marko Mäkelä [ marko ] | Sergei Golubchik [ serg ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Assignee | Sergei Golubchik [ serg ] | Sergei Petrunia [ psergey ] |
Some raw ideas for RQG based testing:
|
It looks as if the RQG grammar conf/mariadb/concurrency.yy is some good candidate for RQG testing.
|
The DDL fiddles with ASC and DESC keys. Probably even in case of multi column keys.
|
1. Plain crash testing with concurrent sessions running some DDL/DML mix based on
|
--grammar=conf/mariadb/concurrency.yy --gendata=conf/mariadb/concurrency.zz --gendata_sql=conf/mariadb/concurrency.sql
|
2. Run "pseudo replication" (== any SQL gets sent to two servers) based on conf/mariadb/concurrency.yy (*)
|
- only one session runs the DDL/DML mix and the SQL should avoid statements which are unsafe in statement based replication
|
because otherwise "pseudo replication" is known to break
|
- probably costly modification in RQG code: When sending a DDL creating a key to the second server convert ASC to DESC and DESC to ASC
|
or
|
probably less costly: First server is 10.8 with MDEV-26938 , second server is 10.8 without MDEV-26938
|
- filter out any SQL containing LIMIT and do not execute that
|
- at test end compare the content of the tables of both servers
|
Variant: Compare the result sets of SELECTs executed on the first and the second server
|
(*) Alternative: Develop some new grammar or a simplified derivate of conf/mariadb/concurrency.yy
|
Results of ~ 15000 RQG tests using conf/mariadb/concurrency.yy and different setups (see 1. in the comment above):
|
In general low fraction of failing tests.
|
The failures observed occur on actual 10.6 too.
|
concurrency.yy has the advantage of using DESC indexes etc. at all.
|
But that does not guarantee to give some exceptional coverage of that feature.
|
The correctness of result sets could not be checked with that setup.
|
|
|
Test campaign with
|
- a derivate of the grammar table_stress_innodb.yy
|
ASC or DESC added to columns being part of some KEY
|
- some test setup derived from table_stress.cc
|
pluto:/data/rqg/results/1638191819
|
There are several new error patterns. Mostly in connection with Mariabackup.
|
I am now running the same campaign against actual 10.8.
|
| Workflow | MariaDB v3 [ 126836 ] | MariaDB v4 [ 131787 ] |
| Status | In Review [ 10002 ] | In Testing [ 10301 ] |
| Assignee | Sergei Petrunia [ psergey ] |
| Assignee | Matthias Leich [ mleich ] |
| Status | In Testing [ 10301 ] | Stalled [ 10000 ] |
| Assignee | Matthias Leich [ mleich ] |
| Status | Stalled [ 10000 ] | In Testing [ 10301 ] |
| Status | In Testing [ 10301 ] | Stalled [ 10000 ] |
The final preview branch in testing is preview-10.8-MDEV-13756-desc-indexes, so further testing will be done under MDEV-13756, while this one will remain "In testing" until MDEV-13756 with all the included parts is either accepted or rejected.
| Description |
see |
see Descending attribute will only for for BTREE indexes, for everything else (fulltext, spacial, hash) it'll be ignored as before |
| Assignee | Elena Stepanova [ elenst ] |
| Status | Stalled [ 10000 ] | In Testing [ 10301 ] |
| Assignee | Elena Stepanova [ elenst ] | Sergei Golubchik [ serg ] |
| Status | In Testing [ 10301 ] | Stalled [ 10000 ] |
| Fix Version/s | 10.8.1 [ 26815 ] | |
| Fix Version/s | 10.8 [ 26121 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Assignee | Sergei Golubchik [ serg ] | Marko Mäkelä [ marko ] |
| Link | This issue causes MDEV-29992 [ MDEV-29992 ] |
| Link |
This issue causes |
This cannot be tested before the HA_REVERSE_SORT flag is written to .frm files and will actually be preserved on CREATE TABLE and ALTER TABLE. See the test innodb_fts.create.