Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26929

Make the main testsuite runnable with optimizer trace enabled

Details

    Description

      This is a part of MDEV-23766.

      One can run the entire main testuite with optimizer trace enabled like so:

       ./mysql-test-run --suite=main --mysqld=--optimizer_trace=enabled=on
      

      On a 10.5-based tree, it fails just one test for me:

      CURRENT_TEST: main.opt_trace
      --- /optane/dev-git2/10.5-opt-trace-fix/mysql-test/main/opt_trace.result        2021-10-22 17:44:19.947288399 +0300
      +++ /optane/dev-git2/10.5-opt-trace-fix/mysql-test/main/opt_trace.reject        2021-10-22 18:05:12.727056238 +0300
      @@ -6,7 +6,7 @@
       OPTIMIZER_TRACE        INSUFFICIENT_PRIVILEGES
       show variables like 'optimizer_trace';
       Variable_name  Value
      -optimizer_trace        enabled=off
      +optimizer_trace        enabled=on
       set optimizer_trace="enabled=on";
       show variables like 'optimizer_trace';
       Variable_name  Value
       
      mysqltest: Result length mismatch
      
      

      If we can get that test to pass, we can get the buildbot to run this.

      We can run non-main testsuites as well, but this is considered to have less benefit.

      Attachments

        Issue Links

          Activity

            I see that now the commit d352bc5b6772f735a7e4bc540f578e0efc280e71 has been merged to all versions.

            psergei Sergei Petrunia added a comment - I see that now the commit d352bc5b6772f735a7e4bc540f578e0efc280e71 has been merged to all versions.

            Keeping this open until it is merged into all versions. Then, we can ask Elena to enable the optimizer-trace-enabled run in the buildbot.

            psergei Sergei Petrunia added a comment - Keeping this open until it is merged into all versions. Then, we can ask Elena to enable the optimizer-trace-enabled run in the buildbot.

            Pushed this into 10.4:

            commit d352bc5b6772f735a7e4bc540f578e0efc280e71 (HEAD -> 10.4, origin/bb-10.4-mdev26929-part2, origin/10.4, bb-10.4-mdev26929-part2)
            Author: Sergei Petrunia <psergey@askmonty.org>
            Date:   Fri Oct 29 11:44:09 2021 +0300
             
                MDEV-26929: Make the main testsuite runnable with optimizer trace enabled
                
                Part#2: check that compile-time default @@optimizer_trace is correct.
            

            psergei Sergei Petrunia added a comment - Pushed this into 10.4: commit d352bc5b6772f735a7e4bc540f578e0efc280e71 (HEAD -> 10.4, origin/bb-10.4-mdev26929-part2, origin/10.4, bb-10.4-mdev26929-part2) Author: Sergei Petrunia <psergey@askmonty.org> Date: Fri Oct 29 11:44:09 2021 +0300   MDEV-26929: Make the main testsuite runnable with optimizer trace enabled Part#2: check that compile-time default @@optimizer_trace is correct.

            psergei, the part2 looks ready for 10.4 to me.

            sergei.krivonos Sergei Krivonos (Inactive) added a comment - psergei , the part2 looks ready for 10.4 to me.

            Hi elenst,
            Feel free to add

            --mysqld=--optimizer_trace=enabled=on
            

            to buildbot

            sergei.krivonos Sergei Krivonos (Inactive) added a comment - Hi elenst , Feel free to add --mysqld=--optimizer_trace=enabled=on to buildbot

            People

              psergei Sergei Petrunia
              psergei Sergei Petrunia
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.