Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26836

ROW_NUMBER differs from the number in the error message upon ER_WARN_DATA_OUT_OF_RANGE

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • N/A
    • 10.7.1
    • Server
    • None

    Description

      CREATE OR REPLACE TABLE t (a INT);
      INSERT INTO t VALUES (1),(2);
      SELECT CAST(a AS DECIMAL(2,2)) AS f FROM t;
       
      get diagnostics condition 2 @n = row_number, @m = message_text;
      select @n, @m;
      

      bb-10.7-row_number cb9002bee

      +------+--------------------------------------------+
      | @n   | @m                                         |
      +------+--------------------------------------------+
      |    2 | Out of range value for column 'f' at row 1 |
      +------+--------------------------------------------+
      1 row in set (0.000 sec)
       
      MariaDB [test]> show warnings;
      +---------+------+--------------------------------------------+
      | Level   | Code | Message                                    |
      +---------+------+--------------------------------------------+
      | Warning | 1264 | Out of range value for column 'f' at row 1 |
      | Warning | 1264 | Out of range value for column 'f' at row 1 |
      +---------+------+--------------------------------------------+
      2 rows in set (0.000 sec)
      

      So, ROW_NUMBER looks correct and the error messages don't, but there was a requirement that the error message and the value of ROW_NUMBER must correlate, so probably the message should be fixed. Also, it is suspicious that it differs, if the same counter is supposed to be used.

      Attachments

        Issue Links

          Activity

            On the other hand, there was also a discussion that SELECT is out of scope. I'm not sure which one takes precedence – the requirement that the values should be the same, or the agreement that SELECT is not a mandatory part of the scope. Please feel free to demote/remove from 10.7 "must do" list.

            elenst Elena Stepanova added a comment - On the other hand, there was also a discussion that SELECT is out of scope. I'm not sure which one takes precedence – the requirement that the values should be the same, or the agreement that SELECT is not a mandatory part of the scope. Please feel free to demote/remove from 10.7 "must do" list.
            rucha174 Rucha Deodhar added a comment - Patch: https://github.com/MariaDB/server/commit/9ab0d07e10fdec9b9db59b3ac493045c5be253b0

            ok to push!

            serg Sergei Golubchik added a comment - ok to push!

            People

              rucha174 Rucha Deodhar
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.