Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26824

Can't add foreign key with empty referenced columns list

Details

    Description

      Assertion failure i==j on ADD FOREIGN KEY

      The following test case triggers a debug assertion failure during ALTER TABLE:

      --source include/have_innodb.inc
      		 
      CREATE TABLE t1(a INT PRIMARY KEY) ENGINE=InnoDB;
      		 
      CREATE TABLE t2(a INT PRIMARY KEY) ENGINE=InnoDB;
      		 
      ALTER TABLE t2 ADD FOREIGN KEY(a) REFERENCES t1;
      		 
      DROP TABLE t2, t1;

      10.5 f1acd9f14bd054b8d8d576c6fe567226c097132d

      		 
      mysqltest: At line 4: query 'ALTER TABLE t2 ADD FOREIGN KEY(a) REFERENCES t1' failed: 2013: Lost connection to MySQL server during query
      		 
      ...
      		 
      mariadbd: /mariadb/10.5/storage/innobase/handler/ha_innodb.cc:12306: dberr_t create_table_info_t::create_foreign_keys(): Assertion `i == j' failed.

      The reason appears to be that an empty column list will be passed for the REFERENCES t1. I would expect that the matching column names be looked up (in this case a) and their data type compatibility be checked before ha_innobase::create() is invoked.

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-20480 Obsolete internal parser for FK in InnoDB

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26554 Table-rebuilding DDL on parent table causes crash for INSERT into child table

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            midenok Aleksey Midenkov made changes -
            Labels regression-10.5 foreign-keys regression-10.5
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 126218 ] MariaDB v4 [ 143252 ]
            midenok Aleksey Midenkov made changes -
            Description The following test case triggers a debug assertion failure during {{ALTER TABLE}}:
            {code:sql}
            --source include/have_innodb.inc
            CREATE TABLE t1(a INT PRIMARY KEY) ENGINE=InnoDB;
            CREATE TABLE t2(a INT PRIMARY KEY) ENGINE=InnoDB;
            ALTER TABLE t2 ADD FOREIGN KEY(a) REFERENCES t1;
            DROP TABLE t2, t1;
            {code}
            {noformat:title=10.5 f1acd9f14bd054b8d8d576c6fe567226c097132d}
            mysqltest: At line 4: query 'ALTER TABLE t2 ADD FOREIGN KEY(a) REFERENCES t1' failed: 2013: Lost connection to MySQL server during query
            ...
            mariadbd: /mariadb/10.5/storage/innobase/handler/ha_innodb.cc:12306: dberr_t create_table_info_t::create_foreign_keys(): Assertion `i == j' failed.
            {noformat}
            The reason appears to be that an empty column list will be passed for the {{REFERENCES t1}}. I would expect that the matching column names be looked up (in this case {{a}}) and their data type compatibility be checked before {{ha_innobase::create()}} is invoked.             		Assertion failure i==j on ADD FOREIGN KEY

            The following test case triggers a debug assertion failure during {{ALTER TABLE}}:
            {code:sql}
            --source include/have_innodb.inc
            CREATE TABLE t1(a INT PRIMARY KEY) ENGINE=InnoDB;
            CREATE TABLE t2(a INT PRIMARY KEY) ENGINE=InnoDB;
            ALTER TABLE t2 ADD FOREIGN KEY(a) REFERENCES t1;
            DROP TABLE t2, t1;
            {code}
            {noformat:title=10.5 f1acd9f14bd054b8d8d576c6fe567226c097132d}
            mysqltest: At line 4: query 'ALTER TABLE t2 ADD FOREIGN KEY(a) REFERENCES t1' failed: 2013: Lost connection to MySQL server during query
            ...
            mariadbd: /mariadb/10.5/storage/innobase/handler/ha_innodb.cc:12306: dberr_t create_table_info_t::create_foreign_keys(): Assertion `i == j' failed.
            {noformat}
            The reason appears to be that an empty column list will be passed for the {{REFERENCES t1}}. I would expect that the matching column names be looked up (in this case {{a}}) and their data type compatibility be checked before {{ha_innobase::create()}} is invoked.
            midenok Aleksey Midenkov made changes -
            Summary Assertion failure i==j on ADD FOREIGN KEY Can't add foreign key with empty referenced columns list
            midenok Aleksey Midenkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            midenok Aleksey Midenkov added a comment -

            Please review bb-10.5-midenok

            midenok Aleksey Midenkov added a comment - Please review bb-10.5-midenok
            midenok Aleksey Midenkov made changes -
            Status In Progress [ 3 ] In Review [ 10002 ]
            midenok Aleksey Midenkov made changes -
            Assignee Aleksey Midenkov [ midenok ] Oleksandr Byelkin [ sanja ]
            sanja Oleksandr Byelkin added a comment -

            OK to push, but try to make better commit message (describe problem (what was wrong)).

            sanja Oleksandr Byelkin added a comment - OK to push, but try to make better commit message (describe problem (what was wrong)).
            sanja Oleksandr Byelkin made changes -
            Assignee Oleksandr Byelkin [ sanja ] Aleksey Midenkov [ midenok ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            midenok Aleksey Midenkov made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            midenok Aleksey Midenkov made changes -
            Fix Version/s 10.5.14 [ 26809 ]
            Fix Version/s 10.6.6 [ 26811 ]
            Fix Version/s 10.7.2 [ 26813 ]
            Fix Version/s 10.8.1 [ 26815 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]

            People

              midenok Aleksey Midenkov
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.