Hi, developers, thank you for your checking. It seems the lock thd->ctrl_mutex is not correctly released if it goes to the error, so there is a missing unlock in the *error *branch
pthread_mutex_lock(&thd->ctrl_mutex);
|
|
if (pthread_create(&thd->id, NULL, compress_worker_thread_func,
|
thd)) {
|
msg("compress: pthread_create() failed: "
|
"errno = %d", errno);
|
goto err;
|
}
|
}
|
|
/* Wait for the threads to start */
|
for (i = 0; i < n; i++) {
|
comp_thread_ctxt_t *thd = threads + i;
|
|
while (thd->started == FALSE)
|
pthread_cond_wait(&thd->ctrl_cond, &thd->ctrl_mutex);
|
pthread_mutex_unlock(&thd->ctrl_mutex);
|
}
|
|
return threads;
|
|
err:
|
my_free(threads);
|
return NULL;
|
}
|
https://github.com/MariaDB/server/blob/76f4a78ba2639b5abd01a88b24a3c509c11530ce/extra/mariabackup/ds_compress.cc#L364-L388
{"report":{"fcp":1261.8000001907349,"ttfb":467.90000009536743,"pageVisibility":"visible","entityId":102570,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"4665022b-efbc-44d9-b545-e6b986443c19","navigationType":0,"readyForUser":1339.3000001907349,"redirectCount":0,"resourceLoadedEnd":1725.6000001430511,"resourceLoadedStart":473.7000000476837,"resourceTiming":[{"duration":262.60000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":473.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":473.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":736.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":262.7000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":474,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":474,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":736.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":300.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":474.2000000476837,"connectEnd":474.2000000476837,"connectStart":474.2000000476837,"domainLookupEnd":474.2000000476837,"domainLookupStart":474.2000000476837,"fetchStart":474.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":474.2000000476837,"responseEnd":774.9000000953674,"responseStart":774.9000000953674,"secureConnectionStart":474.2000000476837},{"duration":348.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":474.30000019073486,"connectEnd":474.30000019073486,"connectStart":474.30000019073486,"domainLookupEnd":474.30000019073486,"domainLookupStart":474.30000019073486,"fetchStart":474.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":474.30000019073486,"responseEnd":823.2000000476837,"responseStart":823.2000000476837,"secureConnectionStart":474.30000019073486},{"duration":352.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":474.60000014305115,"connectEnd":474.60000014305115,"connectStart":474.60000014305115,"domainLookupEnd":474.60000014305115,"domainLookupStart":474.60000014305115,"fetchStart":474.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":474.60000014305115,"responseEnd":827,"responseStart":827,"secureConnectionStart":474.60000014305115},{"duration":352.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":474.80000019073486,"connectEnd":474.80000019073486,"connectStart":474.80000019073486,"domainLookupEnd":474.80000019073486,"domainLookupStart":474.80000019073486,"fetchStart":474.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":474.80000019073486,"responseEnd":827.4000000953674,"responseStart":827.4000000953674,"secureConnectionStart":474.80000019073486},{"duration":352.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":475,"connectEnd":475,"connectStart":475,"domainLookupEnd":475,"domainLookupStart":475,"fetchStart":475,"redirectEnd":0,"redirectStart":0,"requestStart":475,"responseEnd":827.8000001907349,"responseStart":827.8000001907349,"secureConnectionStart":475},{"duration":442.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":475.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":475.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":917.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":353,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":475.2000000476837,"connectEnd":475.2000000476837,"connectStart":475.2000000476837,"domainLookupEnd":475.2000000476837,"domainLookupStart":475.2000000476837,"fetchStart":475.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":475.2000000476837,"responseEnd":828.2000000476837,"responseStart":828.2000000476837,"secureConnectionStart":475.2000000476837},{"duration":442.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":475.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":475.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":917.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":353.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":475.60000014305115,"connectEnd":475.60000014305115,"connectStart":475.60000014305115,"domainLookupEnd":475.60000014305115,"domainLookupStart":475.60000014305115,"fetchStart":475.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":475.60000014305115,"responseEnd":828.8000001907349,"responseStart":828.8000001907349,"secureConnectionStart":475.60000014305115},{"duration":1246.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":476.40000009536743,"connectEnd":476.40000009536743,"connectStart":476.40000009536743,"domainLookupEnd":476.40000009536743,"domainLookupStart":476.40000009536743,"fetchStart":476.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":476.40000009536743,"responseEnd":1722.9000000953674,"responseStart":1722.9000000953674,"secureConnectionStart":476.40000009536743},{"duration":1243.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":480.7000000476837,"connectEnd":480.7000000476837,"connectStart":480.7000000476837,"domainLookupEnd":480.7000000476837,"domainLookupStart":480.7000000476837,"fetchStart":480.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":480.7000000476837,"responseEnd":1724,"responseStart":1724,"secureConnectionStart":480.7000000476837},{"duration":111.29999995231628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":929.2000000476837,"connectEnd":929.2000000476837,"connectStart":929.2000000476837,"domainLookupEnd":929.2000000476837,"domainLookupStart":929.2000000476837,"fetchStart":929.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":929.2000000476837,"responseEnd":1040.5,"responseStart":1040.5,"secureConnectionStart":929.2000000476837},{"duration":531.9000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1193.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1193.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1725.6000001430511,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":307,"responseStart":468,"responseEnd":473,"domLoading":471,"domInteractive":1750,"domContentLoadedEventStart":1750,"domContentLoadedEventEnd":1795,"domComplete":2378,"loadEventStart":2379,"loadEventEnd":2379,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1730},{"name":"bigPipe.sidebar-id.end","time":1731},{"name":"bigPipe.activity-panel-pipe-id.start","time":1731.1000001430511},{"name":"bigPipe.activity-panel-pipe-id.end","time":1732.4000000953674},{"name":"activityTabFullyLoaded","time":1809.6000001430511}],"measures":[],"correlationId":"e914509705a6c2","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":98,"dbReadsTimeInMs":13,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Ryan, did you want to try to submit a code change?
https://mariadb.org/get-involved/getting-started-for-developers/get-code-build-test/
https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request